New issue
Advanced search Search tips

Issue 913120 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Dec 17
Cc:
zamorzaev@chromium.org
akes...@chromium.org
pprabhu@chromium.org
ihf@chromium.org
hidehiko@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

bvt-cq failing with "test does not exist" error after test was deleted from Autotest repo

Project Member Reported by derat@chromium.org, Dec 7 
I've been deleting Autotest tests in bvt-inline and bvt-cq that have been ported to Tast lately (see issue 885910).

There have been some "platform_CheckCriticalProcesses: test does not exist" failures in bvt-cq today; see e.g. https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/CQ/b8927804858045236112.

In IM, Prathmesh wrote:

"the suite still knew about the test
and even the tarball with the "test" exists and was downloaded
but the tarball only contains a control file, and no test."

The deleted tests are still referenced in ebuilds (which I uploaded https://crrev.com/c/1368024 to fix), but it's not clear to me whether that's related to the failures.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a

commit 22f4d2d9aba417b1ae11ef195bf344e25a3bf30a
Author: Dan Erat <derat@chromium.org>
Date: Sat Dec 08 06:31:26 2018

Revert "autotest: Delete Check*Processes tests."

This reverts commit 9ccbe22723a5ecb1d31ea4b4957b7eb7e51f390a.

Reason for revert: bvt-cq is still trying to run these tests and
is failing with "test does not exist" errors.

Original change's description:
> autotest: Delete Check*Processes tests.
> 
> Delete the following tests, which have been replaced by the
> platform.CheckProcesses Tast test:
> 
> network_CheckCriticalProcesses
> platform_CheckCriticalProcesses
> platform_CheckDebugdProcesses
> platform_CheckMetricsProcesses
> platform_CheckPowerdProcesses
> platform_CheckTLSDateProcesses
> 
> BUG=chromium:885910
> TEST=none
> 
> Change-Id: I8b5c0a7fce1e5d28ffa5085feb77079688cc8e4d
> Reviewed-on: https://chromium-review.googlesource.com/1363823
> Commit-Ready: Dan Erat <derat@chromium.org>
> Tested-by: Dan Erat <derat@chromium.org>
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>

Bug: chromium:885910, chromium:913120 
Change-Id: I9c3ab460d5786c689a422c4beb8b65e0667245e3
Reviewed-on: https://chromium-review.googlesource.com/c/1369109
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/network_CheckCriticalProcesses/control
[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/platform_CheckDebugdProcesses/control
[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/platform_CheckMetricsProcesses/control
[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/platform_CheckCriticalProcesses/platform_CheckCriticalProcesses.py
[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/platform_CheckPowerdProcesses/control
[add] https://crrev.com/22f4d2d9aba417b1ae11ef195bf344e25a3bf30a/client/site_tests/platform_CheckTLSDateProcesses/control

Comment 2 by pprabhu@chromium.org, Dec 10

Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
I am not too well versed in the autotest pakager side of things.

That said, it's unlikely that this bug will bubble up to P1 given that it only affects stuff when we delete tests (which happens infrequently).

Comment 3 by derat@chromium.org, Dec 10

Cc: akes...@chromium.org pprabhu@chromium.org nya@chromium.org ihf@chromium.org hidehiko@chromium.org
I (along with nya@ and hidehiko@) are planning to delete a bunch of tests -- see issue 885910.

Will we be able to avoid this failure by removing the tests from suites first, waiting a day (or whatever), and only then deleting the tests from the Autotest repo and from IUSE_TESTS vars in ebuilds?

Comment 4 by ihf@chromium.org, Dec 10 

You remove tests from the ebuilds first. Then they are gone from the lab (but not test_that).

If then you still get the error removing control files, it means that infra got the versioning of autotest tarballs mixed up.

Comment 5 by derat@chromium.org, Dec 17

Status: WontFix (was: Available)
Thanks. Removing from ebuilds doesn't appear to have caused test failures, at least.
►

Sign in to add a comment