New issue
Advanced search Search tips

Issue 913103 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 11
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Removing ACCESS_POINT_FORCE_SIGNIN_WARNING breaks metrics

Project Member Reported by zmin@chromium.org, Dec 7

Issue description

We need it back so that the enum matches the enum.xml
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/675c6892da37d31abf254e724d416387c839b921

commit 675c6892da37d31abf254e724d416387c839b921
Author: Owen Min <zmin@chromium.org>
Date: Tue Dec 11 18:40:43 2018

Re-add unsed access point of sign in metrics

Removing the deprecated enum option breaks metrics count. Add it back with
a deprecation message.

Bug:  913103 
Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1
Reviewed-on: https://chromium-review.googlesource.com/c/1368632
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615603}
[modify] https://crrev.com/675c6892da37d31abf254e724d416387c839b921/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/675c6892da37d31abf254e724d416387c839b921/components/signin/core/browser/signin_metrics_unittest.cc

Labels: -Pri-3 Merge-Request-72 Pri-2
This CL needs to be merged into 72 as it fixes an issue that break metrics counting.
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2f06768457aec18465f6c090ede6f0e669af51

commit 8a2f06768457aec18465f6c090ede6f0e669af51
Author: Owen Min <zmin@chromium.org>
Date: Wed Dec 12 17:55:05 2018

Merge "Re-add unsed access point of sign in metrics"

Merge this into M72.

Removing the deprecated enum option breaks metrics count. Add it back with
a deprecation message.

Bug:  913103 
Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1
Reviewed-on: https://chromium-review.googlesource.com/c/1368632
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615603}(cherry picked from commit 675c6892da37d31abf254e724d416387c839b921)
Reviewed-on: https://chromium-review.googlesource.com/c/1374156
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#290}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/8a2f06768457aec18465f6c090ede6f0e669af51/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/8a2f06768457aec18465f6c090ede6f0e669af51/components/signin/core/browser/signin_metrics_unittest.cc

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/8a2f06768457aec18465f6c090ede6f0e669af51

Commit: 8a2f06768457aec18465f6c090ede6f0e669af51
Author: zmin@chromium.org
Commiter: zmin@chromium.org
Date: 2018-12-12 17:55:05 +0000 UTC

Merge "Re-add unsed access point of sign in metrics"

Merge this into M72.

Removing the deprecated enum option breaks metrics count. Add it back with
a deprecation message.

Bug:  913103 
Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1
Reviewed-on: https://chromium-review.googlesource.com/c/1368632
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615603}(cherry picked from commit 675c6892da37d31abf254e724d416387c839b921)
Reviewed-on: https://chromium-review.googlesource.com/c/1374156
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#290}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Status: Fixed (was: Assigned)

Sign in to add a comment