Removing ACCESS_POINT_FORCE_SIGNIN_WARNING breaks metrics |
||||||
Issue descriptionWe need it back so that the enum matches the enum.xml
,
Dec 11
This CL needs to be merged into 72 as it fixes an issue that break metrics counting.
,
Dec 12
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2f06768457aec18465f6c090ede6f0e669af51 commit 8a2f06768457aec18465f6c090ede6f0e669af51 Author: Owen Min <zmin@chromium.org> Date: Wed Dec 12 17:55:05 2018 Merge "Re-add unsed access point of sign in metrics" Merge this into M72. Removing the deprecated enum option breaks metrics count. Add it back with a deprecation message. Bug: 913103 Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1 Reviewed-on: https://chromium-review.googlesource.com/c/1368632 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615603}(cherry picked from commit 675c6892da37d31abf254e724d416387c839b921) Reviewed-on: https://chromium-review.googlesource.com/c/1374156 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#290} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/8a2f06768457aec18465f6c090ede6f0e669af51/components/signin/core/browser/signin_metrics.h [modify] https://crrev.com/8a2f06768457aec18465f6c090ede6f0e669af51/components/signin/core/browser/signin_metrics_unittest.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2f06768457aec18465f6c090ede6f0e669af51 Commit: 8a2f06768457aec18465f6c090ede6f0e669af51 Author: zmin@chromium.org Commiter: zmin@chromium.org Date: 2018-12-12 17:55:05 +0000 UTC Merge "Re-add unsed access point of sign in metrics" Merge this into M72. Removing the deprecated enum option breaks metrics count. Add it back with a deprecation message. Bug: 913103 Change-Id: Ia06712e466747989e38cf999dd199918e995a8c1 Reviewed-on: https://chromium-review.googlesource.com/c/1368632 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615603}(cherry picked from commit 675c6892da37d31abf254e724d416387c839b921) Reviewed-on: https://chromium-review.googlesource.com/c/1374156 Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#290} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 11
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 11