New issue
Advanced search Search tips

Issue 913102 link

Starred by 1 user
Status: Fixed
Owner:
iannu...@google.com
Closed: Dec 10
Cc:
iannu...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 909848



Sign in to add a comment

General recipe cleanup

Project Member Reported by iannu...@google.com, Dec 7 
There's some cruft that needs to be cleaned up in recipes.py to help with the build.proto'fication:

  * removal of 'remote' subcommand
  * making the recipe engine repo a real recipe repo (ironic, I know). recipes.py at the base needs to be a real recipes.py wrapper script.

Comment 1 by iannu...@google.com, Dec 7

Components: Infra>Platform>Recipes
Owner: iannu...@google.com
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2

commit 7bf15aaea60841beb1973a1b0ec19f3be3ec53b2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Dec 07 22:59:34 2018

[remote] Remove remote subcommand.

This is only used on buildbot, but that uses a pinned version of the
recipe engine:

https://cs.chromium.org/chromium/build/scripts/slave/remote_run.py?q=remote_run.py&sq=package:chromium&dr=C&l=122

(which is pinned to https://chromium.googlesource.com/infra/luci/recipes-py/+/6eaacf24833ebd2565177157d368da33780fced9)

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug:  913102 ,  697978 
Change-Id: I0ac00cc147262672c412ad2844a3b5c1d9219513
Reviewed-on: https://chromium-review.googlesource.com/c/1368749
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/unittests/test_test.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/common_args.py
[delete] https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99/unittests/remote_test.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/doc/user_guide.md
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipes.py
[delete] https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99/recipe_engine/remote.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/unittests/autoroll_test.py
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/03ee2d619043c4bacf6b17c4d5cfb3cd607026be

commit 03ee2d619043c4bacf6b17c4d5cfb3cd607026be
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Dec 08 01:04:49 2018

[recipes] Manually roll recipes.

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug:  913102 
Change-Id: I207e6e5a13980e3819c2b4deb3c01c38c28ed876
Recipe-Manual-Change: infra
Recipe-Manual-Change: build
Recipe-Manual-Change: skia
Recipe-Manual-Change: skiabuildbot
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Reviewed-on: https://chromium-review.googlesource.com/c/1368410
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/03ee2d619043c4bacf6b17c4d5cfb3cd607026be/recipes/README.recipes.md
[modify] https://crrev.com/03ee2d619043c4bacf6b17c4d5cfb3cd607026be/recipes/recipes.py
[modify] https://crrev.com/03ee2d619043c4bacf6b17c4d5cfb3cd607026be/infra/config/recipes.cfg
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c82986c7d25b45262953d1b9bd6645a436fdb42a

commit c82986c7d25b45262953d1b9bd6645a436fdb42a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Dec 08 01:12:01 2018

[recipes] Manually roll recipes.

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug:  913102 
Change-Id: I8bc39f84b13282514ec0b743a0968d263bff3035
Recipe-Manual-Change: infra
Recipe-Manual-Change: build_limited_scripts_slave
Recipe-Manual-Change: release_scripts
Reviewed-on: https://chromium-review.googlesource.com/c/1368500
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/c82986c7d25b45262953d1b9bd6645a436fdb42a/scripts/slave/README.recipes.md
[modify] https://crrev.com/c82986c7d25b45262953d1b9bd6645a436fdb42a/infra/config/recipes.cfg
[modify] https://crrev.com/c82986c7d25b45262953d1b9bd6645a436fdb42a/scripts/slave/recipes.py
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/cbb6d0de9685dbed4c978eb75cfede381b40345d

commit cbb6d0de9685dbed4c978eb75cfede381b40345d
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Dec 08 01:27:10 2018
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ee778f7bbe56b4698db976e2e26f2d0b3fe17326

commit ee778f7bbe56b4698db976e2e26f2d0b3fe17326
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Dec 08 01:31:44 2018
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/91bf3defa907a7dabebe0ce4c971b3698d20b620

commit 91bf3defa907a7dabebe0ce4c971b3698d20b620
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Dec 08 01:47:15 2018

[recipes] Manually roll recipes

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug:  913102 
Change-Id: Idbd97b717465dde0615259e92e4f490e81efa1a3
Reviewed-on: https://chromium-review.googlesource.com/c/1368501
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19437}
[modify] https://crrev.com/91bf3defa907a7dabebe0ce4c971b3698d20b620/recipes/README.recipes.md
[modify] https://crrev.com/91bf3defa907a7dabebe0ce4c971b3698d20b620/recipes/recipes.py
[modify] https://crrev.com/91bf3defa907a7dabebe0ce4c971b3698d20b620/infra/config/recipes.cfg
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdaa7c078898439899fba93789f22229f2e23e16

commit cdaa7c078898439899fba93789f22229f2e23e16
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Dec 08 04:34:17 2018

Roll src/third_party/depot_tools 4be60eeb2259..03ee2d619043 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4be60eeb2259..03ee2d619043


git log 4be60eeb2259..03ee2d619043 --date=short --no-merges --format='%ad %ae %s'
2018-12-08 iannucci@chromium.org [recipes] Manually roll recipes.
2018-12-08 friedman@google.com [metrics] Use unicode box-drawing chars and goo.gl link instead


Created with:
  gclient setdep -r src/third_party/depot_tools@03ee2d619043

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:913102 
TBR=agable@chromium.org

Change-Id: I44615c07171416bd3c6fcf3bd9d22092564b3905
Reviewed-on: https://chromium-review.googlesource.com/c/1368734
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614946}
[modify] https://crrev.com/cdaa7c078898439899fba93789f22229f2e23e16/DEPS
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot/+/20623422a5db3ac5158c485be8c5d3768fb5a266

commit 20623422a5db3ac5158c485be8c5d3768fb5a266
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Dec 10 12:27:13 2018

[recipes] Manually roll recipes

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

  https://crrev.com/095f4b84e4c62983829973f51f0c46f95022806a

R=borenet@google.com, rmistry@google.com

Bug:  chromium:913102 
Change-Id: I8823b2acf8825dba42b8246309316713a3dc2fac
Reviewed-on: https://skia-review.googlesource.com/c/175814
Auto-Submit: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/20623422a5db3ac5158c485be8c5d3768fb5a266/infra/bots/README.recipes.md
[modify] https://crrev.com/20623422a5db3ac5158c485be8c5d3768fb5a266/infra/bots/recipes.py
[modify] https://crrev.com/20623422a5db3ac5158c485be8c5d3768fb5a266/infra/config/recipes.cfg
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e1c2354d08ba5f761bcf22d5036488e038f72d99

commit e1c2354d08ba5f761bcf22d5036488e038f72d99
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Dec 10 12:54:53 2018

[recipes] Manually roll recipes

This commit changes the layout of recipe_engine a bit which breaks the
autoroller.

  https://crrev.com/095f4b84e4c62983829973f51f0c46f95022806a

R=borenet@google.com, rmistry@google.com

Bug:  chromium:913102 
Change-Id: Ic6405fbe5ebd00e453677c5050d089e678153d00
Reviewed-on: https://skia-review.googlesource.com/c/175813
Auto-Submit: Robbie Iannucci <iannucci@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/e1c2354d08ba5f761bcf22d5036488e038f72d99/infra/config/recipes.cfg
[modify] https://crrev.com/e1c2354d08ba5f761bcf22d5036488e038f72d99/infra/bots/recipes.py
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9097b27fb3a728473ce9e38e25bf9deeea2a444

commit c9097b27fb3a728473ce9e38e25bf9deeea2a444
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 10 15:04:48 2018

Roll src/third_party/skia 1a592c2a3dee..e1c2354d08ba (1 commits)

https://skia.googlesource.com/skia.git/+log/1a592c2a3dee..e1c2354d08ba


git log 1a592c2a3dee..e1c2354d08ba --date=short --no-merges --format='%ad %ae %s'
2018-12-10 iannucci@chromium.org [recipes] Manually roll recipes


Created with:
  gclient setdep -r src/third_party/skia@e1c2354d08ba

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:913102 
TBR=ethannicholas@chromium.org

Change-Id: I8c5d768a03399f9f37ed9f00b7ca1966ed7983c7
Reviewed-on: https://chromium-review.googlesource.com/c/1369829
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615118}
[modify] https://crrev.com/c9097b27fb3a728473ce9e38e25bf9deeea2a444/DEPS

Comment 12 by iannu...@google.com, Dec 10

Status: Fixed (was: Started)
These two cleanups are done; will open a new bug(s) for additional cleanups as needed.
►

Sign in to add a comment