Issue metadata
Sign in to add a comment
|
Crosperf fails when cwp_dso is set for webrtc benchmark |
||||||||||||||||||||||||
Issue description
When running telemetry_Crosperf with cwp_dso newly introduced, we got IndexError("index out of range") when running webrtc benchmark with story tag.
This is because we did not introduce cpu_cycles to result correctly (wrong location and missing unit) and need to be fixed for further steps.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/5192d7f28c96bfa03741b787e70ba996a9735190 commit 5192d7f28c96bfa03741b787e70ba996a9735190 Author: Zhizhou Yang <zhizhouy@google.com> Date: Tue Dec 11 21:00:56 2018 crosperf: fix cpu_cycles in result_cache When cwp_dso is specified, we want to introduce cpu_cycles as a key into keyvals in Result object. This patch fixes the issue that cpu_cycles should be a number with unit. BUG= chromium:913086 TEST=passes webrtc benchmark with story tag Change-Id: I166bef15eeed2f7ae414b665843c8fd1f69b2580 Reviewed-on: https://chromium-review.googlesource.com/1368750 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/5192d7f28c96bfa03741b787e70ba996a9735190/crosperf/results_cache.py
,
Dec 21
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zhizhouy@chromium.org
, Dec 8