New issue
Advanced search Search tips

Issue 913084 link

Starred by 2 users
Status: Fixed
Owner:
l...@chromium.org
Closed: Dec 13
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
l...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: opening/reloading inspector should not auto-highlight nodes

Project Member Reported by l...@chromium.org, Dec 7 
What steps will reproduce the problem?
(1) Open DevTools and select any node in Elements panel
(2) Close+Open DevTools or Refresh

What is the expected result?
No element should be highlighted with a blue page overlay

What happens instead?
The default selected node is highlighted with blue overlay

Most likely a regression due to:
https://chromium.googlesource.com/chromium/src/+/6d8ff26fcfe69dfbfb8e687169f362fec1834600

Comment 1 by l...@chromium.org, Dec 11

Cc: nyerramilli@chromium.org rbasuvula@chromium.org l...@chromium.org
 Issue 913833  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3905efccbdcf2eb872d1c6a2ba652a58c12486f5

commit 3905efccbdcf2eb872d1c6a2ba652a58c12486f5
Author: Erik Luo <luoe@chromium.org>
Date: Thu Dec 13 03:39:39 2018

DevTools: fix flickering, unwanted node highlight in Elements

Panel switching and page reloading could trigger re-focusing the
ElementsTreeOutline, producing unwanted node overlays.

In this CL
- Trees highlight nodes when selection changes (pre-Nov behavior),
  instead of highlight on focusin
- Hide node highlight when focus moves to non-highlightable elements
- Console will use a custom method to select and ensure the node is
  highlighted

Bug:  913084 
Change-Id: I8b56b77c0aa8c34f5f7a819434510d549b139650
Reviewed-on: https://chromium-review.googlesource.com/c/1368770
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616197}
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/renderer/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeElement.js
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/renderer/devtools/front_end/elements/ElementsTreeOutline.js
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/renderer/devtools/front_end/sdk/OverlayModel.js
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/renderer/devtools/front_end/ui/treeoutline.js
[modify] https://crrev.com/3905efccbdcf2eb872d1c6a2ba652a58c12486f5/third_party/blink/web_tests/http/tests/devtools/console/viewport-testing/console-key-expand-expected.txt

Comment 3 by l...@chromium.org, Dec 13

Status: Fixed (was: Assigned)
While the root cause is fixed, the symptom from  issue 913833  is still present.  For now, I would not like to change that behavior, as it is minor and does not hurt the experience.
►

Sign in to add a comment