New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913062 link

Starred by 3 users
Status: Assigned
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Cc:
agrieve@chromium.org
mheikal@chromium.org
█ wnwen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

We should enforce that tools/android/roll/android_deps/fetch_all.py is a no-op

Project Member Reported by agrieve@chromium.org, Dec 7 
At least 50% of people that add new libraries end up making custom changes to the sections generated by fetch_all.py.

fetch_all.py already has a mode where it checks that things are up-to-date (just run it with no flags).

Perhaps the easiest thing to do is add a PRESUBMIT.py to //third_party/android_deps?

It's a bit slow, but probably worth it.

Comment 1 by agrieve@chromium.org, Dec 7 

Also, from discussions on:
https://chromium-review.googlesource.com/c/chromium/src/+/1366267/5

It doesn't look like the script asserts that no custom changes were made to BUILD.gn.

Comment 2 by wnwen@chromium.org, Dec 20

Labels: DevX
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5ade41f064036101284f890245d1f2ccbd4bc35

commit e5ade41f064036101284f890245d1f2ccbd4bc35
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 02 21:40:42 2019

Android: Include full command for android_deps

Easier copy/pasting when ensuring updates or additions are no-ops.

Bug: 913062
Change-Id: I5b5952403e2912e6f97bff086cfebf021b2954dd
Reviewed-on: https://chromium-review.googlesource.com/c/1393437
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619503}
[modify] https://crrev.com/e5ade41f064036101284f890245d1f2ccbd4bc35/tools/android/roll/android_deps/README.md

Comment 4 by wnwen@chromium.org, Jan 3

Cc: wnwen@chromium.org mheikal@chromium.org agrieve@chromium.org
 Issue 911677  has been merged into this issue.

Comment 5 by agrieve@chromium.org, Jan 14

Labels: QuickFix
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7cfa8a57e44bf1241992e115632f4c1293b407f

commit e7cfa8a57e44bf1241992e115632f4c1293b407f
Author: Peter Wen <wnwen@chromium.org>
Date: Wed Jan 16 23:20:56 2019

Android: Clean up README for javapoet

Run:
  rm -rf third_party/android_deps/libs/[!O]*
  tools/android/roll/android_deps/fetch_all.py --update-all

This should be a no-op after this CL.

Bug: 913062
Change-Id: Ie026c85505509a5e87a458bf23f2d7f7bff0a67a
Reviewed-on: https://chromium-review.googlesource.com/c/1416393
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623440}
[modify] https://crrev.com/e7cfa8a57e44bf1241992e115632f4c1293b407f/third_party/android_deps/libs/com_squareup_javapoet/README.chromium
►

Sign in to add a comment