New issue
Advanced search Search tips

Issue 913046 link

Starred by 1 user
Status: Started
Owner:
vincb@google.com
Cc:
rogerm@chromium.org
ma...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: ----



Sign in to add a comment

Send API key to Autofill endpoints that are Google

Project Member Reported by vincb@google.com, Dec 7 
Feature description:

We want to send the Chrome API key to any Google endpoint that provides the Autofill service and we don't want to send the API key to non-Google endpoints.

Eng owner: vincb
Product owner: durgapandey

Are you planning on experimenting before launch?

This is a small patch, we will not experiment.

Any new strings?

No

Any implications for Google webservices (i.e. sync, translate)?

Only implies the Autofill service we own.

Binary size?

Will not introduce any significant change.

Do the existing perf tests exercise all aspects of your new feature(s)?

Yes

Comment 1 by ma...@chromium.org, Dec 7

Labels: -Merge-Request-72
Status: Started (was: Assigned)
Let's add the merge request once the fix is in master (top of tree).

Setting to "started" since you've started looking at the fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/801d7bb6f954296b5c30537fd38be05e7fbbd9bb

commit 801d7bb6f954296b5c30537fd38be05e7fbbd9bb
Author: Vincent Boisselle <vincb@chromium.org>
Date: Mon Dec 10 16:56:07 2018

Added a check for the Autofill API url to make sure that calls are made to Google endpoints and added api key to legacy server requests.

Bug: 913046
Change-Id: I4897aabe83c05e9b19760b689a9c8c23b2595ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1368446
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615148}
[modify] https://crrev.com/801d7bb6f954296b5c30537fd38be05e7fbbd9bb/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/801d7bb6f954296b5c30537fd38be05e7fbbd9bb/components/autofill/core/browser/autofill_download_manager_unittest.cc

Comment 3 by vincb@google.com, Dec 10

Labels: Merge-Request-72

Comment 4 by abdulsyed@chromium.org, Dec 10 

Let's verify this in canary first.

Comment 5 by vincb@google.com, Dec 11 

abdulsyed@chromium.org,

I tested Autofill in the canary on Mac at version 73.0.3637 and it worked fine. I verified that my CL landed in that canary.
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 11

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f83fd23fc2ec8d90059c788444f2a02337d63e12

commit f83fd23fc2ec8d90059c788444f2a02337d63e12
Author: Vincent Boisselle <vincb@chromium.org>
Date: Tue Dec 11 18:36:11 2018

Added a check for the Autofill API url to make sure that calls are made to Google endpoints and added api key to legacy server requests.

Bug: 913046
Change-Id: I4897aabe83c05e9b19760b689a9c8c23b2595ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1368446
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615148}(cherry picked from commit 801d7bb6f954296b5c30537fd38be05e7fbbd9bb)
Reviewed-on: https://chromium-review.googlesource.com/c/1372238
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#256}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/f83fd23fc2ec8d90059c788444f2a02337d63e12/components/autofill/core/browser/autofill_download_manager.cc
[modify] https://crrev.com/f83fd23fc2ec8d90059c788444f2a02337d63e12/components/autofill/core/browser/autofill_download_manager_unittest.cc
Project Member

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/f83fd23fc2ec8d90059c788444f2a02337d63e12

Commit: f83fd23fc2ec8d90059c788444f2a02337d63e12
Author: vincb@chromium.org
Commiter: mathp@chromium.org
Date: 2018-12-11 18:36:11 +0000 UTC

Added a check for the Autofill API url to make sure that calls are made to Google endpoints and added api key to legacy server requests.

Bug: 913046
Change-Id: I4897aabe83c05e9b19760b689a9c8c23b2595ec7
Reviewed-on: https://chromium-review.googlesource.com/c/1368446
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615148}(cherry picked from commit 801d7bb6f954296b5c30537fd38be05e7fbbd9bb)
Reviewed-on: https://chromium-review.googlesource.com/c/1372238
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#256}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 9 by benhenry@google.com, Jan 11

Labels: Pri-2
Setting defect without priority to default.
►

Sign in to add a comment