Disable vulcan on beta/stable branches until feature is ready. |
|||||
Issue descriptionIt's enabled on trunk for ease of development, but we don't want to take the binary size hit until the feature will be used.
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
Pls merge you change to M72 branch 3626 ASAP so we can pick it up for next Dev/Beta release, RC cut on Monday, 12/10 @ 1:00 PM PT. Thank you.
,
Dec 10
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468 commit 6456fc70059d28d1ccdf88e1bbe2d88bb2bce468 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Dec 10 18:47:43 2018 Android: Disable Vulcan for beta branch to save binary size. Going to do this until the feature is fully ready. This reverts commit 7b94ba6bf5473fb6506895620a21ca5246d3068a. Bug: 850725 , 913044 Change-Id: I0d968803e76e29ba583220434afa14a4581617c3 Reviewed-on: https://chromium-review.googlesource.com/c/1368408 Reviewed-by: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#219} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468/gpu/vulkan/features.gni
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6456fc70059d28d1ccdf88e1bbe2d88bb2bce468 Commit: 6456fc70059d28d1ccdf88e1bbe2d88bb2bce468 Author: agrieve@chromium.org Commiter: agrieve@chromium.org Date: 2018-12-10 18:47:43 +0000 UTC Android: Disable Vulcan for beta branch to save binary size. Going to do this until the feature is fully ready. This reverts commit 7b94ba6bf5473fb6506895620a21ca5246d3068a. Bug: 850725 , 913044 Change-Id: I0d968803e76e29ba583220434afa14a4581617c3 Reviewed-on: https://chromium-review.googlesource.com/c/1368408 Reviewed-by: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#219} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by agrieve@chromium.org
, Dec 7