New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913032 link

Starred by 1 user
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Dec 20
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 893787



Sign in to add a comment

When filing a bug with a culprit CL, assign it to that CL's author.

Project Member Reported by jyasskin@chromium.org, Dec 7 
When sheriffing yesterday, when I saw a bug like  https://crbug.com/912979 , where FindIt had found a culprit CL, the first thing I did was assign it to the CL's author, CC anyone cc'ed on the CL, maybe try to add a component, for which a good guess was the component of any bug in the CL, and give them a chance to comment before reverting their CL. Those are all steps FindIt could take itself.

You might also be able to integrate with Hangouts to ping them directly, taking their timezone into account, and falling back to the CL's reviewer if the author's asleep.

You could more heuristically do something similar with unattributed flaky tests, like  https://crbug.com/913025 , using the last couple OWNERS who modified or reviewed the test and the components of the CLs that modified them. Filtering by OWNERS instead of just CL authors reduces the risk of assigning bugs to innocent bystanders like https://crrev.com/610740 that are making widespread changes.

Comment 1 by st...@chromium.org, Dec 7

Labels: -Pri-2 Pri-1
Many thanks for the feedback, jyasskin@!

We will prioritize this to start with a simple one and evolve along the way.
1. assign to the author if the account is @chromium.org
2. otherwise pick a reviewer who lgtmed the CL and has a @chromium.org or @google.com account

Does that sound good to you as a first step?

Comment 2 by st...@chromium.org, Dec 7

Status: Available (was: Unconfirmed)

Comment 3 by lijeffrey@chromium.org, Dec 7

Owner: lijeffrey@chromium.org
Status: Assigned (was: Available)

Comment 4 by lijeffrey@chromium.org, Dec 7

Blocking: 893787

Comment 5 by jyasskin@chromium.org, Dec 7 

Yes, that sounds great to me.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/470a5440f99935796adf3c200bb55f218c5e8f3e

commit 470a5440f99935796adf3c200bb55f218c5e8f3e
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Dec 17 18:52:51 2018

[Findit] Flake Analyzer - Auto assign bug owners based on CL author

1. If the issue in Monorail already has an owner assigned, leave it alone.
2. If the analysis has no culprit, no owner will be assigned.
3. If the culprit's author ends in @chromium.org or @google.com, auto
   assign to them.

Fallback logic should be implemented in a subsequent CL to try the reviewer if
the author is neither @chromium.org nor @google.com.

Bug:  913032 
Change-Id: Ia9cd0c8500aee66e658d4e7ee9c7e39b463b3921
Reviewed-on: https://chromium-review.googlesource.com/c/1377350
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19597}
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/test/monorail_util_test.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/test/flake_issue_util_test.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/pipelines/flake_failure/test/update_monorail_bug_pipeline_test.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/test/issue_generator_test.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/git.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/monorail_util.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/test/git_test.py
[modify] https://crrev.com/470a5440f99935796adf3c200bb55f218c5e8f3e/appengine/findit/services/issue_generator.py

Comment 7 by lijeffrey@chromium.org, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment