New issue
Advanced search Search tips

Issue 913014 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Make web locks request/release O(1)

Project Member Reported by andreasbutler@google.com, Dec 7

Issue description

Modify the web locks request/release algorithms to be O(1)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a49f0de5ba88ea1c68f73918772a5f3b7e703c

commit 33a49f0de5ba88ea1c68f73918772a5f3b7e703c
Author: Andreas Butler <andreasbutler@google.com>
Date: Fri Jan 11 00:49:30 2019

[WebLocks]: Modifying weblocks algos to be O(1)

The behaviour of the request/release operations of web locks are
modified to be O(1) instead of their currently O(n) worst case runtime.
Additionally the query-order wpt is modified to reflect the new spec
requirement that the state returned by navigator.locks.query need only
respect ordering for requested locks per resource.

Bug: 913014
Change-Id: I819f8c27c995cb698a7c8b2c75ee80d32c744f07
Spec: https://wicg.github.io/web-locks/#algorithms
Reviewed-on: https://chromium-review.googlesource.com/c/1367910
Commit-Queue: Andreas Butler <andreasbutler@google.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621833}
[modify] https://crrev.com/33a49f0de5ba88ea1c68f73918772a5f3b7e703c/content/browser/locks/lock_manager.cc
[delete] https://crrev.com/34c46f77e4b6828216ef90edd691d07dae15e411/third_party/blink/web_tests/external/wpt/web-locks/query-order.tentative.https.any.js
[add] https://crrev.com/33a49f0de5ba88ea1c68f73918772a5f3b7e703c/third_party/blink/web_tests/external/wpt/web-locks/query-ordering.tentative.https.html
[modify] https://crrev.com/33a49f0de5ba88ea1c68f73918772a5f3b7e703c/third_party/blink/web_tests/external/wpt/web-locks/resources/helpers.js
[modify] https://crrev.com/33a49f0de5ba88ea1c68f73918772a5f3b7e703c/third_party/blink/web_tests/external/wpt/web-locks/resources/iframe.html

Sign in to add a comment