New issue
Advanced search Search tips

Issue 913010 link

Starred by 1 user
Status: Assigned
Owner:
andrewxu@chromium.org
Cc:
sky@chromium.org
fdoray@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Use "const aura::Window*" in arguments where possbile.

Project Member Reported by osh...@chromium.org, Dec 7 
Get methods like in ActivationClient, Screen can be const,
and making it so can reduce const_cast when accessing them from
const method.

Andrew, can you work on this?
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/048f24b90aaaf28c111c5012a46702f5b6d2d339

commit 048f24b90aaaf28c111c5012a46702f5b6d2d339
Author: Andrew Xu <andrewxu@chromium.org>
Date: Wed Jan 16 21:21:23 2019

Add const qualifier to function parameter

Two main modifications:
(1) In current code, functions like FocusRules::IsToplevelWindow
accept non-const pointer as parameter. In CL, use const pointer
instead.
(2) In current code, functions like FocusRules::GetToplevelWindow
only accept non-const parameter. In CL, add functions overloading
with const parameter.

Bug: 913010
Change-Id: I8d3afc645c060844524bf148f2dadc112c6a0f40
Reviewed-on: https://chromium-review.googlesource.com/c/1372635
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623371}
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/shell_delegate.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/shell_delegate_mash.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/shell_delegate_mash.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/test_shell_delegate.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/test_shell_delegate.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/wm/ash_focus_rules.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/wm/focus_rules.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ash/wm/focus_rules.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client_impl.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client_impl.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client_impl_unittest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client_stub.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/multi_user_window_manager_client_stub.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/test_multi_user_window_manager_client.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/multi_user/test_multi_user_window_manager_client.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/session_util.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chrome/browser/ui/ash/session_util.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chromecast/graphics/cast_focus_client_aura.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/chromecast/graphics/cast_focus_client_aura.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/extensions/shell/browser/shell_desktop_controller_aura.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/services/ws/window_service_test_setup.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/aura/mus/focus_synchronizer_unittest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/views/widget/desktop_aura/desktop_focus_rules.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/views/widget/desktop_aura/desktop_focus_rules.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/views/widget/native_widget_aura_unittest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/views/widget/widget_unittest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/base_focus_rules.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/base_focus_rules.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/default_activation_client.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/default_activation_client.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/focus_controller.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/focus_controller.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/focus_controller_unittest.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/focus_rules.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/window_modality_controller.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/window_modality_controller.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/window_util.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/core/window_util.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/public/activation_client.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/public/activation_delegate.cc
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/ui/wm/public/activation_delegate.h
[modify] https://crrev.com/048f24b90aaaf28c111c5012a46702f5b6d2d339/webrunner/browser/frame_impl.cc
►

Sign in to add a comment