ScreenTimeControllerTest.LockOverride crashes sometimes |
||
Issue descriptionScreenTimeControllerTest.LockOverride is flaky on the bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=screentimecontrollertest Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9398 See output log attached. Excerpt: [10013:10013:1206/130346.001462:INFO:remote_commands_service.cc(165)] Remote commands fetched. [10013:10013:1206/130346.194575:WARNING:supervised_user_service.cc(663)] Blacklist download failed [10013:10013:1206/130346.215639:WARNING:family_info_fetcher.cc(258)] HTTP error -1 [10013:10013:1206/130346.215684:WARNING:child_account_service.cc(311)] GetFamilyMembers failed with code 1 [10013:10317:1206/130346.293089:WARNING:fake_gaia.cc(289)] Serving request /oauth2/v1/userinfo 127.0.0.1 - - [06/Dec/2018 13:03:46] "GET /oauth2/v1/userinfo HTTP/1.1" 200 - 127.0.0.1 - - [06/Dec/2018 13:03:46] "POST /device_management?request=policy&devicetype=2&apptype=Chrome&agent=Chromium+73.0.3633.0(f936709b51647364772c31b27f702280209a2d3d-refs%2Fheads%2Fmaster%40%7B%23614475%7D)&platform=Linux%2CCrOS%2Cunknown%7Cx86_64%2Cunknown%7C14.4.0&deviceid=4531ecf3-5126-459b-93f7-d5a303ab656a&retry=false HTTP/1.1" 200 - [10013:11294:1206/130346.321463:WARNING:syncer_proto_util.cc(342)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: CONNECTION_UNAVAILABLE [10013:11294:1206/130346.321624:ERROR:get_updates_processor.cc(244)] PostClientToServerMessage() failed during GetUpdates [10013:10234:1206/130346.350446:ERROR:checkin_request.cc(219)] Failed to get checkin response. Fetcher failed. Retrying. [10013:10317:1206/130346.541269:WARNING:fake_gaia.cc(289)] Serving request /oauth2/v1/userinfo 127.0.0.1 - - [06/Dec/2018 13:03:46] "GET /oauth2/v1/userinfo HTTP/1.1" 200 - [10013:10013:1206/130346.852968:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData. [10013:10013:1206/130346.853857:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator. [10013:10013:1206/130346.879337:INFO:status_uploader.cc(219)] Starting status upload: have_device_status = 1 127.0.0.1 - - [06/Dec/2018 13:03:46] "POST /device_management?request=status_upload&devicetype=2&apptype=Chrome&agent=Chromium+73.0.3633.0(f936709b51647364772c31b27f702280209a2d3d-refs%2Fheads%2Fmaster%40%7B%23614475%7D)&platform=Linux%2CCrOS%2Cunknown%7Cx86_64%2Cunknown%7C14.4.0&deviceid=4531ecf3-5126-459b-93f7-d5a303ab656a&retry=false HTTP/1.1" 200 - [10013:10013:1206/130346.943103:INFO:status_uploader.cc(232)] Status upload successful [10013:10013:1206/130347.055779:ERROR:textfield.cc(1777)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [10013:10013:1206/130347.464428:FATAL:web_contents_observer_sanity_checker.cc(312)] Check failed: is_loading_. #0 0x7fbb06ea451d base::debug::StackTrace::StackTrace() #1 0x7fbb06b9d13a base::debug::StackTrace::StackTrace() #2 0x7fbb06c093ee logging::LogMessage::~LogMessage() #3 0x562691c274d0 content::WebContentsObserverSanityChecker::DidStopLoading() #4 0x7fbafd0f8c20 content::WebContentsImpl::LoadingStateChanged() #5 0x7fbafd10a2a4 content::WebContentsImpl::DidStopLoading() #6 0x7fbafc5a87ee content::FrameTreeNode::DidStopLoading() #7 0x7fbafc5a8342 content::FrameTreeNode::~FrameTreeNode() #8 0x7fbafc689aed std::__1::__vector_base<>::~__vector_base() #9 0x7fbafc63623d content::RenderFrameHostImpl::ResetChildren() #10 0x7fbafc63c7e2 content::RenderFrameHostImpl::OnRenderProcessGone() #11 0x7fbafc697264 _ZN4base20DispatchToMethodImplIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt3__15tupleIJS5_S6_EEEJLm0ELm1EEEEvRKT_T0_OT1_NS9_16integer_sequenceImJXspT2_EEEE #12 0x7fbafc697198 _ZN4base16DispatchToMethodIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt3__15tupleIJS5_S6_EEEEEvRKT_T0_OT1_ #13 0x7fbafc697124 _ZN3IPC16DispatchToMethodIN7content19RenderFrameHostImplEMS2_FviiEvNSt3__15tupleIJiiEEEEEvPT_T0_PT1_OT2_ #14 0x7fbafc6694a8 _ZN3IPC8MessageTI35FrameHostMsg_RenderProcessGone_MetaNSt3__15tupleIJiiEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FviiEEEbPKNS_7MessageEPT_PT0_PT1_T2_ #15 0x7fbafc63b0dd content::RenderFrameHostImpl::OnMessageReceived() #16 0x7fbafcced19f content::RenderProcessHostImpl::ProcessDied() #17 0x7fbafcceca28 content::RenderProcessHostImpl::FastShutdownIfPossible() #18 0x5626909ca114 browser_shutdown::OnShutdownStarting() #19 0x5626909c9804 chrome::ExitCleanly()
,
Jan 4
Michael, is crbug/466089 really the root cause for the flakiness here? I am trying to write more integration tests to cover Time Limits, but this problem is blocking the work. Is there something we can do?
,
Jan 5
Possibly. It doesn't seem directly related to the test or OOBE, so I'm not sure what we can do. Realistically I won't be able to look into this for another couple weeks -- feel free to investigate further if you can, otherwise we could redirect to the Code Mauve team, since signing into chrome and locking the screen shouldn't be so hard from a test.
,
Jan 7
I think we should reassign the bug, then. Do you know someone on the mentioned team that we could reassign this bug to?
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51bdda57a8d838112c315e6b95e45b979f41fd6e commit 51bdda57a8d838112c315e6b95e45b979f41fd6e Author: James Cook <jamescook@chromium.org> Date: Fri Jan 11 18:33:58 2019 Remove CHECK in WebContentsObserverSanityChecker::DidStopLoading The check causes low-level browser_test flake across a wide variety of test suites, usually due to check failures during test suite teardown. This is test-only code, so relax the check until the root cause can be investigated further. Bug: 466089, 871010, 913006, 915360, 919347 Test: browser_tests Change-Id: Ife2ab6a6d260471f79873b6f0fd2914a4c7bb71d Reviewed-on: https://chromium-review.googlesource.com/c/1403353 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#622067} [modify] https://crrev.com/51bdda57a8d838112c315e6b95e45b979f41fd6e/content/test/web_contents_observer_sanity_checker.cc
,
Jan 14
After the CL above the test no longer crashes. It still flakily times out, though, and the timeout seems related to a crash in memory management in the test harness. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10255 https://chromium-swarm.appspot.com/task?id=4263a60ca2462910&refresh=10&show_raw=1&wide_logs=true [ RUN ] ScreenTimeControllerTest.LockOverride sending server_data: {"host": "127.0.0.1", "port": 44384} (36 bytes) HTTPS server started on 127.0.0.1:34307... sending server_data: {"host": "127.0.0.1", "port": 34307} (36 bytes) [1:1:0113/213955.440789:INFO:hugepage_text.cc(68)] Mlocking text pages failed: Cannot allocate memory (12) [32003:32003:0113/213956.633385:ERROR:child_process_security_policy_impl.cc(1277)] Ignoring port number in isolated origin: https://accounts.google.com:34307 [32003:32003:0113/213957.893694:WARNING:personal_data_manager.cc(492)] 0x1d71432d28e0 refresh is done, notifying PersonalDataChanged <...snip...> [32003:32003:0113/214035.363927:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [32003:32003:0113/214035.364180:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [ OK ] ScreenTimeControllerTest.LockOverride (43048 ms) [----------] 1 test from ScreenTimeControllerTest (43048 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (43050 ms total) [ PASSED ] 1 test. BrowserTestBase received signal: Terminated. Backtrace: #0 0x7fa20b70b6b9 base::debug::StackTrace::StackTrace() #1 0x7fa20b5101f5 base::debug::StackTrace::StackTrace() #2 0x55775f843c0d content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7fa1dde46cb0 <unknown> #4 0x7fa20b7758ca PackedCache<>::GetOrDefault() #5 0x7fa20b7757e0 tcmalloc::PageHeap::GetSizeClassIfCached() #6 0x7fa20b7727f6 (anonymous namespace)::do_free_with_callback() #7 0x7fa20b770aac (anonymous namespace)::do_free() #8 0x7fa20b77439b MallocBlock::ProcessFreeQueue() #9 0x7fa20b777b94 MallocBlock::Deallocate() #10 0x7fa20b770f75 DebugDeallocate() #11 0x7fa20b79d673 tc_free #12 0x7fa20b73611d (anonymous namespace)::TCFree() #13 0x7fa20b735ba3 ShimCppDelete #14 0x7fa20b7353d5 operator delete() #15 0x55775c3a91a0 testing::internal::Delete<>() #16 0x55775c3bdc08 std::__Cr::for_each<>() #17 0x55775c3b52eb testing::internal::ForEach<>() #18 0x55775c3a9118 testing::TestCase::~TestCase() #19 0x55775c3a91c9 testing::TestCase::~TestCase() #20 0x55775c3b13cb testing::internal::Delete<>() #21 0x55775c3ba2f8 std::__Cr::for_each<>() #22 0x55775c3b63fb testing::internal::ForEach<>() #23 0x55775c3b125a testing::internal::UnitTestImpl::~UnitTestImpl() #24 0x55775c3b1439 testing::internal::UnitTestImpl::~UnitTestImpl() #25 0x55775c3b0f01 testing::UnitTest::~UnitTest() #26 0x7fa1dde4c1a9 <unknown> #27 0x7fa1dde4c1f5 exit #28 0x7fa1dde31f4c __libc_start_main #29 0x557759c8041a _start [276/546] ScreenTimeControllerTest.LockOverride (TIMED OUT) |
||
►
Sign in to add a comment |
||
Comment 1 by steve...@chromium.org
, Dec 17