New issue
Advanced search Search tips

Issue 912949 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DL: Figure out which parts of style code should be locked

Project Member Reported by vmp...@chromium.org, Dec 7

Issue description

Context:
https://chromium-review.googlesource.com/c/chromium/src/+/1363957/1/third_party/blink/renderer/core/display_lock/display_lock_context.cc#473

We're currently blocking style recalc from happening, but we're not blocking a number of other things such as style invalidation. Should we? Is it expensive?

It is probably worth investigating this. The risk is that blocking more of the stages while locked might introduce some bugs if some other part of the code relies on clean style invalidation bits and is not aware of display locking.


 
It's less expensive than style recalc. You can take a look at the UMA stats for Style.RecalcTime vs Style.InvalidationTime.

Sign in to add a comment