New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912944 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

A11y: NVDA loses focus after exiting context menu

Project Member Reported by dsexton@chromium.org, Dec 7

Issue description

Good: 71.0.3578.80 
Bad: 72.0.3626.0 

Steps to repro: 
# Launch NVDA, visit google.com 
# Navigate to the privacy link 
# Press applications key or shift+f10 to activate the context menu 
# Press escape to close the menu 
# Use up and down arrows to verify that web content is still focused 

Good version: content is focused 

Bad version: arrow keys and quick nav commands like 'h' or 'b' speak nothing, only tab restores focus to web content 
 
Cc: -aboxhall@chromium.org -lpalmaro@chromium.org -dmazz...@chromium.org
Owner: nek...@chromium.org
Status: Assigned (was: Available)
You are probably looking for a change made after 604492 (known good), but no later than 604493 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/9e0a8546530056033efadf886448412739e14f46..e6e678e606320dab796d260b926de8c96bb89633

Labels: -Needs-Bisect
Labels: ReleaseBlock-Beta M-72
Cc: srinivassista@chromium.org
Labels: RegressedIn-72 Target-72 FoundIn-72
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1846d7fdad4cb66f604d261006803208e76b26a

commit a1846d7fdad4cb66f604d261006803208e76b26a
Author: Nektarios Paisios <nektar@chromium.org>
Date: Fri Dec 07 22:55:11 2018

NVDA: Fixes bug whereby focus was not returning to the webview after dismissing a context menu

TBR=dmazzoni@chromium.org, aleventhal@chromium.org
CC=dsexton@google.com

Change-Id: Ib9728eda30599e51b3b494f7781a2240ccdbd023
Bug:  912944 
Reviewed-on: https://chromium-review.googlesource.com/c/1368666
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614855}
[modify] https://crrev.com/a1846d7fdad4cb66f604d261006803208e76b26a/ui/views/accessibility/view_accessibility.cc

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
Status: Started (was: Fixed)
Nektar@ - should we consider this merging for M72? (re-opening the bug for now until its merged or decided not to merge for 72)
Labels: -Merge-TBD Merge-Request-72
Labels: -Merge-Request-72 Merge-Approved-72
Thank you for the fix. Approving merge for M72, branch:3626
nektar@ can you please help merge this to M72 branch: 3626
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdae05ed63e643528331d3750a98050b347864b1

commit bdae05ed63e643528331d3750a98050b347864b1
Author: Nektarios Paisios <nektar@chromium.org>
Date: Wed Dec 12 20:55:00 2018

NVDA: Fixes bug whereby focus was not returning to the webview after dismissing a context menu

TBR=dmazzoni@chromium.org, aleventhal@chromium.org
CC=​dsexton@google.com

Change-Id: Ib9728eda30599e51b3b494f7781a2240ccdbd023
Bug:  912944 
Reviewed-on: https://chromium-review.googlesource.com/c/1368666
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614855}(cherry picked from commit a1846d7fdad4cb66f604d261006803208e76b26a)
Reviewed-on: https://chromium-review.googlesource.com/c/1374573
Cr-Commit-Position: refs/branch-heads/3626@{#305}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/bdae05ed63e643528331d3750a98050b347864b1/ui/views/accessibility/view_accessibility.cc

Status: Fixed (was: Started)
Labels: TE-Verified-M72 TE-Verified-72.0.3626.17
Able to reproduce this issue on Windows 10 on the bad build without fix 72.0.3626.0 and the issue is fixed on the latest M-72 build 72.0.3626.17.

1. Launched NVDA and opened google.com.
2. Navigated to the privacy link and hit shift+f10 to activate the context menu.
3. Press escape to close the menu.
4. Hit the up and down arrows keys and can observe that the content is focussed.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
912944-M72.mp4
2.2 MB View Download
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/bdae05ed63e643528331d3750a98050b347864b1

Commit: bdae05ed63e643528331d3750a98050b347864b1
Author: nektar@chromium.org
Commiter: nektar@chromium.org
Date: 2018-12-12 20:55:00 +0000 UTC

NVDA: Fixes bug whereby focus was not returning to the webview after dismissing a context menu

TBR=dmazzoni@chromium.org, aleventhal@chromium.org
CC=​dsexton@google.com

Change-Id: Ib9728eda30599e51b3b494f7781a2240ccdbd023
Bug:  912944 
Reviewed-on: https://chromium-review.googlesource.com/c/1368666
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614855}(cherry picked from commit a1846d7fdad4cb66f604d261006803208e76b26a)
Reviewed-on: https://chromium-review.googlesource.com/c/1374573
Cr-Commit-Position: refs/branch-heads/3626@{#305}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment