New issue
Advanced search Search tips

Issue 912911 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Passwords do not get encrypted after deleting entry from chrome://settings/passwords.

Project Member Reported by vineet...@virtusa.com, Dec 7

Issue description

Chrome version : 73.0.3633.0 (Official Build) Revision c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1}(32/64-Bit) 	
OS: Windows(7,8,8.1,10) ,Mac(10.13.1,10.13.6,10.14.2) and Linux(14.04  LTS)OS

Pre-condition: Atleast 2-3 passwords entries should be present under chrome://settings/passwords

What steps will reproduce the problem?
1.Launch chrome and navigate to 'chrome://settings/passwords'.
2.Click on eye icon of all entries so that all passwords are visible.
3.Now remove second/third password entry and observe.

Actual  : Other passwords do not get encrypted  after deleting 2/3 password entry from chrome://settings/passwords.
Expected: All password entries should be seen encrypted after deleting 2/3 password entry from chrome://settings/passwords.

This is a regression issue broken in ‘M-68’ and below is bisect info.
Good build: 68.0.3425.0
Bad build : 68.0.3427.0

Chromium Bisect:

https://chromium.googlesource.com/chromium/src/+log/56205ade5fedcee73206c6f7ebc9d1cb33763cd6..894c79630192ac3b94dccebb5dfab3a473385aa5	

Suspecting : https://chromium.googlesource.com/chromium/src/+/79911889545c81db13572295c2dff37120c7da1d

@aee: Could you please check whether this is caused with respect to your change, if not please help to reassigning it to the right owner.

Thank You!
 
ActualVideo.mp4
528 KB View Download
ExpectedVideo.mp4
446 KB View Download
Cc: jdoerrie@chromium.org
I'd argue this is a feature, not a big. Prior to aee@'s change we would refresh the whole list of passwords after there was a modification to a single entry. This is wasteful and exactly what aee@'s change intended to fix. As a result of this only the deleted row gets removed, and previously decrypted passwords stay unchanged. This is better for rendering performance and should be the expected behavior for users. I would be surprised if deleting the last password in a list of many passwords would hide all other passwords for no apparent reason. Thus I'm inclined to mark this as WontFix, but I'm leaving it up to aee@ to make the final call here.
Status: WontFix (was: Assigned)
It seems reasonable that deleting an entry only removes that entry from the list.

Sign in to add a comment