New issue
Advanced search Search tips

Issue 912907 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue v8:8525
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Intl.NumberFormat is not correctly localising numbers

Reported by daniel.l...@gmail.com, Dec 7

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36

Steps to reproduce the problem:
1. In chrome console
new Intl.NumberFormat('en-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.NumberFormat('en-u-nu-arab').resolvedOptions().numberingSystem === "latn" // not correct, should be "arab"

new Intl.NumberFormat('ar-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.NumberFormat('ar-u-nu-arab').resolvedOptions().numberingSystem === "latn" // not correct, should be "arab"

2. In chrome console
new Intl.DateTimeFormat('ar-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.DateTimeFormat('ar-u-nu-arab').resolvedOptions().numberingSystem === "arab" // correct
new Intl.DateTimeFormat('en-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.DateTimeFormat('en-u-nu-arab').resolvedOptions().numberingSystem === "arab" // correct
3. 

What is the expected behavior?

new Intl.NumberFormat('en-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.NumberFormat('en-u-nu-arab').resolvedOptions().numberingSystem === "arab" // not correct, should be "arab" but currently is "latn"
new Intl.NumberFormat('ar-u-nu-latn').resolvedOptions().numberingSystem === "latn" // correct
new Intl.NumberFormat('ar-u-nu-arab').resolvedOptions().numberingSystem === "arab" // not correct, should be "arab" but currently is "arab"

What went wrong?

en language with u-nu override is always being localised to latn numberingSystem, ar language with u-nu override is always being localised to latn numberingSystem

Did this work before? Yes 70

Does this work in other browsers? Yes

Chrome version: 71.0.3578.80  Channel: stable
OS Version: OS X 10.14.1
Flash Version:
 
Should be the same as Intl.DateTimeFormat
new Intl.DateTimeFormat('en-u-nu-arab').resolvedOptions().numberingSystem === new Intl.NumberFormat('en-u-nu-arab').resolvedOptions().numberingSystem
Broken in 9c7ec98a906e5bfe259c4d913c9115f0b52e90d2 landed in 71.0.3544.0 via r588834.
Fixed in  bug v8:8525  landed in Chrome 73.0.3633.0 via r614480.
Hopefully the fix will be merged into 72 at least.
Labels: Needs-Triage-M71
Cc: pbomm...@chromium.org hablich@chromium.org
Cc: adamk@chromium.org
Cc: gsat...@chromium.org js...@chromium.org
Components: -Blink>JavaScript Blink>JavaScript>Internationalization
Labels: Merge-Request-72 OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Windows
Owner: ftang@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks to woxxom for the quick diagnosis! Assigning to ftang as this was his fix.

The fix looks pretty safe, so I think we should consider trying to merge to M71. But for sure we should merge to M72, so requesting a merge now.
Mergedinto: v8:8525
Status: Duplicate (was: Assigned)
Marking as a duplicate to make it clear that this is already fixed on master.
Project Member

Comment 8 by sheriffbot@chromium.org, Dec 8

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge you change to M72 branch 3626 ASAP so we can pick it up for next  Dev/Beta release, RC cut on Monday, 12/10 @ 1:00 PM PT. Thank you.
Labels: -Merge-Approved-72 Merge-merged-72
Merged as e7ceacc254393d9064eac0635425ce208d0e388d

Sign in to add a comment