New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912896 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit 25 days ago
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::IsOffscreen

Project Member Reported by ClusterFuzz, Dec 7

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5693054234918912

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::IsOffscreen
  blink::SearchOrigin
  blink::FocusController::AdvanceFocusDirectionally
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=614339:614342

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693054234918912

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 7

Components: Blink
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 7

Labels: Test-Predator-Auto-Owner
Owner: junho092...@lge.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/0d17b741996e047d7aaf439dcb22ef7359e8f52b (Snav: Search inside focused scroll containers).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: f...@opera.com hu...@vewd.com
I'll see this issue at tomorrow and write about what exactly problem is.
Components: -Blink Blink>Scroll
Components: -Blink>Scroll Blink>HTML>Focus
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd778eef72431691c70768a895852e99d887085c

commit bd778eef72431691c70768a895852e99d887085c
Author: JunHo Seo <junho0924.seo@lge.com>
Date: Thu Dec 13 09:57:30 2018

Snav: Check null pointer in IsOffscreen()

document->body() can be null. So we should do null checking
before use it.

Bug:  912896 

Change-Id: I84d6abe30b500cfe00de58d9ee1c23d9cdedadbc
Reviewed-on: https://chromium-review.googlesource.com/c/1373730
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#616256}
[modify] https://crrev.com/bd778eef72431691c70768a895852e99d887085c/third_party/blink/renderer/core/page/spatial_navigation.cc
[add] https://crrev.com/bd778eef72431691c70768a895852e99d887085c/third_party/blink/web_tests/fast/spatial-navigation/snav-blank-page-crash.html

Project Member

Comment 7 by ClusterFuzz, Dec 13

ClusterFuzz has detected this issue as fixed in range 616255:616256.

Detailed report: https://clusterfuzz.com/testcase?key=5693054234918912

Fuzzer: inferno_layout_test_fuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::IsOffscreen
  blink::SearchOrigin
  blink::FocusController::AdvanceFocusDirectionally
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=614339:614342
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=616255:616256

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5693054234918912

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 13

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5693054234918912 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment