New issue
Advanced search Search tips

Issue 912893 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Margins drop-down list doesn't change to Default on print preview page.

Project Member Reported by cdin...@virtusa.com, Dec 7

Issue description

Chrome Version: 73.0.3633.0 (Official Build) Revision	c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1} (32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) &  Linux (14.04 LTS).

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage.
2. Click on More settings button and change Margin to None/minimum.
3. Now change the layout to Landscape and observe.

Actual: Margins drop-down list doesn't change to Default.
Expected: Margin drop-down list should get changed to Default.

This is a regression issue, broken in M-71 series, below is manual regression range:

Good build: 71.0.3551.0 (Revision: 590851)
Bad build: 71.0.3552.2 (Revision: 591210)

Using the 'per-revision' script providing the bisect result:

You are probably looking for a change made after 590894 (known good), but no later than 590895 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/a94cba5aa50629e27fecbb8a52a30e7893e8a66d..f610e16ed42a53337df296d451e00cba8a4dd424

Suspecting: https://chromium.googlesource.com/chromium/src/+/f610e16ed42a53337df296d451e00cba8a4dd424

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: 
1. Margin drop-down list is changed to default for Custom option after changing the Layout from Portrait to Landscape.
2. This issue is also seen on Stable #71.0.3578.80, Beta #71.0.3578.80 & Dev #72.0.3626.7

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
1.0 MB View Download
Expected behavior.mp4
1.1 MB View Download
Cc: thestig@chromium.org
+thestig@, WDYT? I am inclined to leave this as is. With custom margins, we have to reset the user's preference, since the custom margin values can be set to a value that isn't compatible with the new page orientation. Both minimum and zero margins, however, work with any orientation/page size (with minimum margins we pull a new value from the print driver based on the page size), so I don't see a compelling reason to override the user's choice of margins when they change the page layout or paper size.
Cc: namratakannan@chromium.org
+namratakannan for another opinion. I'm ok with the current behavior, but I don't have a strong feeling towards this.
Labels: -Pri-1 Pri-3
Current behavior is fine. And to clarify this means, except for with custom margins, when we change the orientation of the page, we retain previous user selection
Status: WontFix (was: Assigned)
Closing as WontFix per comment 4.

Sign in to add a comment