New issue
Advanced search Search tips

Issue 912885 link

Starred by 1 user
Status: Assigned
Owner:
aboxhall@chromium.org
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Grey focus highlight is not seen on 'X' close button on pressing 'Tab' key in devtools.

Reported by rp...@virtusa.com, Dec 7 
Chrome Version: 73.0.3633.0 (Official Build) Revision c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.6,10.13.1,10.14.2).

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open DevTools
2. Click on '+' icon of 'Insert style rule below' and click on 'Add background color' to open Color Picker window
2. Now click on second bidirectional arrow to open 'Color Palettes'.
3. Now click on 'Color Palettes' text and press 'Tab' key,observe focus

Actual : Grey focus highlight is not seen on 'X' close button on pressing 'Tab' key
Expected : Grey focus highlight should be seen on 'X' close button on pressing 'Tab' key

This is a regression issue, broken in M-65 series, below is the bisect info :
Good build: 65.0.3284.0 (Revision: 521228)
Bad build: 65.0.3285.0 (Revision: 521571)

You are probably looking for a change made after 521548 (known good), but no later than 521549 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/65b472737b0c1100ee672b9b89c3d2439defb654..09f677bd1562c40825b936f2af6c4d2232a3d585

Suspect: https://chromium.googlesource.com/chromium/src/+/09f677bd1562c40825b936f2af6c4d2232a3d585

@aboxhall: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : This issue is also reproducible on M-71 stable (build # 71.0.3578.80), M-71 Beta (build # 71.0.3578.80) and M-72 Dev (build # 72.0.3626.7)

Kindly review the attached screen-cast for reference.

Thank you.
Actual_video.mov
4.9 MB View Download
Expected_video.mov
5.6 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4662386de95b73facb56a3399183913bc2ea84c9

commit 4662386de95b73facb56a3399183913bc2ea84c9
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Fri Jan 11 01:29:58 2019

[Devtools] Focus color picker palette panel when shown.

Bug: 912885

Change-Id: If5541f63de6c9868ebe05c925c6a1e22d0bf1d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1404221
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621847}
[modify] https://crrev.com/4662386de95b73facb56a3399183913bc2ea84c9/third_party/blink/renderer/devtools/front_end/color_picker/Spectrum.js

Comment 2 by sav...@virtusa.com, Jan 11

Labels: TE-Verified-M73 TE-Verified-73.0.3668.0
Update :
---------
Verified above issue in latest Canary build #73.0.3668.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Hence adding TE-Verified labels, kindly review an attached screen-cast for reference.

Thank you..!
Canary_behavior.mov
11.9 MB View Download
►

Sign in to add a comment