Regression : Volume slider animates (even though focus is on it) while switching between the tabs. |
|||||||||
Issue descriptionChrome Version : 73.0.3633.0 (Official Build) c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1} 32/64 bit OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10), Linux(14.04 LTS) Test URL : https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html What steps will reproduce the problem? 1. Launch chrome, open two tabs and navigate to above test URL in second tab. 2. Click on 'Play' icon in video and hit 'TAB' key to bring focus on volume slider. 3. Now, switch to first tab and again come back to the second tab. 4. Observe the volume slider. Actual Result : Volume slider animates (even though focus is on it) while switching between the tabs. Expected Result : Volume slider should not animate (when focus is present on it) while switching between the tabs. This is a regression issue broken in M-72 and below is the bisect information: Good Build : 72.0.3609.3 (Revision : 607407) Bad Build : 72.0.3610.0 (Revision : 607838) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/85ddfa5c4b5f83548d0740eb61d3a704b1819e75..de8970759a44d64902b6541ab797d2d4bdf78470 Suspecting: https://chromium.googlesource.com/chromium/src/+/305d97330c7ada96b1e679f79b453983626b9ee4 @jazzhsu: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. Able to reproduce issue in Dev build #72.0.3626.7 2. Issue can be reproduced on following URLs as well - - http://googlechrome.github.io/samples/picture-in-picture - https://www.quirksmode.org/html5/tests/video.html Thank you..!
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e2e5ee56896bc0b21c6780746000663db6e53ac commit 4e2e5ee56896bc0b21c6780746000663db6e53ac Author: Jazz Xu <jazzhsu@chromium.org> Date: Sat Dec 08 01:31:38 2018 [Media Controls] Fix a bug where the volume slider re-animate when switching tabs while focued Fix the problem by opening volume slider immediately when focused with keyboard. Also add a logic that when volume slider is focused, unhover the volume slider won't close it. Bug: 912881 Change-Id: I292be0ebcf84a8b2fb9f91cc4c6df2fb1a5db694 Reviewed-on: https://chromium-review.googlesource.com/c/1368048 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#614900} [modify] https://crrev.com/4e2e5ee56896bc0b21c6780746000663db6e53ac/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/4e2e5ee56896bc0b21c6780746000663db6e53ac/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
,
Dec 8
,
Dec 8
[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 10
jazzhsu@ - if this is fixed in canary, should we merge this to M72 branch?
,
Dec 10
,
Dec 10
Yes
,
Dec 11
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa82527c5a4385374207f2118562374f0ff73040 commit fa82527c5a4385374207f2118562374f0ff73040 Author: Jazz Xu <jazzhsu@chromium.org> Date: Wed Dec 12 22:34:50 2018 [Media Controls] Fix a bug where the volume slider re-animate when switching tabs while focued Fix the problem by opening volume slider immediately when focused with keyboard. Also add a logic that when volume slider is focused, unhover the volume slider won't close it. Bug: 912881 Change-Id: I292be0ebcf84a8b2fb9f91cc4c6df2fb1a5db694 Reviewed-on: https://chromium-review.googlesource.com/c/1368048 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614900}(cherry picked from commit 4e2e5ee56896bc0b21c6780746000663db6e53ac) Reviewed-on: https://chromium-review.googlesource.com/c/1374740 Cr-Commit-Position: refs/branch-heads/3626@{#311} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/fa82527c5a4385374207f2118562374f0ff73040/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc [modify] https://crrev.com/fa82527c5a4385374207f2118562374f0ff73040/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
,
Dec 13
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa82527c5a4385374207f2118562374f0ff73040 Commit: fa82527c5a4385374207f2118562374f0ff73040 Author: jazzhsu@chromium.org Commiter: steimel@chromium.org Date: 2018-12-12 22:34:50 +0000 UTC [Media Controls] Fix a bug where the volume slider re-animate when switching tabs while focued Fix the problem by opening volume slider immediately when focused with keyboard. Also add a logic that when volume slider is focused, unhover the volume slider won't close it. Bug: 912881 Change-Id: I292be0ebcf84a8b2fb9f91cc4c6df2fb1a5db694 Reviewed-on: https://chromium-review.googlesource.com/c/1368048 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614900}(cherry picked from commit 4e2e5ee56896bc0b21c6780746000663db6e53ac) Reviewed-on: https://chromium-review.googlesource.com/c/1374740 Cr-Commit-Position: refs/branch-heads/3626@{#311} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbasuvula@chromium.org
, Dec 7