New issue
Advanced search Search tips

Issue 912880 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scroll-bar is seen on 'Button Strip' under chrome://extensions on changing the font size.

Project Member Reported by sany...@virtusa.com, Dec 7

Issue description

Chrome Version: 73.0.3633.0 (Official Build) Revision c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10), Mac(10.13.6, 10.13.1, 10.14.2),Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to ‘chrome://settings/fonts’ and change the minimum font size to ‘Huge’.
2. Navigate to 'chrome://extensions/', toggle to Developer mode and observe.

Actual  : Unwanted scroll-bar is seen on 'Button Strip' on changing the font size.
Expected: No scroll-bar should be seen on 'Button Strip' on changing the font size.

This is a regression issue, broken in M-72 series, and below is the per-revision-bisect-info

Good Build : 72.0.3618.0 (Revision:610279)
Bad  Build : 72.0.3619.0 (Revision:610515)

You are probably looking for a change made after 610391 (known good), but no later than 610392 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/38d9b9c278f85d2f1d660086122069c7b875cfbc..3849df4eed565b2119a29bd9c761ae841aa26a52

Suspect: https://chromium.googlesource.com/chromium/src/+/3849df4eed565b2119a29bd9c761ae841aa26a52

@Esmael: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the screen-cast for reference

Thank You!
 
Actual_Result.mov
2.2 MB View Download
Expected_Result.mov
1.7 MB View Download
Labels: -Pri-1 Pri-3
Status: WontFix (was: Assigned)
The scroll bar is to allow for the buttons to be usable when the window is too narrow to display them all on one line. This can happen by either reducing the width of the browser window or increasing the font size. This looks like it is working about as intended.

I can remove the bottom padding from the button strip. At arial 36, the scroll bar will show up instead of arial 30. Very large is size 24. I'm going to mark this as won't fix. The UI works and does not show a scroll bar with the very large preset.

The reason why the scroll bar is seen at standard font size of 30 and minimum font size of 24 is because the button font size is relative to the standard font size and clamped by the minimum font size. And both settings independently would result in a button font size of 24.

Cc: aee@chromium.org
 Issue 913381  has been merged into this issue.

Sign in to add a comment