Guard card uploads in transport mode behind a finch flag. |
||||||
Issue descriptionWe should guard the card uploads in Transport mode by another Finch flag, so that we can launch Card sync in transport mode without offering to upload the user's cards. This will be useful if we decide that we want to iterate on the upload UI, but are happy with the downstream.
,
Dec 11
Requesting a merge for the CL in #1 to M72. This is a really simple change, which just adds a finch flag to guard some behavior. From that sense, it actually removes risk from M72 :)
,
Dec 12
I've also verified that the flag works as expected on canary. Thanks!
,
Dec 12
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26 commit 86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26 Author: Florian Uunk <feuunk@chromium.org> Date: Wed Dec 12 13:08:28 2018 Guard uploads for Account Wallet with Finch This allows us to launch Card sync in transport mode without offering to upload the user's cards. This will be useful if we decide that we want to iterate on the upload UI, but are happy with the downstream. BUG= 912879 Change-Id: I83a1d0a09ecc32123f1b3a75afcbd87250ac0f6b Reviewed-on: https://chromium-review.googlesource.com/c/1366288 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615095}(cherry picked from commit 05332268589cadd0ba784ec7d2676dfa786c7f90) Reviewed-on: https://chromium-review.googlesource.com/c/1373836 Reviewed-by: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#284} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26/components/autofill/core/browser/autofill_experiments_unittest.cc [modify] https://crrev.com/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26/components/autofill/core/common/autofill_features.cc [modify] https://crrev.com/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26/components/autofill/core/common/autofill_features.h
,
Dec 12
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26 Commit: 86d4c5c14a0a2a908a2b8bd5a6cd9d734db8bb26 Author: feuunk@chromium.org Commiter: feuunk@chromium.org Date: 2018-12-12 13:08:28 +0000 UTC Guard uploads for Account Wallet with Finch This allows us to launch Card sync in transport mode without offering to upload the user's cards. This will be useful if we decide that we want to iterate on the upload UI, but are happy with the downstream. BUG= 912879 Change-Id: I83a1d0a09ecc32123f1b3a75afcbd87250ac0f6b Reviewed-on: https://chromium-review.googlesource.com/c/1366288 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615095}(cherry picked from commit 05332268589cadd0ba784ec7d2676dfa786c7f90) Reviewed-on: https://chromium-review.googlesource.com/c/1373836 Reviewed-by: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#284} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 10