ToTAndroid x64 fails with assert / hangs |
||
Issue descriptionFrom https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTAndroid%20x64/1451 Running it locally, it looks more like it's in an infinite loop. I had it running for 5 minutes or so. Perhaps if I'd left it, it would hit the assert. FAILED: android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_GNU_SOURCE -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION_ROLL=r16_1 -DCR_CLANG_REVISION=\"348526\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -DCHROMIUM_CXX_TWEAK_INLINES -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBLINK_CORE_IMPLEMENTATION=1 -DWEBP_EXTERN=extern -DANGLE_ENABLE_RELEASE_ASSERTS -DUSE_EGL -DVK_NO_PROTOTYPES -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DPROTOBUF_USE_DLLS -DBORINGSSL_SHARED_LIBRARY -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DWEBRTC_ANDROID -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\" -DSK_VULKAN=1 -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSKCMS_API=__attribute__\(\(visibility\(\"default\"\)\)\) -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DVK_NO_PROTOTYPES -DUSING_V8_SHARED -DV8_DEPRECATION_WARNINGS -DWTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION=1 -DWTF_USE_WEBAUDIO_OPENMAX_DL_FFT=1 -DUSE_LIBJPEG_TURBO=1 -DUSING_V8_SHARED -DV8_DEPRECATION_WARNINGS -DLIBXSLT_STATIC -I../.. -Iandroid_clang_x86/gen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/vulkan/include -I../../third_party/openmax_dl -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -I../../third_party/protobuf/src -Iandroid_clang_x86/gen/protoc_out -I../../third_party/boringssl/src/include -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/vulkan/include -I../../third_party/skia/third_party/vulkanmemoryallocator -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/vulkan/include -I../../third_party/angle/include -I../../third_party/angle/src/common/third_party/base -Iandroid_clang_x86/gen/angle -I../../v8/include -Iandroid_clang_x86/gen/v8/include -I../../third_party/libjpeg_turbo -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/zlib -I../../third_party/ots/include -I../../v8/include -Iandroid_clang_x86/gen/v8/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libxslt/src -I../../third_party/snappy/src -I../../third_party/snappy/linux -fno-strict-aliasing --param=ssp-buffer-size=4 -fno-stack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -funwind-tables -fPIC -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -ffunction-sections -fno-short-enums --target=i686-linux-android -isystem../../third_party/android_ndk/sysroot/usr/include/i686-linux-android -D__ANDROID_API__=16 -DHAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -m32 -msse2 -mfpmath=sse -mmmx -momit-leaf-frame-pointer -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -Oz -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wglobal-constructors -g2 -DLIBXML_STATIC= -std=c++14 -fno-exceptions -fno-rtti --sysroot=../../third_party/android_ndk/sysroot -nostdinc++ -isystem../../third_party/android_ndk/sources/cxx-stl/llvm-libc++/include -isystem../../third_party/android_ndk/sources/cxx-stl/llvm-libc++abi/include -isystem../../third_party/android_ndk/sources/android/support/include -fvisibility-inlines-hidden -c ../../third_party/blink/renderer/core/style/computed_style.cc -o android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o clang++: /b/s/w/ir/cache/builder/src/third_party/llvm/include/llvm/ADT/SmallVector.h:68: void llvm::SmallVectorBase::set_size(size_t): Assertion `Size <= capacity()' failed. Stack dump: 0. Program arguments: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -cc1 -triple i686-unknown-linux-android -emit-obj -disable-free -main-file-name computed_style.cc -mrelocation-model pic -pic-level 2 -mthread-model posix -fmerge-all-constants -mdisable-fp-elim -relaxed-aliasing -mfpmath sse -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu i686 -target-feature +ssse3 -target-feature +sse2 -target-feature +mmx -dwarf-column-info -debug-info-kind=limited -dwarf-version=4 -debugger-tuning=gdb -momit-leaf-frame-pointer -ffunction-sections -fdata-sections -coverage-notes-file /b/s/w/ir/cache/builder/src/out/Release/android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.gcno -nostdinc++ -resource-dir ../../third_party/llvm-build/Release+Asserts/lib/clang/8.0.0 -dependency-file android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o.d -MT android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o -isystem ../../third_party/android_ndk/sysroot/usr/include/i686-linux-android -isystem ../../third_party/android_ndk/sources/cxx-stl/llvm-libc++/include -isystem ../../third_party/android_ndk/sources/cxx-stl/llvm-libc++abi/include -isystem ../../third_party/android_ndk/sources/android/support/include -D V8_DEPRECATION_WARNINGS -D DCHECK_ALWAYS_ON=1 -D NO_TCMALLOC -D SAFE_BROWSING_DB_REMOTE -D CHROMIUM_BUILD -D FIELDTRIAL_TESTING_ENABLED -D _GNU_SOURCE -D ANDROID -D HAVE_SYS_UIO_H -D ANDROID_NDK_VERSION_ROLL=r16_1 -D CR_CLANG_REVISION="348526" -D __STDC_CONSTANT_MACROS -D __STDC_FORMAT_MACROS -D _FORTIFY_SOURCE=2 -D COMPONENT_BUILD -D __GNU_SOURCE=1 -D CHROMIUM_CXX_TWEAK_INLINES -D NDEBUG -D NVALGRIND -D DYNAMIC_ANNOTATIONS_ENABLED=0 -D BLINK_CORE_IMPLEMENTATION=1 -D WEBP_EXTERN=extern -D ANGLE_ENABLE_RELEASE_ASSERTS -D USE_EGL -D VK_NO_PROTOTYPES -D BLINK_IMPLEMENTATION=1 -D INSIDE_BLINK -D U_USING_ICU_NAMESPACE=0 -D U_ENABLE_DYLOAD=0 -D USE_CHROMIUM_ICU=1 -D ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -D UCHAR_TYPE=uint16_t -D GOOGLE_PROTOBUF_NO_RTTI -D GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -D HAVE_PTHREAD -D PROTOBUF_USE_DLLS -D BORINGSSL_SHARED_LIBRARY -D WEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -D WEBRTC_CHROMIUM_BUILD -D WEBRTC_POSIX -D WEBRTC_LINUX -D WEBRTC_ANDROID -D ABSL_ALLOCATOR_NOTHROW=1 -D NO_MAIN_THREAD_WRAPPING -D SK_HAS_PNG_LIBRARY -D SK_HAS_WEBP_LIBRARY -D SK_HAS_JPEG_LIBRARY -D SK_VULKAN_HEADER="../../skia/config/SkVulkanConfig.h" -D SK_VULKAN=1 -D SKIA_DLL -D GR_GL_IGNORE_ES3_MSAA=0 -D SKCMS_API=__attribute__((visibility("default"))) -D SK_SUPPORT_GPU=1 -D SK_GPU_WORKAROUNDS_HEADER="gpu/config/gpu_driver_bug_workaround_autogen.h" -D SK_BUILD_FOR_ANDROID -D USE_CHROMIUM_SKIA -D VK_NO_PROTOTYPES -D USING_V8_SHARED -D V8_DEPRECATION_WARNINGS -D WTF_USE_LOW_QUALITY_IMAGE_INTERPOLATION=1 -D WTF_USE_WEBAUDIO_OPENMAX_DL_FFT=1 -D USE_LIBJPEG_TURBO=1 -D USING_V8_SHARED -D V8_DEPRECATION_WARNINGS -D LIBXSLT_STATIC -I ../.. -I android_clang_x86/gen -I ../../third_party/libyuv/include -I ../../third_party/libwebp/src -I ../../third_party/khronos -I ../../gpu -I ../../third_party/vulkan/include -I ../../third_party/openmax_dl -I ../../third_party/ced/src -I ../../third_party/icu/source/common -I ../../third_party/icu/source/i18n -I ../../third_party/protobuf/src -I ../../third_party/protobuf/src -I android_clang_x86/gen/protoc_out -I ../../third_party/boringssl/src/include -I ../../third_party/webrtc_overrides -I ../../third_party/webrtc -I ../../third_party/abseil-cpp -I ../../skia/config -I ../../skia/ext -I ../../third_party/skia/include/c -I ../../third_party/skia/include/config -I ../../third_party/skia/include/core -I ../../third_party/skia/include/docs -I ../../third_party/skia/include/effects -I ../../third_party/skia/include/encode -I ../../third_party/skia/include/gpu -I ../../third_party/skia/include/pathops -I ../../third_party/skia/include/ports -I ../../third_party/skia/include/utils -I ../../third_party/vulkan/include -I ../../third_party/skia/third_party/vulkanmemoryallocator -I ../../third_party/skia/include/codec -I ../../third_party/skia/src/gpu -I ../../third_party/skia/src/sksl -I ../../third_party/skia/modules/skottie/include -I ../../third_party/vulkan/include -I ../../third_party/angle/include -I ../../third_party/angle/src/common/third_party/base -I android_clang_x86/gen/angle -I ../../v8/include -I android_clang_x86/gen/v8/include -I ../../third_party/libjpeg_turbo -I ../../third_party/iccjpeg -I ../../third_party/libpng -I ../../third_party/zlib -I ../../third_party/ots/include -I ../../v8/include -I android_clang_x86/gen/v8/include -I ../../third_party/libxml/src/include -I ../../third_party/libxml/linux/include -I ../../third_party/libxslt/src -I ../../third_party/snappy/src -I ../../third_party/snappy/linux -D __DATE__= -D __TIME__= -D __TIMESTAMP__= -D __ANDROID_API__=16 -D HAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -D LIBXML_STATIC= -isysroot ../../third_party/android_ndk/sysroot -internal-isystem ../../third_party/android_ndk/sysroot/usr/local/include -internal-isystem ../../third_party/llvm-build/Release+Asserts/lib/clang/8.0.0/include -internal-externc-isystem ../../third_party/android_ndk/sysroot/usr/include/i686-linux-android -internal-externc-isystem ../../third_party/android_ndk/sysroot/include -internal-externc-isystem ../../third_party/android_ndk/sysroot/usr/include -Oz -Wno-builtin-macro-redefined -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wglobal-constructors -std=c++14 -fdeprecated-macro -fdebug-compilation-dir /b/s/w/ir/cache/builder/src/out/Release -ferror-limit 19 -fmessage-length 0 -fvisibility hidden -fvisibility-inlines-hidden -fno-rtti -fobjc-runtime=gcc -Qn -fdiagnostics-show-option -fcolor-diagnostics -vectorize-slp -mllvm -instcombine-lower-dbg-declare=0 -o android_clang_x86/obj/third_party/blink/renderer/core/style/rendering/computed_style.o -x c++ ../../third_party/blink/renderer/core/style/computed_style.cc -faddrsig 1. <eof> parser at end of file 2. Code generation 3. Running pass 'Function Pass Manager' on module '../../third_party/blink/renderer/core/style/computed_style.cc'. 4. Running pass 'X86 DAG->DAG Instruction Selection' on function '@_ZNK5blink13ComputedStyle33UpdatePropertySpecificDifferencesERKS0_RNS_15StyleDifferenceE' #0 0x00000000025b6bba llvm::sys::PrintStackTrace(llvm::raw_ostream&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x25b6bba) #1 0x00000000025b50d9 llvm::sys::RunSignalHandlers() (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x25b50d9) #2 0x00000000025b5215 SignalHandler(int) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x25b5215) #3 0x00007f39fcc01330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330) #4 0x00007f39fbc21c37 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x36c37) #5 0x00007f39fbc25028 abort (/lib/x86_64-linux-gnu/libc.so.6+0x3a028) #6 0x00007f39fbc1abf6 (/lib/x86_64-linux-gnu/libc.so.6+0x2fbf6) #7 0x00007f39fbc1aca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2) #8 0x0000000000a14790 llvm::SmallPtrSetImplBase::SmallPtrSetImplBase(void const**, unsigned int) (.part.133) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0xa14790) #9 0x0000000002d3412d (anonymous namespace)::DAGCombiner::AddToWorklist(llvm::SDNode*) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2d3412d) #10 0x0000000002d8ddda llvm::SelectionDAG::Combine(llvm::CombineLevel, llvm::AAResults*, llvm::CodeGenOpt::Level) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2d8ddda) #11 0x0000000002e64941 llvm::SelectionDAGISel::CodeGenAndEmitDAG() (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2e64941) #12 0x0000000002e6943a llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2e6943a) #13 0x0000000002e6b0d1 llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) (.part.1058) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2e6b0d1) #14 0x000000000188d500 (anonymous namespace)::X86DAGToDAGISel::runOnMachineFunction(llvm::MachineFunction&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x188d500) #15 0x0000000001d6c03e llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (.part.88) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x1d6c03e) #16 0x00000000020b95af llvm::FPPassManager::runOnFunction(llvm::Function&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x20b95af) #17 0x00000000020b97dc llvm::FPPassManager::runOnModule(llvm::Module&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x20b97dc) #18 0x00000000020b9ef3 llvm::legacy::PassManagerImpl::run(llvm::Module&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x20b9ef3) #19 0x000000000276735e (anonymous namespace)::EmitAssemblyHelper::EmitAssembly(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x276735e) #20 0x00000000027693fb clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::DataLayout const&, llvm::Module*, clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x27693fb) #21 0x0000000002f316eb clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2f316eb) #22 0x00000000036de94c clang::ParseAST(clang::Sema&, bool, bool) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x36de94c) #23 0x0000000002f30d0f clang::CodeGenAction::ExecuteAction() (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2f30d0f) #24 0x0000000002bb52f6 clang::FrontendAction::Execute() (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2bb52f6) #25 0x0000000002b882be clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2b882be) #26 0x0000000002c4f57a clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0x2c4f57a) #27 0x0000000000caff78 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (../../third_party/llvm-build/Release+Asserts/bin/clang+++0xcaff78) #28 0x0000000000c2b666 main (../../third_party/llvm-build/Release+Asserts/bin/clang+++0xc2b666) #29 0x00007f39fbc0cf45 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f45) #30 0x0000000000caa8d9 _start (../../third_party/llvm-build/Release+Asserts/bin/clang+++0xcaa8d9) clang++: error: unable to execute command: Aborted (core dumped) clang++: error: clang frontend command failed due to signal (use -v to see invocation) clang version 8.0.0 (trunk 348526) Target: i686-unknown-linux-android Thread model: posix InstalledDir: ../../third_party/llvm-build/Release+Asserts/bin clang++: note: diagnostic msg: PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script. clang++: note: diagnostic msg: ********************
,
Dec 7
Bisection points to this one: a4cdf653580dc0c23bd3e89909a91a9018827d6d is the first bad commit commit a4cdf653580dc0c23bd3e89909a91a9018827d6d Author: Sanjay Patel <spatel@rotateright.com> Date: Thu Nov 29 20:58:26 2018 +0000 [DAGCombiner] narrow truncated binops The motivating case for this is shown in: https://bugs.llvm.org/show_bug.cgi?id=32023 and the corresponding rot16.ll regression tests. Because x86 scalar shift amounts are i8 values, we can end up with trunc-binop-trunc sequences that don't get folded in IR. As the TODO comments suggest, there will be regressions if we extend this (for x86, we mostly seem to be missing LEA opportunities, but there are likely vector folds missing too). I think those should be considered existing bugs because this is the same transform that we do as an IR canonicalization in instcombine. We just need more tests to make those visible independent of this patch. Differential Revision: https://reviews.llvm.org/D54640
,
Dec 7
Attaching the repro.
,
Dec 7
Apparently that caused problems for others too, and there's an llvm-commits thread ongoing.
,
Dec 7
Hmm, but we had green builds after Nov 29... did something change in our code, or were there more upstream changes?
,
Dec 7
> Hmm, but we had green builds after Nov 29 Nope, I was looking at the wrong bot. ToTAndroid x64 has been failing consistently since the 29th.
,
Dec 7
Sounds like the new functionality was disabled in r348604
,
Dec 13
Sounds like this one is fixed for now. |
||
►
Sign in to add a comment |
||
Comment 1 by h...@chromium.org
, Dec 7