New issue
Advanced search Search tips

Issue 912874 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

PiP window shows frozen frame if video opened from background page on some platforms

Reported by m...@screencastify.com, Dec 7

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.80 Safari/537.36
Platform: 11151.51.0 (Official Build) beta-channel kevin

Steps to reproduce the problem:
On ChromeOS, Windows 10, (did not test Linux):

1. Load extension from attached file or https://github.com/Schibum/chrome-bug-pip-background
2. click extension icon

What is the expected behavior?
Picture in Picture plays back video consistently across all platforms.

Works fine on MacOS, tested on 71.0.3578.80 (Official Build) (64-bit) and 73.0.3633.0 

What went wrong?
PiP video does not play, but stays frozen at a single frame. By hitting play/pause, the video skips to another single frame.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 71.0.3578.80  Channel: beta
OS Version: 11151.51.0
Flash Version: 

Sounds similar to the issue that was fixed here:  https://crbug.com/893062 
 
chrome-bug-pip-background-master.zip
960 bytes Download
Example screencast recorded on kevin attached. On every mouse click (either on pausing or resuming), the video in the PiP window shows a new frame.
pip demo video.webm
293 KB View Download
Labels: Needs-Triage-M71
Cc: liber...@chromium.org mlamouri@chromium.org
Components: -Blink>Media Internals>Media>Video
Owner: lethalantidote@chromium.org
Status: Assigned (was: Unconfirmed)
Sounds like a video surface layer issue.
Cc: fbeaufort@chromium.org
+fbeaufort@ who looked into PIP for background pages. My memory is that it is expected to not work, right?
IIRC Picture-in-Picture was working for me when I've added support for it at https://chromium-review.googlesource.com/c/chromium/src/+/1145261/

I'm able to reproduce this issue with the extension provided by screencastify and with mine at https://chromium.googlesource.com/chromium/src/+/master/chrome/test/data/extensions/api_test/trigger_actions/browser_action_picture_in_picture

Note that it works fine for Chrome Apps pages.
Labels: -Pri-2 RegressedIn-71 M-72 Pri-1
Increasing priority as it seems to be a regression according to fbeaufort@. I wonder if that may be a similar root cause as the issue with re-attached tabs.
I've downloaded a older build of Chromium 70.0.3538.67 where extensions support was added and it looks like the issue was there already. Sorry for my misremembering.

Video in Picture-in-Picture window plays smoothly when video comes from a Chrome Apps page or a Chrome Extension page (popup, options, etc).
It only shows one frame when video is created from a background page (extension or chrome app).

And I have no clue why.
My guess would be that background pages don't have any UI layer associated (as you can see in devtools when inspecting background pages) and that may explain why.
Note that I've tried it in Chrome OS and Linux only. I didn't try in macOS.
For info, opening a tab that points to a background page such as "chrome-extension://hkgfoiooedgoejojocmhlaklaeopbecg/_generated_background_page.html" works. Video plays smoothly there.
Any progress on this?
No, not yet.
Investigating the reattaching tab issue to see if it will fix this one as well.
Does not seem like https://chromium-review.googlesource.com/c/chromium/src/+/1400943 fixed it. Looking into it more.
Cc: samans@chromium.org
+samans@

It looks like despite setting compositor_frame_sink_->SetNeedsBeginFrame(true), we aren't getting any BeginFrames. Do you know what would prevent a BeginFrame from being sent back in this situation? 

Sign in to add a comment