New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: [NTP] Thumbnails overlap with titles on zooming out the page to 50% and beyond.

Project Member Reported by sany...@virtusa.com, Dec 7

Issue description

Chrome Version: 73.0.3633.0 (Official Build) Revision	c972e8079a1fb95f6cb7c3afc162ea473384c3b1-refs/branch-heads/3633@{#1} (64-bit)
OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS)

Pre-Condition:
1.Enable 'Enable using the Google local NTP','New Tab Page Background Selection' and 'New Tab Page Custom Links' under chrome://flags 
2.Apply the theme: https://chrome.google.com/webstore/detail/turkey/dedlepgejadijllkcfbkoooojhdlifog?utm_source=chrome-ntp-icon
  
What steps will reproduce the problem?
1. Launch chrome, navigate to 'chrome://settings/fonts' and increase the minimum font size to huge.
2. Navigate to NTP, add few thumbnails and zoom out the page to 50% and beyond.
3. Observe that the thumbnails overlap.

Actual  : Thumbnails overlap with titles on zooming out the page to 50% and beyond.
Expected: Thumbnails should not overlap with titles on zooming out the page.

This is a regression issue, broken in M-73 series, and below is the per revision bisect info,
Good Build : 72.0.3626.0(Revision:612438)
Bad  Build : 73.0.3627.0(Revision:612851)

You are probably looking for a change made after 612688 (known good), but no later than 612689 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/ac0f3e4c889024247e08e21e6c2c6ec943ea2db9..75702140481df09e0e911c8e08e8d663ee3f8ed7

Suspect: https://chromium.googlesource.com/chromium/src/+/75702140481df09e0e911c8e08e8d663ee3f8ed7

@Tina: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the screen-cast for reference

Thank You!

 
Actual_Result.mov
5.1 MB View Download
Expected_Result.mov
4.5 MB View Download
Cc: kristip...@chromium.org
Labels: -Pri-1 KR-NTP-MD2-Polish O-Polish-Birthday-Features Pri-3
Status: Started (was: Assigned)
This is because the height of the title container haven't been set. 
Will try setting a max height to the title container.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754de5c68be65866470be5fa1771f45c04f1080f

commit 754de5c68be65866470be5fa1771f45c04f1080f
Author: Tina Wang <tinazwang@chromium.org>
Date: Tue Dec 11 02:26:07 2018

Fixed thumbnails overlapping when zoom out the page

Setting the max height of the title container, so the title container won't change size while zooming out.

Screenshots:
https://screenshot.googleplex.com/7EO54hxQi5N
https://screenshot.googleplex.com/kiDgYGzWrW9
https://screenshot.googleplex.com/uEgd1xRDOF4

Bug:  912861 
Change-Id: I4f49488965584b8bef0f0203b7e4291df967e706
Reviewed-on: https://chromium-review.googlesource.com/c/1368591
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615389}
[modify] https://crrev.com/754de5c68be65866470be5fa1771f45c04f1080f/chrome/browser/resources/local_ntp/most_visited_single.css

Labels: zine-triaged
Labels: TE-Verified-M73 TE-Verified-73.0.3638.0
Update : 
Retested above issue on  Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary #73.0.3638.0 and issue is fixed.
Now,Thumbnails are overlapping  with titles on zooming out the page.
Kindly review the attached screen-cast.
Thank you!
canary#73.0.3638.0.mov
29.9 MB Download
Status: Fixed (was: Started)

Sign in to add a comment