New issue
Advanced search Search tips

Issue 912847 link

Starred by 2 users
Status: Fixed
Owner:
grunell@chromium.org
Closed: Dec 7
Cc:
ossu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 776327



Sign in to add a comment

Feature flag for Mac system AEC

Project Member Reported by grunell@chromium.org, Dec 7 
The Mac system AEC is currently under experiment using an origin trial, issue 776327. Since that depends on the web app, it would help testing greatly to have a feature flag to force enable it.

Creating a separate issue for merge purpose.

Comment 1 by grunell@chromium.org, Dec 7

Labels: Merge-Request-72
Status: Fixed (was: Assigned)
This has been fixed, see https://bugs.chromium.org/p/chromium/issues/detail?id=776327#c15

Copying the bugdroid text from there:

-----
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63f2d772b2664b4572190bcd497280afdc6d559f

commit 63f2d772b2664b4572190bcd497280afdc6d559f
Author: Henrik Grunell <grunell@chromium.org>
Date: Thu Dec 06 17:25:20 2018

Feature to enable system AEC.

This lets users enable the system AEC for testing purposes.

If there is no system echo canceller available, getUserMedia with echo cancellation enabled will fail.

Bug: 776327
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie041bc1d205762875f9ad4817d8d3441d967256e
Reviewed-on: https://chromium-review.googlesource.com/c/1113440
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614397}
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/chrome/browser/about_flags.cc
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/chrome/browser/flag-metadata.json
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/media/audio/audio_features.cc
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/media/audio/audio_features.h
[modify] https://crrev.com/63f2d772b2664b4572190bcd497280afdc6d559f/tools/metrics/histograms/enums.xml
-----
Project Member

Comment 2 by sheriffbot@chromium.org, Dec 8

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by grunell@chromium.org, Dec 10

Labels: -Merge-Approved-72 merge-merged-3626
Merged. https://chromium.googlesource.com/chromium/src/+/29aa206f1f4c906f1a604f90a8c049aa5139828f

Comment 4 by grunell@chromium.org, Dec 10

Blocking: 776327
►

Sign in to add a comment