Issue metadata
Sign in to add a comment
|
Tab title contrast too low on Win 7 aero |
||||||||||||||||||||||||
Issue descriptionRun Win 7 aero, place a chrome window atop a white background (this matters since the frame and tabstrip are not fully opaque, so the background color affects contrast). Background tabs are now #777f88 atop #dbe2eb, for a contrast ratio of 3.1. This is well below the 4.5 WCAG minimum. Even in the best case (placing the Chrome window atop a black background), things are #4c5055 atop #b0b3b8, for a ratio of 3.86, which is still too low. We should probably (a) remove the translucency from background tabs in Refresh in win 7 and (b) double-check the resulting colors to see if they need further tweaking.
,
Dec 7
@1: That's a distinct issue from this bug about contrast; also, that setting only applies to UWP apps. Win32 titlebars like File Explorer are not affected (and I'm not aware of any way to ape this with the currently available APIs).
,
Dec 28
,
Jan 3
PK, are you thinking of taking this one on, or does it need to fall to my team? The status is 'started' but nobody is currently assigned.
,
Jan 4
Sorry, that was intended to show I'm WIP on this
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe4ba9355895efaa7dcf5d223490f37272589d7a commit fe4ba9355895efaa7dcf5d223490f37272589d7a Author: Peter Kasting <pkasting@chromium.org> Date: Mon Jan 07 20:21:05 2019 Remove transparency from inactive tabs on Win 7 Aero/CrOS. This wasn't accounted for during the Material Refresh design, and leaves tab text contrast (and thus readability) poor. It's not clear that it "looks better" aesthetically and it definitely causes usability problems, so remove it. This allows removing all the supporting machinery as well. Skia can be simplified too (but isn't here since it's upstream code). Bug: 912808 Change-Id: Iddd614602225cc905a33099e229eceb26d7b569b Reviewed-on: https://chromium-review.googlesource.com/c/1396855 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#620446} [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/paint_canvas.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/paint_op_buffer.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/paint_op_buffer.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/paint_op_buffer_unittest.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/paint_op_helper_unittest.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/record_paint_canvas.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/record_paint_canvas.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/skia_paint_canvas.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/paint/skia_paint_canvas.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/cc/test/paint_op_helper.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/third_party/blink/renderer/platform/graphics/test/mock_paint_canvas.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/ui/compositor/BUILD.gn [delete] https://crrev.com/e1fc0514c8a5d5f408e1ddb70e1b069cdbe84596/ui/compositor/compositing_recorder.cc [delete] https://crrev.com/e1fc0514c8a5d5f408e1ddb70e1b069cdbe84596/ui/compositor/compositing_recorder.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/ui/compositor/paint_context.h [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/ui/gfx/canvas.cc [modify] https://crrev.com/fe4ba9355895efaa7dcf5d223490f37272589d7a/ui/views/controls/button/label_button_border.cc
,
Jan 7
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by billdill...@gmail.com
, Dec 775.9 KB
75.9 KB View Download