New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912790 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Timeout in pdf_cjs_util_fuzzer

Project Member Reported by ClusterFuzz, Dec 7

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5740196852924416

Fuzzer: libFuzzer_pdf_cjs_util_fuzzer
Fuzz target binary: pdf_cjs_util_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cjs_util_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=606510:606541

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5740196852924416

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 7

Cc: thestig@chromium.org jam@chromium.org jochen@chromium.org caryclark@google.com tsepez@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Components: Internals>Plugins>PDF
Owner: thestig@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by ClusterFuzz, Dec 8

Labels: OS-Chrome
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/5d6714e3e3813c5c8f9e411e04427356ddf33b6e

commit 5d6714e3e3813c5c8f9e411e04427356ddf33b6e
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Dec 11 18:53:31 2018

Reduce reallocation in string classes.

Increase the size of the underlying storage geometrically when
concatenating to reduce the cost of reallocations. Use this along with
Reserve() to make CJS_Util::StringPrintx() faster.

BUG= chromium:912790 

Change-Id: I6d143ed02a035ea00a74b90b5c0793557a4d6528
Reviewed-on: https://pdfium-review.googlesource.com/c/46894
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/5d6714e3e3813c5c8f9e411e04427356ddf33b6e/core/fxcrt/widestring.cpp
[modify] https://crrev.com/5d6714e3e3813c5c8f9e411e04427356ddf33b6e/core/fxcrt/bytestring_unittest.cpp
[modify] https://crrev.com/5d6714e3e3813c5c8f9e411e04427356ddf33b6e/fxjs/cjs_util.cpp
[modify] https://crrev.com/5d6714e3e3813c5c8f9e411e04427356ddf33b6e/core/fxcrt/widestring_unittest.cpp
[modify] https://crrev.com/5d6714e3e3813c5c8f9e411e04427356ddf33b6e/core/fxcrt/bytestring.cpp

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efb7ccadfb94c2561a4bc086e4aeccfc602e4620

commit efb7ccadfb94c2561a4bc086e4aeccfc602e4620
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 11 22:46:08 2018

Roll src/third_party/pdfium 09163779000e..05e255178ba2 (4 commits)

https://pdfium.googlesource.com/pdfium.git/+log/09163779000e..05e255178ba2


git log 09163779000e..05e255178ba2 --date=short --no-merges --format='%ad %ae %s'
2018-12-11 tsepez@chromium.org Fix null deref in cxfa_itemlayoutprocessor.cpp
2018-12-11 tsepez@chromium.org Get Attribute names much more simply.
2018-12-11 thestig@chromium.org Reduce reallocation in string classes.
2018-12-11 tsepez@chromium.org Rename some structures in xfa_basic_data.cpp for consistency.


Created with:
  gclient setdep -r src/third_party/pdfium@05e255178ba2

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:913569, chromium:912790 
TBR=dsinclair@chromium.org

Change-Id: I4b5ba856864194d464857f9a31b1bcc843b4e6a2
Reviewed-on: https://chromium-review.googlesource.com/c/1372653
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615703}
[modify] https://crrev.com/efb7ccadfb94c2561a4bc086e4aeccfc602e4620/DEPS

Project Member

Comment 7 by ClusterFuzz, Dec 12

ClusterFuzz has detected this issue as fixed in range 615695:615710.

Detailed report: https://clusterfuzz.com/testcase?key=5740196852924416

Fuzzer: libFuzzer_pdf_cjs_util_fuzzer
Fuzz target binary: pdf_cjs_util_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Timeout (exceeds 25 secs)
Crash Address: 
Crash State:
  pdf_cjs_util_fuzzer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=606510:606541
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=615695:615710

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5740196852924416

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Dec 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5740196852924416 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment