[Merge request M72] Set migration flow step when user navigates away |
||||||
Issue descriptionRequesting for changes "set migration flow step when user navigates away" https://chromium-review.googlesource.com/c/chromium/src/+/1352358 The whole feature is guarded via finch flag and verified in latest canary.
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 8
Issue 913147 has been merged into this issue.
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbab2f88e7274fbfafd6201de646800b903e9e00 commit cbab2f88e7274fbfafd6201de646800b903e9e00 Author: siyua <siyua@chromium.org> Date: Sat Dec 08 02:53:21 2018 [AF Paradise] Set migration flow step when user navigates away Currently the credit card icon is visible when flow step is PROMO_BUBBLE or CREDIT_CARD_ICON. When user navigates away when bubble or credit card icon is shown, the flow step is not correctly set so the icon will always show even if the bubble is gone. Bug: 912779 Change-Id: I8a966cbb76775aaedc8b766306ec6d5c9602c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352358 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612928}(cherry picked from commit 1ff8939883e3389c8edf5e3c583aebd66e36eb20) Reviewed-on: https://chromium-review.googlesource.com/c/1368754 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#164} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h [add] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/autofill/local_card_migration_controller_observer.h [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/autofill/manage_migration_ui_controller.cc [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/autofill/manage_migration_ui_controller.h [modify] https://crrev.com/cbab2f88e7274fbfafd6201de646800b903e9e00/chrome/browser/ui/browser_commands.cc
,
Dec 8
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1368754; marking as Fixed.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cbab2f88e7274fbfafd6201de646800b903e9e00 Commit: cbab2f88e7274fbfafd6201de646800b903e9e00 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-12-08 02:53:21 +0000 UTC [AF Paradise] Set migration flow step when user navigates away Currently the credit card icon is visible when flow step is PROMO_BUBBLE or CREDIT_CARD_ICON. When user navigates away when bubble or credit card icon is shown, the flow step is not correctly set so the icon will always show even if the bubble is gone. Bug: 912779 Change-Id: I8a966cbb76775aaedc8b766306ec6d5c9602c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352358 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612928}(cherry picked from commit 1ff8939883e3389c8edf5e3c583aebd66e36eb20) Reviewed-on: https://chromium-review.googlesource.com/c/1368754 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#164} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jiahuiguo@chromium.org
, Dec 7