New issue
Advanced search Search tips

Issue 912773 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Dec 10
Cc:
weidongg@chromium.org
sammiequon@chromium.org
newcomer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Dragging windows to and from home launcher can still take events.

Project Member Reported by sammiequon@chromium.org, Dec 7 
What steps will reproduce the problem?
(1) Tablet. Open ntp.
(2) Drag up.
(3) Click on a thumbnail.

What is the expected result?
Nothing happens.

What happens instead?
Goes to the page
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1093670594edd12b73e9701c7dea0bf01af97c

commit 6d1093670594edd12b73e9701c7dea0bf01af97c
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Dec 07 20:27:19 2018

applist: Set windows being dragged to have null window targeter.

Originally just a 5 line change, not including tests. But saw a lot of
variables with __1_ and ___2_. So decided to also refactor a bit and
consolidate most of these into a class. So we only have window1_ and
window2_ now.

Test: ash_unittest *HomeLauncher*GestureHandler.*
Bug:  912773 
Change-Id: If11f35104dee91a23121f67f6ab3129c8900bcc8
Reviewed-on: https://chromium-review.googlesource.com/c/1366880
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614800}
[modify] https://crrev.com/6d1093670594edd12b73e9701c7dea0bf01af97c/ash/app_list/home_launcher_gesture_handler.cc
[modify] https://crrev.com/6d1093670594edd12b73e9701c7dea0bf01af97c/ash/app_list/home_launcher_gesture_handler.h
[modify] https://crrev.com/6d1093670594edd12b73e9701c7dea0bf01af97c/ash/app_list/home_launcher_gesture_handler_unittest.cc
[modify] https://crrev.com/6d1093670594edd12b73e9701c7dea0bf01af97c/ash/shelf/shelf_layout_manager_unittest.cc

Comment 2 by sammiequon@chromium.org, Dec 10

Status: Fixed (was: Assigned)

Comment 3 by sammiequon@chromium.org, Dec 10

Cc: sammiequon@chromium.org
 Issue 911738  has been merged into this issue.
►

Sign in to add a comment