New issue
Advanced search Search tips

Issue 912767 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 845252
issue 910743



Sign in to add a comment

Hook up VRTabHelper for desktop

Project Member Reported by billorr@chromium.org, Dec 6

Issue description

VrTabHelper is a helper object that attaches to a WebContents to notify parts of Chrome that we are presenting in a headset.

On android we are either in-headset or out of headset.  On desktop we can be both in-headset presenting and out-of-headset at the same time, so the api shape may need to be expanded a bit.
 
Owner: sumankancherla@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e45cb2a5fe8eaa4f534c86daa1d567acf99b9229

commit e45cb2a5fe8eaa4f534c86daa1d567acf99b9229
Author: Suman Kancherla <sumankancherla@chromium.org>
Date: Wed Dec 12 23:21:47 2018

[vr] Added additional state for in-headset display for windows

Bug:  912767 
Change-Id: I872e6809c4bf8af1d68f4e59cd43ff475958db2a
Reviewed-on: https://chromium-review.googlesource.com/c/1370906
Commit-Queue: Suman Kancherla <sumankancherla@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616099}
[modify] https://crrev.com/e45cb2a5fe8eaa4f534c86daa1d567acf99b9229/chrome/browser/vr/vr_tab_helper.cc
[modify] https://crrev.com/e45cb2a5fe8eaa4f534c86daa1d567acf99b9229/chrome/browser/vr/vr_tab_helper.h

Status: Fixed (was: Assigned)
Added VrTabHelper::IsContentDisplayedInHeadset and VrTabHelper::SetIsContentDisplayedInHeadset static helpers.

Sign in to add a comment