New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912743 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Multi-device directory structure cleanup

Project Member Reported by khorimoto@chromium.org, Dec 6

Issue description

Note: https://chromium-review.googlesource.com/c/chromium/src/+/1355774 has already landed but was not tagged with this bug number.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c984f40f3f825924c8ded4f29daf16148281269f

commit c984f40f3f825924c8ded4f29daf16148281269f
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Fri Dec 07 04:39:59 2018

[CrOS MultiDevice] Convert to multidevice::SoftwareFeature/BeaconSeed.

Before this CL, RemoteDevice and related classes directly used CryptAuth
proto enums/messages for SoftwareFeature and BeaconSeed fields. This was
problematic because:
  (1) RemoteDevice has been moved to a common/shared location and is now
      meant to be independent of any one service. Thus, it no longer
      makes sense for it to contain fields that are implementation
      details of the DeviceSync service.
  (2) The CryptAuth SoftwareFeature enum included an UNKNOWN_FEATURE
      enum value, but this value was only meant to be used as a sentinel
      value while communicating with the CryptAuth server. Since we
      previously referenced the cryptauth::SoftwareFeature enum
      directly, it was possible for RemoteDevice objects to have a state
      for UNKNOWN_FEATURE, which does not make sense in this context.
  (3) The CryptAuth SoftwareFeature enum referred to feature names using
      outdated and/or incorrect names.
  (4) CryptAuth protos do not define an operator<<() function, so it was
      possible to log a cryptauth::SoftwareFeature as a number instead
      of as a user-readable description. This led to issues such as
       https://crbug.com/906836 .

A follow-up CL will move the RemoteDevice Mojo definition from
device_sync.mojom (i.e., the DeviceSync-specific Mojo file) to a new
multidevice.mojom file meant to be referenced by other Mojo definitions.

Change-Id: Iccf4997cb5a1c6f4c34e7962c7c993f74f8aa8f0
Bug: 912743
Reviewed-on: https://chromium-review.googlesource.com/c/1362214
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614598}
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/BUILD.gn
[add] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/beacon_seed.cc
[add] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/beacon_seed.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device_ref.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device_ref.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device_ref_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device_test_util.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/remote_device_test_util.h
[add] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/software_feature.cc
[add] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/software_feature.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/multidevice/software_feature_state.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/tether/tether_host_fetcher_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/device_sync_impl.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/fake_device_sync.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/fake_device_sync.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/device_sync_client.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/device_sync_client_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/device_sync_client_impl.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/fake_device_sync_client.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/cpp/fake_device_sync_client.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/mojom/device_sync.mojom
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/mojom/device_sync.typemap
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/device_sync/public/mojom/device_sync_mojom_traits_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/device_reenroller_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/eligible_host_devices_provider_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/eligible_host_devices_provider_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/host_backend_delegate_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/host_backend_delegate_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/host_verifier_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/multidevice_setup/host_verifier_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/secure_channel/ble_service_data_helper_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/chromeos/services/secure_channel/ble_service_data_helper_impl_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/background_eid_generator.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/background_eid_generator_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/ble/ble_advertisement_generator.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/ble/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/fake_software_feature_manager.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/fake_software_feature_manager.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/remote_device_loader.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/remote_device_loader_unittest.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/software_feature_manager.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/software_feature_manager_impl.cc
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/software_feature_manager_impl.h
[modify] https://crrev.com/c984f40f3f825924c8ded4f29daf16148281269f/components/cryptauth/software_feature_manager_impl_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8009e7150db7fa61aae8dbfc644f4d2b15211280

commit 8009e7150db7fa61aae8dbfc644f4d2b15211280
Author: Regan Hsu <hsuregan@chromium.org>
Date: Fri Dec 07 20:43:46 2018

[CrOS MultiDevice] Remove local device data provider from cryptauth.

Since the MultiDevice API flag has been enabled, the local device data
provider is no longer used.  This CL removes the class and instances
where it is called.

Change-Id: Ibb574128b9faff3f84a19b92b8632325ab1597f2
Bug: 912743
Reviewed-on: https://chromium-review.googlesource.com/c/1366268
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614803}
[modify] https://crrev.com/8009e7150db7fa61aae8dbfc644f4d2b15211280/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/8009e7150db7fa61aae8dbfc644f4d2b15211280/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/8009e7150db7fa61aae8dbfc644f4d2b15211280/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/8009e7150db7fa61aae8dbfc644f4d2b15211280/components/cryptauth/BUILD.gn
[delete] https://crrev.com/c20c23e53454f2487bff5446a2b453381cccdcd5/components/cryptauth/local_device_data_provider.cc
[delete] https://crrev.com/c20c23e53454f2487bff5446a2b453381cccdcd5/components/cryptauth/local_device_data_provider.h
[delete] https://crrev.com/c20c23e53454f2487bff5446a2b453381cccdcd5/components/cryptauth/local_device_data_provider_unittest.cc
[delete] https://crrev.com/c20c23e53454f2487bff5446a2b453381cccdcd5/components/cryptauth/mock_local_device_data_provider.cc
[delete] https://crrev.com/c20c23e53454f2487bff5446a2b453381cccdcd5/components/cryptauth/mock_local_device_data_provider.h

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6d26c96509628cc84004abf1df079e6d0ec5506

commit c6d26c96509628cc84004abf1df079e6d0ec5506
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Fri Dec 07 21:48:39 2018

[CrOS MultiDevice] Create shared multidevice_types.mojom.

This CL moves RemoteDevice, BeaconSeed, SoftwareFeature, and
SoftwareFeatureState to a shared multidevice_types.mojom file, cleanly
separating them from the DeviceSync service. Previously, these Mojo
definitions were part of that service even though they are shared among
several services, so including them as part of DeviceSync created an
unnecessary dependency on that service which shouldn't exist.

Change-Id: Ie20cd22f63bd35441c1a5879d71bb5fd3c473bf4
Bug: 912743
Reviewed-on: https://chromium-review.googlesource.com/c/1363905
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614828}
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chrome/browser/resources/chromeos/multidevice_setup/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/DEPS
[add] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/BUILD.gn
[add] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/OWNERS
[add] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/multidevice.typemap
[rename] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/multidevice_mojom_traits.cc
[rename] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/multidevice_mojom_traits.h
[rename] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/multidevice_mojom_traits_unittest.cc
[add] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/multidevice_types.mojom
[rename] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/multidevice/mojom/typemaps.gni
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/components/proximity_auth/webui/resources/proximity_auth.html
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/resources/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/resources/multidevice_resources.grdp
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/device_sync/public/mojom/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/device_sync/public/mojom/OWNERS
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/device_sync/public/mojom/device_sync.mojom
[delete] https://crrev.com/49226d7b61bcb2ff8228fbeeefbe62923d1a2918/chromeos/services/device_sync/public/mojom/device_sync.typemap
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/multidevice_setup/public/mojom/multidevice_setup.mojom
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/secure_channel/public/mojom/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/chromeos/services/secure_channel/public/mojom/secure_channel.mojom
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/content/browser/webui/shared_resources_data_source.cc
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/mojo/public/tools/bindings/chromium_bindings_configuration.gni
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/ui/webui/resources/cr_components/chromeos/multidevice_setup/BUILD.gn
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/ui/webui/resources/cr_components/chromeos/multidevice_setup/mojo_api.html
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.js
[modify] https://crrev.com/c6d26c96509628cc84004abf1df079e6d0ec5506/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.js

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1da379680795f71e62c63417194aaf453f37d89c

commit 1da379680795f71e62c63417194aaf453f37d89c
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Mon Dec 10 22:27:36 2018

[CrOS MultiDevice] Move CryptAuth proto definitions to DeviceSync.

CryptAuth-related files should now be part of DeviceSync in the ongoing
effort to remove the //components/cryptauth directory.

Change-Id: I287f23a85a133f5317994755946e0dd445227599
Bug: 912743
Reviewed-on: https://chromium-review.googlesource.com/c/1364303
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615283}
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/multidevice/beacon_seed.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/multidevice/mojom/multidevice.typemap
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/multidevice/software_feature.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/proximity_auth/proximity_auth_client.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/proximity_auth/webui/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/device_sync_impl.cc
[rename] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/proto/BUILD.gn
[rename] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/proto/cryptauth_api.proto
[rename] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/proto/enum_util.cc
[rename] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/proto/enum_util.h
[rename] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/device_sync/proto/securemessage.proto
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/multidevice_setup/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/multidevice_setup/device_reenroller.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/multidevice_setup/eligible_host_devices_provider_impl_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/secure_channel/ble_scanner_impl.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/chromeos/services/secure_channel/public/mojom/secure_channel.mojom
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/background_eid_generator.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/background_eid_generator_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/ble/BUILD.gn
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/ble/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_client.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_client_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_client_impl_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_device_manager.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_device_manager_impl.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_device_manager_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_device_manager_impl_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_enroller.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_enroller_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_enrollment_manager.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_enrollment_manager_impl.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_enrollment_manager_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/cryptauth_service.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_classifier_util.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_to_device_initiator_helper.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_to_device_initiator_helper.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_to_device_responder_operations.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_to_device_secure_context.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/fake_cryptauth_device_manager.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/fake_cryptauth_enrollment_manager.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/fake_cryptauth_service.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/fake_gcm_device_info_provider.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/foreground_eid_generator.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/foreground_eid_generator_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/gcm_device_info_provider.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/mock_cryptauth_client.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/pref_names.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/remote_device_loader.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/remote_device_loader.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/remote_device_loader_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/remote_device_provider_impl_unittest.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/secure_message_delegate.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/software_feature_manager_impl.cc
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/software_feature_manager_impl.h
[modify] https://crrev.com/1da379680795f71e62c63417194aaf453f37d89c/components/cryptauth/software_feature_manager_impl_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3aa4e7567483fb1a4d494134ef90f0bd141b835

commit f3aa4e7567483fb1a4d494134ef90f0bd141b835
Author: Regan Hsu <hsuregan@chromium.org>
Date: Tue Dec 11 02:37:49 2018

[CrOS MultiDevice] Remove kMultiDevice API flags from smart lock code.

Removing kMultiDevice flags and associated code paths that will
no longer occur.

Bug: 912743
Change-Id: Iabb917876b570b8df953f22a30eb05787a5ef1ef
Reviewed-on: https://chromium-review.googlesource.com/c/1370485
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615393}
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.h
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chromeos/components/proximity_auth/mock_proximity_auth_client.cc
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chromeos/components/proximity_auth/mock_proximity_auth_client.h
[modify] https://crrev.com/f3aa4e7567483fb1a4d494134ef90f0bd141b835/chromeos/components/proximity_auth/proximity_auth_client.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e23e750e536284a3260abd3069f0711bbadbb20

commit 9e23e750e536284a3260abd3069f0711bbadbb20
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Dec 12 16:16:57 2018

Fix full ChromeOS builds - generated cryptauth proto file has moved.

ChromeOS cryptauth unittest use cryptauth_api.pb which moved from
components/cryptauth to chromeos/services/device_sync in bug 912743.
A file still included that file from the old path (and the new path)
which worked in trees where an earlier tree had generated it but didn't
work in a clean tree. The files presumably had the same include guards
so that is was ok to include both.

TBR=khorimoto@chromium.org

Bug: 912743
Change-Id: I6708c674f5fd99c94e233df5ec9b9c462c7814ad
Reviewed-on: https://chromium-review.googlesource.com/c/1373826
Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#615911}
[modify] https://crrev.com/9e23e750e536284a3260abd3069f0711bbadbb20/components/cryptauth/cryptauth_client_impl_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b97b2ba2bf722c13ef58a5d5c76350a0c065622d

commit b97b2ba2bf722c13ef58a5d5c76350a0c065622d
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Wed Dec 12 21:37:47 2018

[CrOS MultiDevice] Move appropriate CryptAuth files to DeviceSync.

This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.

See go/multidevice-directory-structure-cleanup for details.

Bug: 912743
Change-Id: Icce398a4aa93110fbd790c364bba29bf461a83e4
Reviewed-on: https://chromium-review.googlesource.com/c/1372648
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616056}
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/cryptauth/cryptauth_device_id_provider_impl.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/proximity_auth/mock_proximity_auth_client.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/tether/asynchronous_shutdown_object_container_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/DEPS
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_api_call_flow.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_api_call_flow.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_api_call_flow_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_client.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_client_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_client_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_client_impl_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_device_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_device_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_device_manager_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_device_manager_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_device_manager_impl_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller_factory_impl.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller_factory_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enroller_impl_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enrollment_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enrollment_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enrollment_manager_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enrollment_manager_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_enrollment_manager_impl_unittest.cc
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_gcm_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_gcm_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_gcm_manager_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_gcm_manager_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/cryptauth_gcm_manager_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_impl.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_service.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_type_converters.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/device_sync_type_converters.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_device_manager.cc
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_device_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_enrollment_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_enrollment_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_gcm_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_cryptauth_gcm_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_remote_device_provider.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_remote_device_provider.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_software_feature_manager.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/fake_software_feature_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/mock_cryptauth_client.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/mock_cryptauth_client.h
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/mock_sync_scheduler.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/mock_sync_scheduler.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/network_request_error.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/network_request_error.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/pref_names.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/pref_names.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/proto/BUILD.gn
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/proto/device_classifier_util.cc
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/proto/device_classifier_util.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/proto/enum_util.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/proto/enum_util.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/BUILD.gn
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/cryptauth_device_id_provider.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/fake_gcm_device_info_provider.cc
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/fake_gcm_device_info_provider.h
[add] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/public/cpp/gcm_device_info_provider.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_loader.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_loader.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_loader_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_provider.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_provider.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_provider_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_provider_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/remote_device_provider_impl_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/software_feature_manager.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/software_feature_manager_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/software_feature_manager_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/software_feature_manager_impl_unittest.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/switches.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/switches.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/sync_scheduler.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/sync_scheduler.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/sync_scheduler_impl.cc
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/sync_scheduler_impl.h
[rename] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/device_sync/sync_scheduler_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/device_reenroller.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/device_reenroller_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_impl.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_initializer.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_initializer.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_service.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/multidevice_setup_service_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client_impl_unittest.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/components/cryptauth/BUILD.gn
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/cryptauth_device_id_provider.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/cryptauth_enrollment_utils.cc
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/cryptauth_enrollment_utils.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/cryptauth_gcm_manager.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/components/cryptauth/cryptauth_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/components/cryptauth/cryptauth_service.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/device_classifier_util.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/fake_cryptauth_device_manager.h
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/components/cryptauth/fake_cryptauth_service.cc
[modify] https://crrev.com/b97b2ba2bf722c13ef58a5d5c76350a0c065622d/components/cryptauth/fake_cryptauth_service.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/fake_gcm_device_info_provider.cc
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/fake_gcm_device_info_provider.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/gcm_device_info_provider.h
[delete] https://crrev.com/d61f58149eaba41e580eddec25b6fba0af1c4651/components/cryptauth/mock_sync_scheduler.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ddc969449a5ccb60dd598b130dd33c701ae6c91

commit 1ddc969449a5ccb60dd598b130dd33c701ae6c91
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Thu Dec 13 19:14:34 2018

[CrOS MultiDevice] Move appropriate CryptAuth files to SecureChannel.

This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.

See go/multidevice-directory-structure-cleanup for details.

Bug: 912743
Change-Id: Ica14efe50b0c0c3ca85802fe969afff7e7d26f9a
Reviewed-on: https://chromium-review.googlesource.com/c/1372052
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616383}
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/fake_remote_device_life_cycle.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/remote_device_life_cycle.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/remote_device_life_cycle_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/ble_connection_manager.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/ble_connection_manager.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/ble_connection_manager_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/fake_ble_connection_manager.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/components/tether/fake_ble_connection_manager.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/BUILD.gn
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/authenticated_channel_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/authenticated_channel_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/authenticated_channel_impl_unittest.cc
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/authenticator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/authenticator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/background_eid_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/background_eid_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/background_eid_generator_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_advertisement_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_advertisement_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_advertiser_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_advertiser_impl_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_characteristics_finder.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_characteristics_finder.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_characteristics_finder_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_connection_manager_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_connection_manager_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_connection_manager_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_service_data_helper.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_service_data_helper_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_service_data_helper_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_service_data_helper_impl_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_synchronizer_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_client_connection.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_client_connection.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_client_connection_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_defines.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_generator_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_receiver.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_receiver.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/ble_weave_packet_receiver_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/connection.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/connection.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/connection_observer.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/connection_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/data_with_timestamp.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/data_with_timestamp.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_authenticator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_authenticator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_authenticator_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_initiator_helper.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_initiator_helper.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_operations_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_responder_operations.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_responder_operations.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_secure_context.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_secure_context.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/error_tolerant_ble_advertisement_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/error_tolerant_ble_advertisement_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/error_tolerant_ble_advertisement_impl_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_authenticator.cc
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_authenticator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_background_eid_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_background_eid_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_ble_advertisement_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_ble_advertisement_generator.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_ble_service_data_helper.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_ble_service_data_helper.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_connection.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_connection.h
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_channel_connection.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_channel_connection.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_channel_disconnector.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_channel_disconnector.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_context.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_secure_context.h
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_wire_message.cc
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/fake_wire_message.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/foreground_eid_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/foreground_eid_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/foreground_eid_generator_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/mock_foreground_eid_generator.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/mock_foreground_eid_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/raw_eid_generator.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/raw_eid_generator_impl.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/raw_eid_generator_impl.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/raw_eid_generator_impl_unittest.cc
[add] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/remote_attribute.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel_disconnector.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel_disconnector_impl.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel_disconnector_impl.h
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel_disconnector_impl_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_channel_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/secure_context.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/session_keys.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/session_keys.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/session_keys_unittest.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/wire_message.cc
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/wire_message.h
[rename] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/chromeos/services/secure_channel/wire_message_unittest.cc
[modify] https://crrev.com/1ddc969449a5ccb60dd598b130dd33c701ae6c91/components/cryptauth/BUILD.gn
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/authenticator.cc
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/ble/BUILD.gn
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/ble/OWNERS
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/ble/fake_wire_message.cc
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/ble/fake_wire_message.h
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/ble/remote_attribute.h
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/fake_authenticator.h
[delete] https://crrev.com/80b27029c346b2ba745695466214a8acd660b26f/components/cryptauth/fake_secure_channel.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e12019d51f4924d5d93cd7e06f4885df5921aa1

commit 1e12019d51f4924d5d93cd7e06f4885df5921aa1
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Thu Dec 13 19:57:57 2018

[CrOS MultiDevice] Move SecureMessageDelegate et. al to MultiDevice.

This is part of the ongoing effort to clean up the directory structure
of multi-device code. The files moved are only relevant to the
DeviceSync service, so they belong within the service implementation.

See go/multidevice-directory-structure-cleanup for details.

TBR=blundell@chromium.org

Bug: 912743
Change-Id: I14fe432d62e86219227554b4e454a975f2859e84
Reviewed-on: https://chromium-review.googlesource.com/c/1375370
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616408}
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/BUILD.gn
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/fake_secure_message_delegate.cc
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/fake_secure_message_delegate.h
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/fake_secure_message_delegate_unittest.cc
[add] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/secure_message_delegate.cc
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/secure_message_delegate.h
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/secure_message_delegate_impl.cc
[rename] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/multidevice/secure_message_delegate_impl.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/components/tether/ble_connection_manager_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enroller_factory_impl.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enroller_impl.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enroller_impl.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enroller_impl_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enrollment_manager_impl.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enrollment_manager_impl.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/cryptauth_enrollment_manager_impl_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/remote_device_loader.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/remote_device_loader.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/remote_device_loader_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/remote_device_provider_impl.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/device_sync/remote_device_provider_impl_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/BUILD.gn
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_authenticator.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_authenticator.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_initiator_helper.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_initiator_helper.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_operations_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_responder_operations.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_responder_operations.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_secure_context.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_secure_context.h
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/device_to_device_secure_context_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/secure_channel.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/chromeos/services/secure_channel/secure_channel_unittest.cc
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/components/BUILD.gn
[modify] https://crrev.com/1e12019d51f4924d5d93cd7e06f4885df5921aa1/components/cryptauth/BUILD.gn
[delete] https://crrev.com/014d84db08ed583fd33028760e0d4a26f2b64966/components/cryptauth/secure_message_delegate.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07912b7d7ad3b7f93f8182bc0302fb4df09788f9

commit 07912b7d7ad3b7f93f8182bc0302fb4df09788f9
Author: Regan Hsu <hsuregan@chromium.org>
Date: Thu Dec 13 21:27:01 2018

[CrOS MultiDevice] Remove remaining kMultiDeviceApi flags

Removing remaining kMultiDevice flags and associated code paths that
will no longer occur.

Bug: 912743
Change-Id: I169c667c22a9063668b7935ee87cc3f04b168df1
Reviewed-on: https://chromium-review.googlesource.com/c/1372464
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616440}
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service_factory.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service_factory.h
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/login/screens/multidevice_setup_screen.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/multidevice_setup/multidevice_setup_client_factory.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/secure_channel/secure_channel_client_provider.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/secure_channel/secure_channel_client_provider.h
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/07912b7d7ad3b7f93f8182bc0302fb4df09788f9/chrome/browser/ui/webui/settings/md_settings_ui.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0

commit 4ce94318a9dd593b9062ff2c2ac1fe497274e6b0
Author: Regan Hsu <hsuregan@chromium.org>
Date: Fri Dec 14 20:07:08 2018

[CrOS MultiDevice] Remove cryptauth service.

Since the MultiDevice API flag has been enabled, the cryptauth service
class is no longer used.  This CL removes the class and instances
where it is called.

Bug: 912743
Change-Id: Iadcb5cd38fa70f4c4bb3d842940992faf33761af
Reviewed-on: https://chromium-review.googlesource.com/c/1367103
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616801}
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/apps/platform_apps/api/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/fake_tether_service.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/fake_tether_service.h
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/tether_service_factory.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/chromeos/tether/tether_service_unittest.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/components/proximity_auth/webui/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/services/device_sync/public/cpp/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/services/multidevice_setup/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/services/multidevice_setup/public/cpp/BUILD.gn
[modify] https://crrev.com/4ce94318a9dd593b9062ff2c2ac1fe497274e6b0/chromeos/services/secure_channel/public/cpp/client/BUILD.gn
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/BUILD.gn
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/DEPS
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/OWNERS
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/README
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/cryptauth_service.cc
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/cryptauth_service.h
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/fake_cryptauth_service.cc
[delete] https://crrev.com/bbfa243d61bb12cb6f21781ed85345004b5c9362/components/cryptauth/fake_cryptauth_service.h

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 17

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cdb1d06a46cede18327d47bfce087b60c3d2364

commit 3cdb1d06a46cede18327d47bfce087b60c3d2364
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Tue Dec 18 00:18:06 2018

[CrOS MultDevice] Remove kEnableUnifiedMultiDeviceSetup from //ash.

The feature has already been rolled out, and the flag is no longer
necessary.

Bug: 912743
Change-Id: Id1ebc0476921b234869d3f355f410b568dcd616b
Reviewed-on: https://chromium-review.googlesource.com/c/1381149
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617305}
[modify] https://crrev.com/3cdb1d06a46cede18327d47bfce087b60c3d2364/ash/shell.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a77dee91adc121a8bb929977da141d1dbf874c29

commit a77dee91adc121a8bb929977da141d1dbf874c29
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Tue Dec 18 00:51:33 2018

[CrOS MultiDevice] Remove kEnableUnifiedMultiDevice from settings.

This CL removes kEnableUnifiedMultiDevice as well as its JS
representation (the loadTimeData "enableMultideviceSettings" property)
from settings. The feature has already been rolled out, and the flag is
no longer necessary.

Bug: 912743
Change-Id: Ie729fb732f83f07762be30cb5b0c3ce588905a3a
Reviewed-on: https://chromium-review.googlesource.com/c/1380949
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617317}
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/basic_page/basic_page.js
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/a77dee91adc121a8bb929977da141d1dbf874c29/chrome/test/data/webui/settings/site_list_tests.js

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75bb478ac3649caf7d93623b32974a0d05f9066c

commit 75bb478ac3649caf7d93623b32974a0d05f9066c
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Tue Dec 18 01:18:36 2018

[CrOS MultiDevice] Remove the kEnableUnifiedMultiDeviceSettings flag.

All references to the flag had already been removed, so this flag is no
longer needed.

Bug: 912743
Change-Id: If13ad69ebad024f64d2bcfdcb9a9278af45cb766
Reviewed-on: https://chromium-review.googlesource.com/c/1381000
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617325}
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chrome/browser/about_flags.cc
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chrome/browser/flag-metadata.json
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chromeos/chromeos_features.cc
[modify] https://crrev.com/75bb478ac3649caf7d93623b32974a0d05f9066c/chromeos/chromeos_features.h

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9540acad786cc77e1fad6e2081eca718df474075

commit 9540acad786cc77e1fad6e2081eca718df474075
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Tue Dec 18 01:30:56 2018

[CrOS MultiDevice] Move ProximityAuth logging to MultiDevice.

The MultiDevice component is the correct location for shared
multi-device code.

Bug: 912743
Change-Id: Ie66b135d889c89edad8371ef5ed3a4facec6fd6b
Reviewed-on: https://chromium-review.googlesource.com/c/1380555
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617328}
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/ash/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/ash/DEPS
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/apps/platform_apps/api/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/android_sms/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/android_sms/connection_establisher_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/android_sms/connection_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/cryptauth/chrome_cryptauth_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/multidevice_setup/android_sms_pairing_state_tracker_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/ui/ash/network/tether_notification_presenter.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chrome/browser/ui/webui/settings/chromeos/multidevice_handler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/BUILD.gn
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/BUILD.gn
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/log_buffer.cc
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/log_buffer.h
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/logging.cc
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/logging.h
[rename] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/logging/logging_unittest.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/multidevice/secure_message_delegate_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/BUILD.gn
[delete] https://crrev.com/cb48f7ca8f16286ebd78b931e83864f95782d92e/chromeos/components/proximity_auth/logging/OWNERS
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_auth_local_state_pref_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_auth_profile_pref_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_auth_system.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_monitor_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/screenlock_bridge.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/unlock_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/webui/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/active_host.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/active_host_network_state_updater.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/connect_tethering_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/connection_preserver_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/crash_recovery_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/disconnect_tethering_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/disconnect_tethering_request_sender_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/gms_core_notifications_state_tracker_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/host_scan_scheduler_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/host_scanner_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/hotspot_usage_duration_tracker.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/keep_alive_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/master_host_scan_cache.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/message_transfer_operation.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/network_configuration_remover.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/network_connection_handler_tether_delegate.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/network_host_scan_cache.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/tether_component_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/tether_connector_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/tether_disconnector_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/tether_host_fetcher.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/tether_network_disconnection_handler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/wifi_hotspot_connector.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/components/tether/wifi_hotspot_disconnector_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_api_call_flow.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_client_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_device_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_enroller_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_enrollment_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/cryptauth_gcm_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/device_sync_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/device_sync_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/public/cpp/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/public/cpp/device_sync_client_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/remote_device_loader.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/sync_scheduler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/device_sync/sync_scheduler_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/account_status_change_delegate_notifier.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/account_status_change_delegate_notifier_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/android_sms_app_installing_status_observer.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/feature_state_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_backend_delegate_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_device_timestamp_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_status_provider.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_status_provider_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_verifier.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/host_verifier_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/multidevice_setup_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/multidevice_setup_initializer.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/multidevice_setup_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/privileged_host_device_setter_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/public/cpp/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/multidevice_setup/public/cpp/multidevice_setup_client_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/DEPS
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/active_connection_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/active_connection_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/authenticated_channel_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/background_eid_generator.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_advertisement_generator.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_advertiser_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_characteristics_finder.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_connection_manager.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_connection_manager_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_scanner.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_scanner_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_service_data_helper.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_service_data_helper_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_synchronizer.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_weave_client_connection.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_weave_client_connection_unittest.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/ble_weave_packet_receiver.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/client_connection_parameters.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/connect_to_device_operation.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/connection.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/connection_attempt.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/connection_attempt_base.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/device_to_device_authenticator.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/device_to_device_initiator_helper.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/device_to_device_responder_operations.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/device_to_device_secure_context.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/error_tolerant_ble_advertisement_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/foreground_eid_generator.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/multiplexed_channel_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/pending_ble_initiator_connection_request.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/pending_ble_listener_connection_request.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/pending_connection_request_base.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/public/cpp/client/BUILD.gn
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/public/cpp/client/connection_attempt.h
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/secure_channel.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/secure_channel_disconnector_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/secure_channel_impl.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/secure_channel_initializer.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/secure_channel_service.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/shared_resource_scheduler.cc
[modify] https://crrev.com/9540acad786cc77e1fad6e2081eca718df474075/chromeos/services/secure_channel/wire_message.cc

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 18

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758

commit ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Tue Dec 18 23:17:13 2018

[CrOS MultiDevice] Move ProximityAuth WebUI code to MultiDevice.

The MultiDevice component is the correct location for shared
multi-device code, including the chrome://proximity-auth debug UI.

Bug: 912743
Change-Id: I788ce0eba9528159b1859cb45303f0816fc19959
Reviewed-on: https://chromium-review.googlesource.com/c/1383114
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617666}
[modify] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/BUILD.gn
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/DEPS
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/proximity_auth_ui.cc
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/proximity_auth_ui.h
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/proximity_auth_webui_handler.cc
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/proximity_auth_webui_handler.h
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/common.css
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/index.html
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/logs.js
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/pollux.css
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/pollux.html
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/pollux.js
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/proximity_auth.css
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/proximity_auth.html
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/proximity_auth.js
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/resources/webui.js
[rename] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/url_constants.cc
[add] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/debug_webui/url_constants.h
[modify] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/components/multidevice/remote_device_ref.h
[delete] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/chromeos/components/proximity_auth/webui/OWNERS
[delete] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/chromeos/components/proximity_auth/webui/url_constants.h
[modify] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/resources/chromeos_resources.grd
[modify] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/chromeos/resources/multidevice_resources.grdp
[delete] https://crrev.com/d9e9d19b138a03b21fc41f9cb55d3168eb9d1e76/chromeos/resources/proximity_auth_resources.grdp

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de865801489a83baf6ead8715959a87827b8ee2

commit 7de865801489a83baf6ead8715959a87827b8ee2
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Wed Dec 19 20:40:25 2018

[CrOS MultiDevice] Update multi-device watchlist.

These changes reflect the directory structure change from
go/multidevice-directory-structure-cleanup.

Bug: 912743
Change-Id: Iaacb04ed51834595605ed494b2cbe87e775fa361
Reviewed-on: https://chromium-review.googlesource.com/c/1385005
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617940}
[modify] https://crrev.com/7de865801489a83baf6ead8715959a87827b8ee2/WATCHLISTS

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc23978b8d55ecb26de83a662e1bffc19ea5655a

commit cc23978b8d55ecb26de83a662e1bffc19ea5655a
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Wed Dec 19 21:46:25 2018

[CrOS MultiDevice] Remove obsolete dependencies on MultiDevice services.

Now that code from Instant Tethering and Smart Lock has been fully
migrated to use the DeviceSync, SecureChannel, and MultiDeviceSetup
services, these features no longer need to access the implementations of
those services and should isntead use the client libraries and/or Mojo
APIs instead.

This CL removes the dependencies. Additionally, to prevent new code from
adding new dependencies, this CL updates the BUILD files for the
relevant services to deny visibility into the service implementations to
all code except for //chrome/browser (which initializes the services)
and test code (which mocks out the services).

Bug: 912743
Change-Id: Id8b58de73988b2142099adcd9fd8ef6f6584a11e
Reviewed-on: https://chromium-review.googlesource.com/c/1384931
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617963}
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.h
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/tether/tether_service.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chrome/browser/chromeos/tether/tether_service.h
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/messenger_impl.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/mock_proximity_auth_client.h
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/remote_device_life_cycle.h
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/remote_device_life_cycle_impl.h
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/components/tether/host_scanner_impl.cc
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/services/multidevice_setup/BUILD.gn
[modify] https://crrev.com/cc23978b8d55ecb26de83a662e1bffc19ea5655a/chromeos/services/secure_channel/BUILD.gn

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e6e89050a0f555860cae2c4da70293c77a4e11

commit d1e6e89050a0f555860cae2c4da70293c77a4e11
Author: Kyle Horimoto <khorimoto@chromium.org>
Date: Wed Dec 19 23:58:42 2018

[CrOS MultiDevice] Remove unnecessary multi-device namespaces.

Several files which reside in the DeviceSync, MultiDeviceSetup, and
SecureChannel services were moved into those directories during the
multi-device directory cleanup. Before the move, these files used other
namespaces (e.g., cryptauth::*), so when they referenced multi-device
services, they namespaced types using chromeos::device_sync::*,
chromeos::multidevice_setup::*, and chromeos::secure_channel::*.

Now that these files reside in the services themselves and use the same
namespaces as the rest of the files in those directories, these
namespaces are no longer needed and cause unnecessary verbosity. This CL
removes them.

Bug: 912743
Change-Id: I50aee4767bb4e131e90e9ac7df9e77655a0b4ece
Reviewed-on: https://chromium-review.googlesource.com/c/1385108
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618013}
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/cryptauth_device_manager_impl.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/cryptauth_device_manager_impl_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/device_sync_service.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/device_sync_service_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/fake_device_sync_observer.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/fake_remote_device_provider.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/fake_remote_device_provider.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/fake_software_feature_manager.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/fake_software_feature_manager.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/public/cpp/device_sync_client_impl.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_loader.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_loader.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_loader_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_provider.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_provider_impl.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_provider_impl.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/remote_device_provider_impl_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/software_feature_manager.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/software_feature_manager_impl.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/software_feature_manager_impl.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/device_sync/software_feature_manager_impl_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/multidevice_setup/device_reenroller.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/multidevice_setup/public/cpp/fake_multidevice_setup.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/background_eid_generator.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/background_eid_generator.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/background_eid_generator_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_advertisement_generator.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_advertisement_generator.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_advertisement_generator_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_scanner_impl.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_scanner_impl.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_service_data_helper_impl.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_service_data_helper_impl_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_weave_client_connection.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_weave_client_connection.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/ble_weave_client_connection_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/connection.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/connection.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/connection_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_background_eid_generator.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_background_eid_generator.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_ble_advertisement_generator.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_ble_advertisement_generator.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_connection.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/fake_connection.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/foreground_eid_generator.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/foreground_eid_generator_unittest.cc
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/secure_channel_service.h
[modify] https://crrev.com/d1e6e89050a0f555860cae2c4da70293c77a4e11/chromeos/services/secure_channel/secure_channel_unittest.cc

Owner: ----
At this point, the remaining tasks for the cleanup all relate to Smart Lock. Here is what needs to be done:

(1) Rename //chromeos/components/proximity_auth to //chromeos/components/smart_lock.
(2) Namespace all files in that directory with chromeos::smart_lock::* instead of proximity_auth::*.
(3) Move all files from //chrome/browser/chromeos/login/easy_unlock which do *not* have a dependency in //chrome to //chromeos/components/smart_lock (should be the vast majority of these files). Make sure to adjust the namespace to chromeos::smart_lock::* while moving the files.
(4) Rename //chrome/browser/chromeos/login/easy_unlock to //chrome/browser/chromeos/login/smart_lock and EasyUnlockService* to SmartLockService* since we want to move toward the Smart Lock naming convention.

Unassigning myself for now as I'll be working on other tasks.
Labels: -Pri-2 Pri-3
Owner: jhawkins@chromium.org
Status: Assigned (was: Started)
I can take care of Smart Lock in my spare time.

Sign in to add a comment