The network bytes of lazily loaded images are sometimes being recorded as coming from the cache in PageLoad metrics |
|||||||
Issue descriptionWhen an image that was deferred by LazyLoad gets loaded in (e.g. because the user scrolled down near it), and the first 2KB range of that image is already in the cache, the page load bytes-related metrics (e.g. PageLoad.Experimental.Bytes.Network, PageLoad.Experimental.Bytes.Cache, PageLoad.Experimental.Bytes.Total) seem to record the bytes of the range response for the full image as having come entirely from the cache, even if only the first 2KB of the range is served from the cache and the rest of the range comes from the network. The actual number of bytes fetched over the network should be recorded in a histogram somehow.
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af544c05560d6b36a5936450d16daf39c7e6f7af commit af544c05560d6b36a5936450d16daf39c7e6f7af Author: rajendrant <rajendrant@chromium.org> Date: Sat Dec 08 03:33:45 2018 Record network bytes data use using OnResourceDataUpdate Record bytes reported by OnResourceDataUpdate observer callback which is received pre and post mojo. This is helpful for media requests which do not complete. This is also needed post-mojo since OnLoadedResource will not be called. TBR=mpearson@chromium.org Bug: 912737 , 894168 Change-Id: I290d5d2438f0838daafb92e2b264e15ef9af7e16 Reviewed-on: https://chromium-review.googlesource.com/c/1368593 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614936} [modify] https://crrev.com/af544c05560d6b36a5936450d16daf39c7e6f7af/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/af544c05560d6b36a5936450d16daf39c7e6f7af/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/af544c05560d6b36a5936450d16daf39c7e6f7af/tools/metrics/histograms/histograms.xml
,
Dec 11
Requesting to merge CL c#2 to M72. This CL is simple and adds a new histogram that will help analyze the lazyload feature when it gets enabled in beta. The new histogram is recorded fine in canary.
,
Dec 11
Pls apply appropriate OSs label.
,
Dec 11
,
Dec 12
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f239aa492cf46f8bea9be1e9af3b924ee10f332 commit 8f239aa492cf46f8bea9be1e9af3b924ee10f332 Author: rajendrant <rajendrant@chromium.org> Date: Wed Dec 12 19:09:02 2018 Record network bytes data use using OnResourceDataUpdate Record bytes reported by OnResourceDataUpdate observer callback which is received pre and post mojo. This is helpful for media requests which do not complete. This is also needed post-mojo since OnLoadedResource will not be called. TBR=mpearson@chromium.org Bug: 912737 , 894168 Change-Id: I290d5d2438f0838daafb92e2b264e15ef9af7e16 Reviewed-on: https://chromium-review.googlesource.com/c/1368593 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614936}(cherry picked from commit af544c05560d6b36a5936450d16daf39c7e6f7af) Reviewed-on: https://chromium-review.googlesource.com/c/1374408 Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#296} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/8f239aa492cf46f8bea9be1e9af3b924ee10f332/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc [modify] https://crrev.com/8f239aa492cf46f8bea9be1e9af3b924ee10f332/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h [modify] https://crrev.com/8f239aa492cf46f8bea9be1e9af3b924ee10f332/tools/metrics/histograms/histograms.xml
,
Dec 13
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f239aa492cf46f8bea9be1e9af3b924ee10f332 Commit: 8f239aa492cf46f8bea9be1e9af3b924ee10f332 Author: rajendrant@chromium.org Commiter: rajendrant@chromium.org Date: 2018-12-12 19:09:02 +0000 UTC Record network bytes data use using OnResourceDataUpdate Record bytes reported by OnResourceDataUpdate observer callback which is received pre and post mojo. This is helpful for media requests which do not complete. This is also needed post-mojo since OnLoadedResource will not be called. TBR=mpearson@chromium.org Bug: 912737 , 894168 Change-Id: I290d5d2438f0838daafb92e2b264e15ef9af7e16 Reviewed-on: https://chromium-review.googlesource.com/c/1368593 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614936}(cherry picked from commit af544c05560d6b36a5936450d16daf39c7e6f7af) Reviewed-on: https://chromium-review.googlesource.com/c/1374408 Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#296} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nmontruc...@crestwoodschools.org
, Dec 7