New issue
Advanced search Search tips

Issue 912725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Report PreviewsEligibilityReason as offline when device is offline

Project Member Reported by tbansal@chromium.org, Dec 6

Issue description

Currently, if the device is offline, PreviewsEligibilityReason records the reason for not showing previews as "network quality unavailable". We should instead record it as "device offline". We would still keep "network quality unavailable" for the cases where NQE (network quality estimator) reports ECT as Unknown.

This would help us in differentiating the count of cases where preview is not shown because device is offline vs. when network quality is unavailable.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c4f97005f6f162b3df6953b8f2a4efce338ec1

commit 01c4f97005f6f162b3df6953b8f2a4efce338ec1
Author: Tarun Bansal <tbansal@chromium.org>
Date: Fri Dec 07 06:11:36 2018

Report PreviewsEligibilityReason as offline when device is offline

Currently, if the device is offline, PreviewsEligibilityReason
records the reason for not showing previews as network quality
unavailable.

This CL changes it to record the reason as device offline.
Network quality unavailable reason is now used for only the cases where
NQE (network quality estimator) reports ECT as Unknown.

Bug:  912725 
Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
Reviewed-on: https://chromium-review.googlesource.com/c/1366835
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614621}
[modify] https://crrev.com/01c4f97005f6f162b3df6953b8f2a4efce338ec1/components/previews/content/previews_decider_impl.cc
[modify] https://crrev.com/01c4f97005f6f162b3df6953b8f2a4efce338ec1/components/previews/content/previews_decider_impl_unittest.cc
[modify] https://crrev.com/01c4f97005f6f162b3df6953b8f2a4efce338ec1/components/previews/core/previews_black_list.h
[modify] https://crrev.com/01c4f97005f6f162b3df6953b8f2a4efce338ec1/components/previews/core/previews_logger.cc
[modify] https://crrev.com/01c4f97005f6f162b3df6953b8f2a4efce338ec1/tools/metrics/histograms/enums.xml

Labels: -M-72 M-73
Status: Fixed (was: Started)

Sign in to add a comment