New issue
Advanced search Search tips

Issue 912700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 646565



Sign in to add a comment

ChromeKeyboardUITest.ChromeKeyboardContentsDelegate failing with single process mash

Project Member Reported by est...@chromium.org, Dec 6

Issue description

[ RUN      ] ChromeKeyboardUITest.ChromeKeyboardContentsDelegate
[30411:30411:1206/123341.117491:18811177061:FATAL:chrome_keyboard_ui.cc(36)] Check failed: !::features::IsUsingWindowService(). 
#0 0x55ba110d560f base::debug::StackTrace::StackTrace()
#1 0x55ba11037e4b logging::LogMessage::~LogMessage()
#2 0x55ba13a3cfcb ChromeKeyboardUI::ChromeKeyboardUI()
#3 0x55ba0c21fc60 (anonymous namespace)::ChromeKeyboardUITest::SetUp()
#4 0x55ba0d55e8d0 testing::Test::Run()
#5 0x55ba0d55f66f testing::TestInfo::Run()
#6 0x55ba0d55fb97 testing::TestCase::Run()
#7 0x55ba0d56bdd7 testing::internal::UnitTestImpl::RunAllTests()
#8 0x55ba0d56b94d testing::UnitTest::Run()
#9 0x55ba106d3f01 base::TestSuite::Run()
#10 0x55ba106d5f9d base::(anonymous namespace)::LaunchUnitTestsInternal()
#11 0x55ba106d5e01 base::LaunchUnitTests()
#12 0x55ba106c8e0f main
#13 0x7f2ebb31cf45 __libc_start_main
#14 0x55ba0b58352a _start

[4879/12550] ChromeKeyboardUITest.ChromeKeyboardContentsDelegate (CRASHED)
 
Owner: steve...@chromium.org
Status: Started (was: Available)
We shouldn't be running this test, I'll update the filter.

Guess there isn't a filter for unit_tests, I'll just disable it.

> Guess there isn't a filter for unit_tests, I'll just disable it.

testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter

(sorry I didn't provide links or mention "FYI" in the bug report)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23c6b9cd8e22c2ab099c135c5dd6d1aae0e084e

commit e23c6b9cd8e22c2ab099c135c5dd6d1aae0e084e
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 10 20:49:12 2018

Disable ChromeKeyboardUITest with Window Service

Bug:  912700 
Change-Id: I0e0c82ea6344d92ba06e6e956663d788680a3d8f
Reviewed-on: https://chromium-review.googlesource.com/c/1368029
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615243}
[modify] https://crrev.com/e23c6b9cd8e22c2ab099c135c5dd6d1aae0e084e/chrome/browser/ui/ash/keyboard/chrome_keyboard_ui_unittest.cc
[modify] https://crrev.com/e23c6b9cd8e22c2ab099c135c5dd6d1aae0e084e/testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter

Status: Fixed (was: Started)

Sign in to add a comment