Issue metadata
Sign in to add a comment
|
ChromeSignInWebViewTest.NoFindInPageForUnattachedGuest broken in only single_process_mash_browser_tests on chromium.chromiumos/linux-chromeos-dbg |
||||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jyasskin@google.com single_process_mash_browser_tests failing on chromium.chromiumos/linux-chromeos-dbg. The first failure I see is in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9380, but it succeeds for a batch of runs after that, so the change that broke it could be several runs before.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14d25fb9050e3a5b9eea892514325e7a44d9e894 commit 14d25fb9050e3a5b9eea892514325e7a44d9e894 Author: Samuel Huang <huangs@chromium.org> Date: Fri Dec 07 16:16:54 2018 Revert "Downloads: detect failed file icons and show default thumbnail" This reverts commit 1ec126531ceaebdd0b9ee340ec4d750507290fd7. Reason for revert: Likely to cause consistent failures in single_process_mash_interactive_ui_tests for linux-chromeos-dbg due to assertion failure from missing icon "cr:insert-drive-file". Bug: 912678 Original change's description: > Downloads: detect failed file icons and show default thumbnail > > On the downloads page, we consult the system for a themed image for the > type of file downloads. Ex: zip files -> archive icon. > > When a system doesn't know why type of icon to show for a specific file > type, it can either return a default or nothing. Right now, Linux > returns nothing, so we show nothing. chrome://fileicon tries to warn > us by giving a network error (which has been ignored until now). > > So, when a chrome://fileicon fails to load, show a default filetype > icon in respond. > > Before & after screenshots: https://imgur.com/a/txRbfIG > > R=dpapad@chromium.org > BUG= 855259 > > Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe > Reviewed-on: https://chromium-review.googlesource.com/c/1132560 > Commit-Queue: Dan Beam <dbeam@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614581} TBR=dbeam@chromium.org,dpapad@chromium.org Change-Id: I4ef27f132954754a80e3b3def4aadf5774b3875d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855259 Reviewed-on: https://chromium-review.googlesource.com/c/1367933 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#614713} [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/browser_resources.grd [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/md_downloads/BUILD.gn [delete] https://crrev.com/b6cfb7f00be42160f7e1d0cdcc78996dd03617d4/chrome/browser/resources/md_downloads/icon_loader.html [delete] https://crrev.com/b6cfb7f00be42160f7e1d0cdcc78996dd03617d4/chrome/browser/resources/md_downloads/icon_loader.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/print_preview/icons.html [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/resources/print_preview/new/app.html [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/test/data/webui/icon_test.html [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/test/data/webui/md_downloads/downloads_browsertest.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/test/data/webui/md_downloads/item_tests.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/chrome/test/data/webui/md_downloads/test_support.js [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/ui/webui/resources/cr_elements/icons.html [modify] https://crrev.com/14d25fb9050e3a5b9eea892514325e7a44d9e894/ui/webui/resources/js/icon.js
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee261c6dcce9b2d11bd54a3378291341c9105234 commit ee261c6dcce9b2d11bd54a3378291341c9105234 Author: Dan Beam <dbeam@chromium.org> Date: Tue Dec 11 03:21:00 2018 Revert "Revert "Downloads: detect failed file icons and show default thumbnail"" This reverts commit 14d25fb9050e3a5b9eea892514325e7a44d9e894. This is a roll-forward with a fix to the URL of an iconset to load (see the diff between patchsets 1 and 2). NOPRESUBMIT=true # existing issue in destination.js Bug: 855259 , 912678 Change-Id: I3aeb26263de682ecb2f0596e336ec20ab5c19807 Reviewed-on: https://chromium-review.googlesource.com/c/1371079 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615412} [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/browser_resources.grd [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/md_downloads/BUILD.gn [add] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/md_downloads/icon_loader.html [add] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/md_downloads/icon_loader.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/md_downloads/item.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/md_downloads/item.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/print_preview/data/destination.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/print_preview/icons.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/print_preview/new/destination_dialog.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/resources/print_preview/new/destination_list_item.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/test/data/webui/icon_test.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/test/data/webui/md_downloads/downloads_browsertest.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/test/data/webui/md_downloads/item_tests.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/chrome/test/data/webui/md_downloads/test_support.js [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/ui/webui/resources/cr_elements/icons.html [modify] https://crrev.com/ee261c6dcce9b2d11bd54a3378291341c9105234/ui/webui/resources/js/icon.js
,
Dec 11
,
Dec 12
Reopening as this fails more often than it succeeds. Last failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9530 Failure log: [ RUN ] ChromeSignInWebViewTest.NoFindInPageForUnattachedGuest [1:1:1212/033329.712663:INFO:hugepage_text.cc(68)] Mlocking text pages failed: Cannot allocate memory (12) [13730:13730:1212/033331.040168:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user [13730:13730:1212/033331.150021:WARNING:easy_unlock_service_regular.cc(446)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false. [13730:13730:1212/033331.452704:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances. [13730:13730:1212/033332.178261:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *) [13730:13730:1212/033332.628899:ERROR:remote_text_input_client.cc(150)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged() [13730:13730:1212/033332.628962:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const [13730:13730:1212/033332.628988:ERROR:remote_text_input_client.cc(191)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning() [13730:13730:1212/033332.629059:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const [13730:13730:1212/033332.629086:ERROR:remote_text_input_client.cc(113)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const [13730:13730:1212/033333.180066:ERROR:render_widget_host_view_aura.cc(1298)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [13730:13730:1212/033333.670062:WARNING:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source: (0) [13730:13730:1212/033334.069846:WARNING:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442) [13730:13730:1212/033334.696694:WARNING:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083) [13730:13730:1212/033335.312651:WARNING:merge_session_throttling_utils.cc(142)] Loading content for a profile without session restore? [13730:13730:1212/033335.723833:WARNING:CONSOLE(293)] "<webview>: The load has aborted with error -11: ERR_NOT_IMPLEMENTED.", source: extensions::webViewEvents (293) [13730:13730:1212/033336.711268:INFO:CONSOLE(0)] "Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://accounts.google.com') does not match the recipient window's origin ('null').", source: (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x7f0f8c5bb04d base::debug::StackTrace::StackTrace() #1 0x7f0f8c2b4bea base::debug::StackTrace::StackTrace() #2 0x56046670f862 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f0f5896fcb0 <unknown> #4 0x7f0f58a376d3 epoll_wait #5 0x7f0f8c66a56f epoll_dispatch #6 0x7f0f8c65dcf5 event_base_loop #7 0x7f0f8c60e469 base::MessagePumpLibevent::Run() #8 0x7f0f8c346a06 base::MessageLoopImpl::Run() #9 0x7f0f8c3f2612 base::RunLoop::Run() #10 0x5604667a923e content::RunThisRunLoop() #11 0x5604667ab098 content::MessageLoopRunner::Run() #12 0x56046693f887 guest_view::TestGuestViewManager::WaitForNextGuestCreated() #13 0x56045db57f86 ChromeSignInWebViewTest_NoFindInPageForUnattachedGuest_Test::RunTestOnMainThread() #14 0x56046670dd95 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #15 0x56045db8992d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #16 0x56045db89874 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #17 0x560466710bf5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #18 0x560466710b2c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #19 0x56045db7a08d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #20 0x560465447830 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x5604654459c4 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x560460b02aeb chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f0f81738792 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f0f802f920d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #25 0x7f0f802f9154 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #26 0x7f0f8173e515 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #27 0x7f0f8173e44c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #28 0x7f0f801fdd2d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #29 0x7f0f82726edd content::StartupTaskRunner::RunAllTasksNow() #30 0x7f0f817342ef content::BrowserMainLoop::CreateStartupTasks() #31 0x7f0f81740b93 content::BrowserMainRunnerImpl::Initialize() #32 0x7f0f8172bc09 content::BrowserMain() #33 0x7f0f83a9ad50 content::RunBrowserProcessMain() #34 0x7f0f83a9e1c5 content::ContentMainRunnerImpl::RunServiceManager() #35 0x7f0f83a9cd89 content::ContentMainRunnerImpl::Run() #36 0x7f0f83a93b4c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #37 0x7f0f571698c1 service_manager::Main() #38 0x7f0f83a98465 content::ContentMain() #39 0x56046670d342 content::BrowserTestBase::SetUp() #40 0x5604652ea7bb InProcessBrowserTest::SetUp() #41 0x560465203ecc extensions::ExtensionBrowserTest::SetUp() #42 0x56045db6cd60 WebViewTest::SetUp() #43 0x56045dbdb95e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_ #44 0x560461a35352 testing::internal::HandleExceptionsInMethodIfSupported<>() #45 0x560461a150b4 testing::Test::Run() #46 0x560461a15d62 testing::TestInfo::Run() #47 0x560461a16c7f testing::TestCase::Run() #48 0x560461a2ab2b testing::internal::UnitTestImpl::RunAllTests() #49 0x560461a3ec5e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #50 0x560461a36ac2 testing::internal::HandleExceptionsInMethodIfSupported<>() #51 0x560461a2a767 testing::UnitTest::Run() #52 0x560465334881 RUN_ALL_TESTS() #53 0x560465331a4b base::TestSuite::Run() #54 0x5604651d65d7 ChromeTestSuiteRunner::RunTestSuite() #55 0x5604651d66c3 ChromeTestLauncherDelegate::RunTestSuite() #56 0x5604667983e9 content::LaunchTests() #57 0x5604651d79e1 LaunchChromeTests() #58 0x5604651d5f1b main #59 0x7f0f5895af45 __libc_start_main #60 0x56045db035da _start
,
Dec 12
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by hua...@chromium.org
, Dec 7