New issue
Advanced search Search tips

Issue 912672 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Timed out tests should include statement that they timed out

Project Member Reported by jyasskin@chromium.org, Dec 6

Issue description

Components: Infra>Platform>Swarming>WebUI
Owner: martiniss@google.com
Status: Assigned (was: Untriaged)
It's neither related to Swarming (the task itself didn't time out, a test case did) nor logdog (it doesn't process logs).

I'll assign to Stephen so he can triage.
Components: -Infra>Platform>LogDog -Infra>Platform>Swarming>WebUI Infra>Platform>Recipes
Owner: martiniss@chromium.org
(pressed enter too fast)
This theoretically is a problem with gtest logs. I'm pretty sure the recipes just look at the gtest output json and present information from that. I'm trying to verify this, and having a bit of trouble, but I'll look into this.
Components: -Infra>Platform>Recipes Infra>Client>Chrome
Ok, figured it out. Some of the links you gave were confusing to me.

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927864305669201008/+/steps/single_process_mash_browser_tests/0/logs/KeyboardOperations__x2f_FilesAppBrowserTest.Test__x2f_keyboardCopyDrive/0  is generated from the gtest output. You can view that in https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=a9d9872dae5e5f18cf4e21411b6a7edd67f0655c&as=output.json (very big file).

That output contains everything printed in the swarming task output, visible at https://chromium-swarm.appspot.com/task?id=419dbdae88bc1c10&refresh=10&show_raw=1. 

Gtest results only shows the logs it does because it probably assumes users have the context of the whole gtest result file, which does have the correct result info.

We do generate the output of the link that you have at the beginning (logs.chromium.org/...) in the recipe, so we could add some extra information at the bottom if that'd be helpful (test result, how long it took, etc...) Although we'd need to make sure that users do know what exactly that log file means, what's part of the test log and what isn't. jyasskin@, does that make sense? Any opinions?
Showing all of the metadata from the gtest json sounds like it would fix this problem. It has `"status":"TIMEOUT"`, which is exactly what I was missing.

I, as a user, don't know exactly what this log file means today, so you wouldn't be making that any worse, whatever you did. 😃 Putting some markers around the log test might be able to improve it by giving you a place to include explanatory text, delineate the 4 separate test runs that are currently just concatenated, etc.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5cc86a6317da2ca37d30e3d0e0eb806508863e87

commit 5cc86a6317da2ca37d30e3d0e0eb806508863e87
Author: Stephen Martinis <martiniss@chromium.org>
Date: Thu Jan 03 21:28:28 2019

Add info on test execution to gtest log

GTest output includes the stdout of the test execution. We currently
display this via a link in the step in the build, but it doesn't really
show how the step ended. This is important if the test timed out,
failed, etc... This CL makes the test display this information now.

Bug:  912672 
Change-Id: I3bd5b02ba1534cb794ad212f2a4965d5e5c714cc
Reviewed-on: https://chromium-review.googlesource.com/c/1368497
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/enable_retry_with_patch_succeed_after_deapply.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/test_utils/util.py
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/flaky_tests.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_custom_name.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests_non_json_buildbucket.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_junit_test.expected/basic.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/basic.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_deduped_shard.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_android/tests/run_webview_cts_test.expected/with details fail.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/remove_culprits_for_flaky_failures.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/swarming/staging.expected/one_fails.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/android_junit_test.expected/basic.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/use_abbreviated_revision_in_step_name.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/android_instrumentation_test.expected/basic.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/local_gtest_test.expected/retry.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/web_view_cts_test.expected/basic fail.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_null_shard.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/README.recipes.md
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/api/run_tests_on_tryserver.expected/disable_deapply_patch_affected_files.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/chromium_tests/tests/steps/generate_instrumentation_test.expected/basic.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/test_utils/api.py
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipe_modules/swarming/examples/full.expected/gtest_with_many_failures.json
[modify] https://crrev.com/5cc86a6317da2ca37d30e3d0e0eb806508863e87/scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json

Comment 9 by martiniss@chromium.org, Jan 17 (5 days ago)

Status: Fixed (was: Assigned)
This is technically done. Not sure if it's the best solution, but I think anything more complicated would need better UI support than buildbot gives us right now.

Sign in to add a comment