New issue
Advanced search Search tips

Issue 912671 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

one-click unelide doesn't unelide path

Project Member Reported by emilyschechter@chromium.org, Dec 6

Issue description

Chrome Version: Version 73.0.3632.0 (Official Build) canary (64-bit)
OS: macOS high sierra 10.13.6

What steps will reproduce the problem?
(1)chrome://flags/#omnibox-ui-hide-steady-state-url-path-query-and-ref enabled
(2)chrome://flags/#omnibox-ui-one-click-unelide enabled
(3)click into omnibox

What is the expected result? path is unelided

What happens instead? path still hidden



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 

Comment 1 Deleted

Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
I can reproduce this now on multiple platforms.

It occurs when the path is elided and the scheme is not elided.

I'll start investigating this more in detail.


Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08b8d537e186b187b97fbb519270f44cf4dd7c7

commit e08b8d537e186b187b97fbb519270f44cf4dd7c7
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Dec 12 18:16:45 2018

Omnibox: Fix one-click unelide when scheme elision is disabled

Previously, the UnapplySteadyStateElisions method had a wrong early
exit for when ONLY the path was elided.

This CL removes that early exit and replaces it with a more robust
check.

Bug: 912671
Change-Id: I1046d54c678a560f1562ff375aba134c1ad01627
Reviewed-on: https://chromium-review.googlesource.com/c/1372849
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615966}
[modify] https://crrev.com/e08b8d537e186b187b97fbb519270f44cf4dd7c7/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/e08b8d537e186b187b97fbb519270f44cf4dd7c7/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

Sign in to add a comment