New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 36 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 912640


Show other hotlists

Hotlists containing this issue:
Chromium-bugs-related-to-Crostini


Sign in to add a comment
link

Issue 912638: Implement export and import for crostini container

Reported by joelhockey@chromium.org, Dec 6 Project Member

Issue description

PRD: http://go/crostini-backup

Implement chrome changes for crostini container export and import.
 

Comment 1 by joelhockey@chromium.org, Dec 6

Blockedon: 912640

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 7 by joelhockey@chromium.org, Jan 11

Status: Started (was: Assigned)

Comment 8 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab245ef73de869bc70da32b477f05ad6054771b

commit 6ab245ef73de869bc70da32b477f05ad6054771b
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 17 03:45:05 2019

Return container_path from CrostiniSharePath

This field is used after sharing path to then determine what the
backup path will be for tremplin running in termina.

Bug:  912638 
Change-Id: I9c9b4a36b17015cfb8c13746898a49ad8788e63d
Reviewed-on: https://chromium-review.googlesource.com/c/1414253
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623561}
[modify] https://crrev.com/6ab245ef73de869bc70da32b477f05ad6054771b/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/6ab245ef73de869bc70da32b477f05ad6054771b/chrome/browser/chromeos/crostini/crostini_share_path.h
[modify] https://crrev.com/6ab245ef73de869bc70da32b477f05ad6054771b/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Comment 9 by tbuck...@chromium.org, Jan 17

Labels: Proj-Containers

Comment 10 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f56632eaf91d1e0a746a59bf9b412c7de6de1f86

commit f56632eaf91d1e0a746a59bf9b412c7de6de1f86
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Jan 21 02:52:52 2019

Use seneschal SharePathResponse.path rather than generating independently

This is what I should have done in the most recent
crosreview.com/1414253

Bug:  912638 
Change-Id: I14abec116ed195333be5b5def5e1638c0f214885
Reviewed-on: https://chromium-review.googlesource.com/c/1424521
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624511}
[modify] https://crrev.com/f56632eaf91d1e0a746a59bf9b412c7de6de1f86/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/f56632eaf91d1e0a746a59bf9b412c7de6de1f86/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc

Comment 11 by bugdroid, Jan 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/58d7948d1c13bc682c93d452a0c484af7808b378

commit 58d7948d1c13bc682c93d452a0c484af7808b378
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Jan 23 18:47:32 2019

vm_tools: seneschal: Fix SharePathResponse.path to be relative not absolute

Currently seneschal SharePath is returning absolute paths such as
/MyFiles/Downloads/shared.  These paths should be relative without the
leading slash.

BUG= chromium:912638 
TEST=local device

Change-Id: I65041d364f6859050440fbf058b80bec8360a3ae
Reviewed-on: https://chromium-review.googlesource.com/1423879
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/58d7948d1c13bc682c93d452a0c484af7808b378/vm_tools/seneschal/service.cc

Comment 12 Deleted

Comment 13 Deleted

Comment 14 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/522345ad41fdea410c7f35e5b98ed857dc4c4b00

commit 522345ad41fdea410c7f35e5b98ed857dc4c4b00
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 24 22:33:22 2019

tremplin: add ExportLxdContainer

BUG= chromium:912638 
TEST=local device
CQ-DEPEND=CL:1420438

Change-Id: I92734853b2d8773f0e892a24c90dc2892ff1b101
Reviewed-on: https://chromium-review.googlesource.com/1420421
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/522345ad41fdea410c7f35e5b98ed857dc4c4b00/src/chromiumos/tremplin/tremplin.go

Comment 15 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/9a9fab4ae4e84b1c819aa8b8790846af52280117

commit 9a9fab4ae4e84b1c819aa8b8790846af52280117
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 24 22:33:22 2019

tremplin: add ImportLxdContainer

BUG= chromium:912638 
TEST=local device
CQ-DEPEND=CL:1426540

Change-Id: I054de1c19813a5d1d1a8aff51908a182fce10699
Reviewed-on: https://chromium-review.googlesource.com/1426261
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/9a9fab4ae4e84b1c819aa8b8790846af52280117/src/chromiumos/tremplin/tremplin.go

Comment 16 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/389aeea1ca51e8f297cea4b08a2c7b0d33fbb520

commit 389aeea1ca51e8f297cea4b08a2c7b0d33fbb520
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 24 22:33:20 2019

vm_tools: tremplin proto: ExportContainer

BUG= chromium:912638 
BUG= chromium:912640 
TEST=local device
CQ-DEPEND=CL:1420421

Change-Id: I0df05d615048fe29d37ecdb97f9297b88cf45f90
Reviewed-on: https://chromium-review.googlesource.com/1420438
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/389aeea1ca51e8f297cea4b08a2c7b0d33fbb520/vm_tools/proto/tremplin.proto

Comment 18 by bugdroid, Jan 24

Project Member

Comment 19 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c1d1840bc874f1c429526f277c064f89cd15ddc2

commit c1d1840bc874f1c429526f277c064f89cd15ddc2
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Jan 24 22:33:21 2019

vm_tools: tremplin proto: ImportContainer

BUG= chromium:912638 
TEST=local device
CQ-DEPEND=CL:1426261

Change-Id: Ifc50892fd731c5115c3d3813abafe04512dac003
Reviewed-on: https://chromium-review.googlesource.com/1426540
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/c1d1840bc874f1c429526f277c064f89cd15ddc2/vm_tools/proto/tremplin.proto

Comment 21 by bugdroid, Jan 24

Project Member

Comment 22 by bugdroid, Feb 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/41639f3d4a0db34de9c5d7b78ef9941335d320b6

commit 41639f3d4a0db34de9c5d7b78ef9941335d320b6
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Feb 02 09:19:16 2019

tremplin: Add better progress tracking

BUG= chromium:912638 
TEST=local device

Change-Id: Ibd2b147ea973ebc1a20a05cc79e21742be3f4898
Reviewed-on: https://chromium-review.googlesource.com/1447433
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/41639f3d4a0db34de9c5d7b78ef9941335d320b6/src/chromiumos/tremplin/tremplin.go

Comment 23 by bugdroid, Feb 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/300b444238ba425074372009d23e8bd598eb3af8

commit 300b444238ba425074372009d23e8bd598eb3af8
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Feb 02 09:19:16 2019

system_api: Update export/import progress tracking stages

Added separate stages for export and import progress tracking.
Note: It is OK to change proto numbering since there is no
client implemented yet to use these.

BUG= chromium:912638 
TEST=local device
CQ-DEPEND=CL:1447433

Change-Id: I449c58737bf7dbcb4400d33bb2896f1b917485c7
Reviewed-on: https://chromium-review.googlesource.com/1446077
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/300b444238ba425074372009d23e8bd598eb3af8/vm_tools/cicerone/tremplin_listener_impl.cc
[modify] https://crrev.com/300b444238ba425074372009d23e8bd598eb3af8/vm_tools/proto/tremplin.proto
[modify] https://crrev.com/300b444238ba425074372009d23e8bd598eb3af8/system_api/dbus/vm_cicerone/cicerone_service.proto
[modify] https://crrev.com/300b444238ba425074372009d23e8bd598eb3af8/vm_tools/cicerone/virtual_machine.h

Comment 24 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7ce930a69d9286f41518b5de6f748c0c1b4393d

commit f7ce930a69d9286f41518b5de6f748c0c1b4393d
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Feb 06 08:04:57 2019

Add crostini ExportLxdContainer and ImportLxdContainer

Callers can have only 1 outstanding call to Export or Import.
Any calls in progress are cancelled when VM stops.

Bug:  912638 
Change-Id: Iccff5027c0dfadd22fc269016f9d84e4de1b2804
Reviewed-on: https://chromium-review.googlesource.com/c/1436462
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629496}
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chromeos/dbus/cicerone_client.cc
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chromeos/dbus/cicerone_client.h
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chromeos/dbus/fake_cicerone_client.cc
[modify] https://crrev.com/f7ce930a69d9286f41518b5de6f748c0c1b4393d/chromeos/dbus/fake_cicerone_client.h

Comment 25 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/ed02c3a9b5c2612e102a0b494a45f3be927b6237

commit ed02c3a9b5c2612e102a0b494a45f3be927b6237
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Feb 06 16:31:59 2019

tremplin: metadata progress and export_path

* Use updated lxd metadata fields for progress
* Support export_path as either directory
  or file.

BUG= chromium:912638 
TEST=local device

Change-Id: Icd89ac7815774d7aa9cd597e0dbd0b7a163f5635
Reviewed-on: https://chromium-review.googlesource.com/1454000
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/ed02c3a9b5c2612e102a0b494a45f3be927b6237/src/chromiumos/tremplin/tremplin.go

Comment 26 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ec9598a88d4d6c51084465edfdb95abf3d40220a

commit ec9598a88d4d6c51084465edfdb95abf3d40220a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Feb 06 16:32:01 2019

system_api: update doc for export_path

If export_path is an existing directory, then image is created as
<export_path>/<fingerprint>.tar.gz, otherwise given path is
created as a new file for the exported image.

BUG= chromium:912638 
TEST=none

Change-Id: Ia1990f5e9da550a5aae7d43ee56770d19274276c
Reviewed-on: https://chromium-review.googlesource.com/1454444
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/ec9598a88d4d6c51084465edfdb95abf3d40220a/vm_tools/proto/tremplin.proto
[modify] https://crrev.com/ec9598a88d4d6c51084465edfdb95abf3d40220a/system_api/dbus/vm_cicerone/cicerone_service.proto

Comment 27 by bugdroid, Feb 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/4b6641eb801a74509a6fab6c936441d2a134d28c

commit 4b6641eb801a74509a6fab6c936441d2a134d28c
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Feb 09 03:13:49 2019

tremplin: replace tar, compress stages with unpack

BUG= chromium:912638 
TEST=local device
CQ-DEPEND=CL:1457500,CL:1457957

Change-Id: I33a2a7a64f10c3ca6f6b9dec3baf8d2a5174a334
Reviewed-on: https://chromium-review.googlesource.com/1457259
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/4b6641eb801a74509a6fab6c936441d2a134d28c/src/chromiumos/tremplin/tremplin.go

Comment 28 by bugdroid, Feb 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b426cfbca9a54785cf425fbb8a09dac6e247cdf9

commit b426cfbca9a54785cf425fbb8a09dac6e247cdf9
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Feb 09 03:13:48 2019

system_api: add export pack stage

BUG= chromium:912638 
TEST=local device

Change-Id: I56f1ed82e14dd1a3b65e2ef8694e2a45ae948a4f
Reviewed-on: https://chromium-review.googlesource.com/1457500
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/b426cfbca9a54785cf425fbb8a09dac6e247cdf9/vm_tools/proto/tremplin.proto
[modify] https://crrev.com/b426cfbca9a54785cf425fbb8a09dac6e247cdf9/system_api/dbus/vm_cicerone/cicerone_service.proto

Comment 30 by joelhockey@chromium.org, Feb 13 (6 days ago)

Current UI for export and import.
* Settings page
* Export notification
* Import notification
Screenshot 2019-02-13 at 07.35.29.png
845 KB View Download
Screenshot 2019-02-12 at 19.32.52.png
70.1 KB View Download
Screenshot 2019-02-12 at 19.25.47.png
86.1 KB View Download

Comment 31 by joelhockey@chromium.org, Feb 14 (6 days ago)

Updated UI after discussion with Sudha
Screenshot 2019-02-14 at 11.58.52.png
612 KB View Download

Comment 32 by dpa...@chromium.org, Feb 14 (6 days ago)

Cc: wlarsen@chromium.org
+wlarsen as WebUI UX to take a look.

@wlarsen: Do you have any thoughts on the proposed screenshot at comment#30 (see "Backup" and "Restore" rows). Also note attached screenshots of a few other cases where a button shows up within a settings row (sometimes with a separator and sometimes without any).
button_in_settings_box.png
11.4 KB View Download
button_in_settings_box2.png
4.3 KB View Download
button_in_settings_box3.png
8.4 KB View Download

Comment 33 by joelhockey@chromium.org, Feb 14 (6 days ago)

Change to "Backup & restore" header
Screenshot 2019-02-14 at 18.00.26.png
611 KB View Download

Comment 34 by sbroslawsky@chromium.org, Feb 14 (5 days ago)

Hey Joel, Thanks for the quick changes yesterday. Please find mocks for backup & restore flag proposal here go/crostini-backup-and-restore-design. Also attaching screenshots here. Thanks
Linux-Restore-Notifications.png
43.4 KB View Download
Linux-Backup-Notifications.png
43.5 KB View Download
settings-linux-screen-w-backup-and-restore-flag-1.png
85.4 KB View Download

Comment 35 by bugdroid, Feb 14 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c89712e74bf9b8292d6fb23ee1605e4ceef02287

commit c89712e74bf9b8292d6fb23ee1605e4ceef02287
Author: Joel Hockey <joelhockey@chromium.org>
Date: Thu Feb 14 21:40:25 2019

Add CrostiniExportImportUIAllowed user policy

CrostiniExportImportUIAllowed is a user policy that controls
whether the export / import UI is shown to a user where
they can export and import container images in crostini.

Bug:  912638 

Change-Id: Ia28d1d43ca5bfbb047c6f870a1de7b4d46605fe8
Reviewed-on: https://chromium-review.googlesource.com/c/1468223
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632374}
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/chrome/browser/chromeos/crostini/crostini_pref_names.cc
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/chrome/browser/chromeos/crostini/crostini_pref_names.h
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/components/policy/resources/policy_templates.json
[modify] https://crrev.com/c89712e74bf9b8292d6fb23ee1605e4ceef02287/tools/metrics/histograms/enums.xml

Comment 36 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a08bc009431b6b700533d89dd26ad26df431cb

commit f8a08bc009431b6b700533d89dd26ad26df431cb
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Feb 15 03:53:29 2019

crostini export with notifications

Exposes export and import functions which control
File dialog chooser to select file for export/import
and displays notification with progress.

BUG= 912638 

Change-Id: I7b5ff8151bf76f81d2483ff199ed573e42277a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1462638
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632495}
[modify] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_DONE.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_FAILED.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_IN_PROGRESS.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_TITLE.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_DONE.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_FAILED.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_IN_PROGRESS.png.sha1
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_TITLE.png.sha1
[modify] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_export_import.cc
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_export_import.h
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_export_import_notification.h
[add] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_export_import_unittest.cc
[modify] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_manager.cc
[modify] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_manager.h
[modify] https://crrev.com/f8a08bc009431b6b700533d89dd26ad26df431cb/chrome/browser/chromeos/crostini/crostini_manager_unittest.cc

Comment 37 by bugdroid, Feb 15 (5 days ago)

Project Member

Comment 38 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2a611d776397d93373e8cca99353a4e987ea1a

commit ae2a611d776397d93373e8cca99353a4e987ea1a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Feb 15 06:13:56 2019

settings: add crostini export/import

Backup and restore buttons will be shown in the
crostini details settings subpage when the CrostiniBackup
feature flag is enabled, and when this feature is not restricted
by enterprise policy.

Bug:  912638 
Change-Id: I4fb0f04a88df98343a8fa5bef84d197a59660ae2
Reviewed-on: https://chromium-review.googlesource.com/c/1470344
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632523}
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings.grdp
[add] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_EXPORT.png.sha1
[add] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_EXPORT_IMPORT_TITLE.png.sha1
[add] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_EXPORT_LABEL.png.sha1
[add] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_IMPORT.png.sha1
[add] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/app/settings_strings_grdp/IDS_SETTINGS_CROSTINI_IMPORT_LABEL.png.sha1
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/resources/settings/crostini_page/crostini_browser_proxy.js
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/resources/settings/crostini_page/crostini_subpage.html
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/resources/settings/crostini_page/crostini_subpage.js
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/ui/webui/settings/chromeos/crostini_handler.cc
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/ui/webui/settings/chromeos/crostini_handler.h
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/test/data/webui/settings/crostini_page_test.js
[modify] https://crrev.com/ae2a611d776397d93373e8cca99353a4e987ea1a/chrome/test/data/webui/settings/test_crostini_browser_proxy.js

Comment 39 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6ef08678156e50ac742827bae6aa29b3901133

commit ed6ef08678156e50ac742827bae6aa29b3901133
Author: Joel Hockey <joelhockey@chromium.org>
Date: Fri Feb 15 09:08:35 2019

Disable tests failing asan/lsan/msan

Bug:  912638 
Change-Id: I1d4b17386e64c9c82de1f3f6d0d315f32c961add

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I1d4b17386e64c9c82de1f3f6d0d315f32c961add
Reviewed-on: https://chromium-review.googlesource.com/c/1474886
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632551}
[modify] https://crrev.com/ed6ef08678156e50ac742827bae6aa29b3901133/chrome/browser/chromeos/crostini/crostini_export_import_unittest.cc

Comment 40 by bugdroid, Feb 18 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67484f8b007ffa9c8bdf9e30a9b4de23241b91d

commit a67484f8b007ffa9c8bdf9e30a9b4de23241b91d
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Feb 18 07:30:23 2019

Buttons added to an expanded view should be shown

Bug:  912638 
Change-Id: Icd9419b8483d0ce3c9dfc56d0dd62b70ba930a64
Reviewed-on: https://chromium-review.googlesource.com/c/1476876
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633035}
[modify] https://crrev.com/a67484f8b007ffa9c8bdf9e30a9b4de23241b91d/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/a67484f8b007ffa9c8bdf9e30a9b4de23241b91d/ui/message_center/views/notification_view_md_unittest.cc

Comment 42 by bugdroid, Yesterday (40 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/579fffc36a5e794433f342efa506d517b1454d52

commit 579fffc36a5e794433f342efa506d517b1454d52
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Feb 19 00:50:12 2019

Update crostini export/import notifications UI to spec

* Change destruction of notification to only happen
  after it is finally closed.  This fixes test lsan issues.
* Update strings as per UI spec.

Bug:  912638 
Change-Id: I864f28f41b6d408c8a85aa0e4bf2b7e98b5dbdd0
Reviewed-on: https://chromium-review.googlesource.com/c/1475686
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633170}
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings.grdp
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_IMPORT_NOTIFICATION_DISPLAY_SOURCE.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_MESSAGE_DONE.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_MESSAGE_FAILED.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_TITLE_DONE.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_TITLE_FAILED.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_EXPORT_NOTIFICATION_TITLE_RUNNING.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_MESSAGE_DONE.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_MESSAGE_FAILED.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_TITLE_DONE.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_TITLE_FAILED.png.sha1
[add] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/app/chromeos_strings_grdp/IDS_CROSTINI_IMPORT_NOTIFICATION_TITLE_RUNNING.png.sha1
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/browser/chromeos/crostini/crostini_export_import.cc
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/browser/chromeos/crostini/crostini_export_import.h
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/browser/chromeos/crostini/crostini_export_import_notification.h
[modify] https://crrev.com/579fffc36a5e794433f342efa506d517b1454d52/chrome/browser/chromeos/crostini/crostini_export_import_unittest.cc

Comment 43 by bugdroid, Yesterday (35 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5710c0f90b76c820c1412b1cf7b5f6182827e1a

commit d5710c0f90b76c820c1412b1cf7b5f6182827e1a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Tue Feb 19 06:06:36 2019

Add back support for deprecated export states until tremplin updates

Older versions of lxd/tremplin were doing tar/compress as separate
stages when backing up a container.  Newer versions now do that in a
single pack stage.

This CL adds back support for tar/compress until termina updates
so that these are not considered errors.

Bug:  912638 
Change-Id: I42b00f79c03bb5ffc0bba16bc53568ce6c271c5d
Reviewed-on: https://chromium-review.googlesource.com/c/1475685
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633199}
[modify] https://crrev.com/d5710c0f90b76c820c1412b1cf7b5f6182827e1a/chrome/browser/chromeos/crostini/crostini_manager.cc

Comment 44 by joelhockey@chromium.org, Today (17 hours ago)

Status: Fixed (was: Started)

Comment 45 by bugdroid, Today (17 hours ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8962309fc6f8fb4f4029273491677416b3a33c58

commit 8962309fc6f8fb4f4029273491677416b3a33c58
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Feb 20 00:06:24 2019

Crostini: Include header file instead of cc file

Instead of a header file, crostini included
chrome/browser/platform/platform_util_chromeos.cc which kind
of worked but in some builds triggered link failures later
because of duplicate symbols.

This probably works sometimes because nobody else uses the symbols
in platform_util_chromeos.o so that it is discarded before the linker
notices the duplication. Not always though.

Bug:  912638 
Change-Id: I9b96a41e20ab5362fe800b502d788c844ac4d7f2
Reviewed-on: https://chromium-review.googlesource.com/c/1477025
Auto-Submit: Daniel Bratell <bratell@opera.com>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633471}
[modify] https://crrev.com/8962309fc6f8fb4f4029273491677416b3a33c58/chrome/browser/chromeos/crostini/crostini_export_import_notification.cc

Sign in to add a comment