org.chromium.content.browser.BrowserStartupControllerTest failing consistenly on android-marshmallow-arm64-rel |
||
Issue descriptionSee the last few builds of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester eg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/25230 This is also blocking some CQ runs: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/145420 This appears to have started with https://chromium-review.googlesource.com/c/chromium/src/+/1355244, which looks pretty culpable. Assigning to author of CL.
,
Dec 6
It does caused by my cl, will it ok if I send a fix to review soon?
,
Dec 6
If it is urgent, I am okay to revert my cl.
,
Dec 6
A fix by eod would be fine I think
,
Dec 6
I would revert. This is causing persistent retries in the CQ. Patches are only landing because this test fails both before and after the CL. See https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel?limit=100 and search for "failure content_shell"
,
Dec 6
I have a fix WIP, but failed on "git cl upload". Let me try one more time.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03089e2445101e1a2dce3b89262abfdb107def6f commit 03089e2445101e1a2dce3b89262abfdb107def6f Author: Xi Han <hanxi@google.com> Date: Fri Dec 07 01:15:25 2018 Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android. The crash is caused due to junit test BrowserStartupControllerTest doesn't initialize the native but call serviceManagerStartupComplete. In that function, we record startup metrics and failed due to native doesn't initialized. Therefore, we add a protect function for the metrics record and override it in the TestBrowserStartupController. Bug: 912619 Change-Id: Ifa6ba36bc926f0f033f7df0f4e6a67fce0ca340f Reviewed-on: https://chromium-review.googlesource.com/c/1366717 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614537} [modify] https://crrev.com/03089e2445101e1a2dce3b89262abfdb107def6f/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java [modify] https://crrev.com/03089e2445101e1a2dce3b89262abfdb107def6f/content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java
,
Dec 7
Issue 912792 has been merged into this issue.
,
Dec 7
|
||
►
Sign in to add a comment |
||
Comment 1 by bpastene@chromium.org
, Dec 6