New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js

Sign in to add a comment

Issue 912614: http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js is flaky

Reported by Findit, Dec 6 Project Member

Issue description

Comment 1 by, Dec 6

Components: Platform>DevTools>JavaScript
Status: Assigned (was: Untriaged)

Comment 2 by, Dec 7

Project Member
The following revision refers to this bug:

commit 957b034333640c832f432f6d9cdb2f3ef260fd5b
Author: Jeffrey Yasskin <>
Date: Fri Dec 07 01:19:44 2018

Revert "Change interleaving of delayed and immediate tasks to match MessageLoop"

This reverts commit dda57a2c6aa319675172f8558ce8c24d9333f894.

Reason for revert: Made http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js flaky, according to

Original change's description:
> Change interleaving of delayed and immediate tasks to match MessageLoop
> Previously the TaskQueueSelector would allow up to 3 delayed tasks to
> run for every immediate task if both where ready to run.  This patch
> changes it to a 1:1 ratio like the MessageLoop.  NB neither the
> SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
> of immediate tasks.
> In addition I've removed the PrioritizingSelector inner class which makes
> the code a bit more readable.  In addition based on review comments I
> changed the style of functions to return a pointer to the WorkQueue or
> null rather than a bool. This in general improves readability.
> Bug: 863341, 891670
> Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
> Reviewed-on:
> Commit-Queue: Alex Clarke <>
> Reviewed-by: Sami Kyöstilä <>
> Reviewed-by: Alexander Timin <>
> Cr-Commit-Position: refs/heads/master@{#614329},,

Change-Id: I2b92bee12bfdd05fac12955655106253cab0d1e6
No-Presubmit: true
Bug: 863341, 891670, 912614
Reviewed-by: Jeffrey Yasskin <>
Commit-Queue: Jeffrey Yasskin <>
Cr-Commit-Position: refs/heads/master@{#614545}

Comment 3 by, Dec 7

Labels: -Sheriff-Chromium

Sign in to add a comment