New issue
Advanced search Search tips

Issue 912612 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
robertma@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1365716

 
WPT import https://crrev.com/c/1365716 introduced new failures in external/wpt/svg:

List of new failures:
external/wpt/svg/interact/scripted/tabindex-focus-flag.svg new failing tests: https://crrev.com/c/1365716/4/third_party/blink/web_tests/external/wpt/svg/interact/scripted/tabindex-focus-flag-expected.txt

This import contains upstream changes from 0347da3996b8eb6c4aef1104291efcc5d5356e6d to 6185fc083a08ea74f0ddfffff917321fb6ffa42d:
Remove support for the timeout from testharness.js (#14309): https://github.com/web-platform-tests/wpt/commit/6185fc083a08ea74f0ddfffff917321fb6ffa42d
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=189727: https://github.com/web-platform-tests/wpt/commit/3417cb335d4b66341e46ca7807452d9989fb6603
Rename MojoLayoutTestHelper to MojoWebTestHelper: https://github.com/web-platform-tests/wpt/commit/168da207d9cfb10b74f4e803eef8fc451c940c8f
Update interfaces/web-nfc.idl (#14388): https://github.com/web-platform-tests/wpt/commit/93af5d942ef1296666b426d33fcf4ac085ba5828
Tests for SVG tabindex/focus/blur (#10149): https://github.com/web-platform-tests/wpt/commit/4bdeca6b451519a7f60f592468600e0a6cbfc42b
Add link to CSS Overscroll behavior spec.: https://github.com/web-platform-tests/wpt/commit/0d02fc966c4f4cccd4cb457f1fa7289597f58af2
Move overscrollBehavior-manual.html into css/css-overscroll-behavior: https://github.com/web-platform-tests/wpt/commit/6608f666fa8cc9d571f324f71a8c13608063313a
Merge remote-tracking branch 'origin/master' into HEAD: https://github.com/web-platform-tests/wpt/commit/2d667581b4fa73a0c537b3851fb4eb8d7ad31458
Merge remote-tracking branch 'origin/master' into HEAD: https://github.com/web-platform-tests/wpt/commit/fc26f1ed7fb473a754eb051165e8ae1613527bc0
Respond to feedback: https://github.com/web-platform-tests/wpt/commit/212e293791cbe0a530807138a1bd16d3109a5512 [affecting this directory]
Add focus composed test: https://github.com/web-platform-tests/wpt/commit/4fae1e45c3892f37065a107124e31d60b10b3c7b [affecting this directory]
Add focus management test: https://github.com/web-platform-tests/wpt/commit/61541008a50f6c764a0994855e2efaf72ac62787 [affecting this directory]
Add test for default tabIndex value: https://github.com/web-platform-tests/wpt/commit/f34c9d561c77e900d3f799f7d5cb4482d94b2d6a [affecting this directory]
Update focus-flag test: https://github.com/web-platform-tests/wpt/commit/6ed5ec3986a272b1cc03ff174e5eb07593d75bef [affecting this directory]
Add test for SVG focus flag: https://github.com/web-platform-tests/wpt/commit/1def233a8f38a8415368eb86877557146401ebd0 [affecting this directory]

Comment 1 by f...@opera.com, Dec 7

Labels: Pri-3 Type-Bug
Status: Available (was: Untriaged)
These look mostly as expected I think:

'focusable' not supported, and we should probably not add support for it. (All the failures with [focusable*].)

We don't focus elements which don't have computed style (not in the layout tree in practice). (The test with 'mesh', 'unknown', 'iframe', etc.)

The one failure that might warrant some investigation is:

FAIL The document root element should be focusable.

Since I don't think document.activeElement ought to return null there. (I'm not sure that test is necessarily testing what it sets out to though - i.e even if focusing the root fails, document.activeElement would still return the root.)
►

Sign in to add a comment