New issue
Advanced search Search tips

Issue 912570 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Dec 12
Cc:
rogerm@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

virtual/.../overlays-persist-on-navigation.html in not_site_per_process_webkit_layout_tests failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 6 
Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rogerm@chromium.org

virtual/.../overlays-persist-on-navigation.html in not_site_per_process_webkit_layout_tests failing on multiple builders

Builders failed on: 
- Linux Tests: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f668bb5e368b109bd420c2525055ffbd6de3f064

commit f668bb5e368b109bd420c2525055ffbd6de3f064
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Dec 06 17:10:19 2018

[sheriff] Update TestExpectations for flaky layout test

compositing/visibility/overlays-persist-on-navigation.html

TBR: jyasskin@chromium.org
Bug:  912570 
Change-Id: Iab922b37a9081c3b0a83490e738bda1d03cf24d3
Reviewed-on: https://chromium-review.googlesource.com/c/1365715
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614390}
[modify] https://crrev.com/f668bb5e368b109bd420c2525055ffbd6de3f064/third_party/blink/web_tests/TestExpectations

Comment 2 by rogerm@chromium.org, Dec 6

Owner: tkent@chromium.org
tkent@, plz route this to an appropriate owner for investigation, thanks!

Comment 3 by johnidel@chromium.org, Dec 6

Cc: johnidel@chromium.org
Caused by https://chromium-review.googlesource.com/c/chromium/src/+/1352471
FindIt doesn't seem to have created a new bug.

Comment 4 by tkent@chromium.org, Dec 7

Cc: -johnidel@chromium.org
Components: Blink>Paint
Owner: johnidel@chromium.org
Status: Assigned (was: Available)

Comment 5 by fhorschig@chromium.org, Dec 11

Labels: -Sheriff-Chromium Type-Bug
Expectations are updated and owner is assigned --> Remove from sheriff queue

Comment 6 by johnidel@chromium.org, Dec 11

Owner: wangxianzhu@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/674591d696ee953056168b122e14b01df290a3fb

commit 674591d696ee953056168b122e14b01df290a3fb
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Wed Dec 12 20:51:12 2018

[FrameColorOverlay] Move FrameOverlay from LocalFrameView to LocalFrame

We need to persist main frame overlay across page navigations [1].
LocalFrameView doesn't persist across same origin page navigations,
while LocalFrame does, so FrameOverlay should be managed by
LocalFrame.

The test happened to pass with FrameOverlay in LocalFrameView because
the GraphicsLayer created by the FrameOverlay for the previous
LocalFrameView was left in the graphics layer tree. Actually this is
an unwanted memory leak. The new LocalFrameView may create its own
FrameOverlay resulting two overlay GraphicsLayers in the graphics
layer tree.

This CL fixes the leak bug. It's also needed by ComposteAfterPaint
which doesn't use GraphicsLayer.

Also set correct property tree state when painting frame overlays.
This is important for subframes to paint the overlay at the correct
place in the overlay layer.

[1] compositing/visibility/overlays-persist-on-navigation.html

Bug:  912570 
Change-Id: Ib458b6fa374aa25478ce52da1226a0c43df7d1ef
Reviewed-on: https://chromium-review.googlesource.com/c/1372723
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616029}
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/frame/frame_overlay.cc
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/frame/local_frame.cc
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/frame/local_frame.h
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/renderer/core/frame/local_frame_view.h
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/TestExpectations
[add] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/overlays-persist-on-navigation-expected-mismatch.html
[modify] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/overlays-persist-on-navigation-expected.html
[add] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/overlays-removed-after-navigation-expected-mismatch.html
[add] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/overlays-removed-after-navigation-expected.html
[add] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/overlays-removed-after-navigation.html
[add] https://crrev.com/674591d696ee953056168b122e14b01df290a3fb/third_party/blink/web_tests/compositing/visibility/resources/overlays-removed-after-navigation-page2.html

Comment 8 by wangxianzhu@chromium.org, Dec 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment