New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 912567 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Hitting DCHECK in AutofillWalletMetadataSyncableService::CreditCardChanged

Project Member Reported by ftirelo@chromium.org, Dec 6

Issue description

This is happening right after startup on ToT. I changed the value of change.type() is AutofillProfileChange::ADD.

[231960:232082:1206/100143.735239:FATAL:autofill_wallet_metadata_syncable_service.cc(570)] Check failed: change.type() == AutofillProfileChange::UPDATE. 
#0 0x7fbab807630d base::debug::StackTrace::StackTrace()
#1 0x7fbab7d66d3a base::debug::StackTrace::StackTrace()
#2 0x7fbab7dd8a4b logging::LogMessage::~LogMessage()
#3 0x555c64274201 autofill::AutofillWalletMetadataSyncableService::CreditCardChanged()
#4 0x555c6428e1fc autofill::AutofillWebDataBackendImpl::NotifyOfCreditCardChanged()
#5 0x555c656c459d autofill::AutofillWalletSyncBridge::SetWalletCards()
#6 0x555c656beeee autofill::AutofillWalletSyncBridge::SetSyncData()
#7 0x555c656be56a autofill::AutofillWalletSyncBridge::MergeSyncData()
#8 0x555c656bfb40 autofill::AutofillWalletSyncBridge::MergeSyncData()
#9 0x555c63036009 syncer::ClientTagBasedModelTypeProcessor::OnFullUpdateReceived()
#10 0x555c630407bf syncer::ClientTagBasedModelTypeProcessor::OnUpdateReceived()
#11 0x555c5f814c5f _ZN4base8internal13FunctorTraitsIMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEEvE6InvokeISC_RKNS_7WeakPtrIS3_EEJS6_SA_EEEvT_OT0_DpOT1_
#12 0x555c5f814bb5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEERKNS_7WeakPtrIS5_EEJS8_SC_EEEvOT_OT0_DpOT1_
#13 0x555c6305c13d _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunImplISI_NS9_5tupleIJSK_S6_SE_EEEJLm0ELm1ELm2EEEEvOT_OT0_NS9_16integer_sequenceImJXspT1_EEEE
#14 0x555c6305bff9 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#15 0x7fbab7d1641e _ZNO4base12OnceCallbackIFvvEE3RunEv
#16 0x7fbab7d68302 base::debug::TaskAnnotator::RunTask()
#17 0x7fbab7f97c77 base::internal::TaskTracker::RunOrSkipTask()
#18 0x7fbab80b0bbb base::internal::TaskTrackerPosix::RunOrSkipTask()
#19 0x7fbab7f9597b base::internal::TaskTracker::RunAndPopNextTask()
#20 0x7fbab7f79bc5 base::internal::SchedulerWorker::RunWorker()
#21 0x7fbab7f794fc base::internal::SchedulerWorker::RunSharedWorker()
#22 0x7fbab7f793fd base::internal::SchedulerWorker::ThreadMain()
#23 0x7fbab80b20cd base::(anonymous namespace)::ThreadFunc()
#24 0x7fba8be27494 start_thread
#25 0x7fba87c82a8f clone

Received signal 6
#0 0x7fbab807630d base::debug::StackTrace::StackTrace()
#1 0x7fbab7d66d3a base::debug::StackTrace::StackTrace()
#2 0x7fbab8075d5a base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fba8be310c0 <unknown>
#4 0x7fba87bccfcf gsignal
#5 0x7fba87bce3fa abort
#6 0x7fbab8075506 base::debug::(anonymous namespace)::DebugBreak()
#7 0x7fbab80754e8 base::debug::BreakDebugger()
#8 0x7fbab7dd9861 logging::LogMessage::~LogMessage()
#9 0x555c64274201 autofill::AutofillWalletMetadataSyncableService::CreditCardChanged()
#10 0x555c6428e1fc autofill::AutofillWebDataBackendImpl::NotifyOfCreditCardChanged()
#11 0x555c656c459d autofill::AutofillWalletSyncBridge::SetWalletCards()
#12 0x555c656beeee autofill::AutofillWalletSyncBridge::SetSyncData()
#13 0x555c656be56a autofill::AutofillWalletSyncBridge::MergeSyncData()
#14 0x555c656bfb40 autofill::AutofillWalletSyncBridge::MergeSyncData()
#15 0x555c63036009 syncer::ClientTagBasedModelTypeProcessor::OnFullUpdateReceived()
#16 0x555c630407bf syncer::ClientTagBasedModelTypeProcessor::OnUpdateReceived()
#17 0x555c5f814c5f _ZN4base8internal13FunctorTraitsIMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEEvE6InvokeISC_RKNS_7WeakPtrIS3_EEJS6_SA_EEEvT_OT0_DpOT1_
#18 0x555c5f814bb5 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN18OAuth2TokenService11RequestImplEFvRK22GoogleServiceAuthErrorRKN25OAuth2AccessTokenConsumer13TokenResponseEERKNS_7WeakPtrIS5_EEJS8_SC_EEEvOT_OT0_DpOT1_
#19 0x555c6305c13d _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunImplISI_NS9_5tupleIJSK_S6_SE_EEEJLm0ELm1ELm2EEEEvOT_OT0_NS9_16integer_sequenceImJXspT1_EEEE
#20 0x555c6305bff9 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer18ModelTypeProcessorEFvRKN7sync_pb14ModelTypeStateERKNSt3__16vectorINS3_18CommitResponseDataENS9_9allocatorISB_EEEEEJNS_7WeakPtrIS4_EES6_SE_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#21 0x7fbab7d1641e _ZNO4base12OnceCallbackIFvvEE3RunEv
#22 0x7fbab7d68302 base::debug::TaskAnnotator::RunTask()
#23 0x7fbab7f97c77 base::internal::TaskTracker::RunOrSkipTask()
#24 0x7fbab80b0bbb base::internal::TaskTrackerPosix::RunOrSkipTask()
#25 0x7fbab7f9597b base::internal::TaskTracker::RunAndPopNextTask()
#26 0x7fbab7f79bc5 base::internal::SchedulerWorker::RunWorker()
#27 0x7fbab7f794fc base::internal::SchedulerWorker::RunSharedWorker()
#28 0x7fbab7f793fd base::internal::SchedulerWorker::ThreadMain()
#29 0x7fbab80b20cd base::(anonymous namespace)::ThreadFunc()
#30 0x7fba8be27494 start_thread
#31 0x7fba87c82a8f clone

 
Oh, sorry for not reacting. This bug slipped through the cracks :|

Luckily, the code seems okay even if change.type() is ADD. Still, it should not happen. I have since independently fixed one bug that could have caused this situation (https://chromium-review.googlesource.com/c/chromium/src/+/1373449)

Has it reproed for you recently?

Sign in to add a comment