New issue
Advanced search Search tips

Issue 912559 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Update String "Manage Credit Cards..." Autofill Manual Fallback

Project Member Reported by martijnb@chromium.org, Dec 6

Issue description

Update String "Manage Credit Cards..." Autofill Manual Fallback

String should be:
"Manage Payment Methods..."
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6439f61a49e3f574d554bd89ab0461175791b5b1

commit 6439f61a49e3f574d554bd89ab0461175791b5b1
Author: David Jean <djean@google.com>
Date: Mon Dec 10 12:44:16 2018

[ios] Renamed manual fallback “manage credit cards” action

Bug:  912559 
Change-Id: I878ed2595d0a2bdb79fda4fb498dfac7c168d80e
Reviewed-on: https://chromium-review.googlesource.com/c/1369791
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615097}
[modify] https://crrev.com/6439f61a49e3f574d554bd89ab0461175791b5b1/ios/chrome/app/strings/ios_strings.grd

Labels: Merge-Request-72
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 10

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 49 days from stable.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)
Cc: gov...@chromium.org kariahda@chromium.org
Hi djean, this CL has string changes and string freeze is the same date as feature freeze for a given milestone. See doc here: https://docs.google.com/document/d/1FIjPQYKYeR6ALQgQHgI5KWGPzDhBHtYzKFcFqXH11ow/edit#heading=h.wsee0g2xyca4

This request will require special approval from govind@.
djean: Does this absolutely need to make M72? String freeze for M72 was November 9, so we are a month+ past that deadline. "Changing strings after Branch point requires manual overhead and provides translators with less time to complete translations."
https://docs.google.com/document/d/1FIjPQYKYeR6ALQgQHgI5KWGPzDhBHtYzKFcFqXH11ow/edit#heading=h.wsee0g2xyca4

Please give reasoning why this is necessary for M72. If not, we'll just have this fixed in M73.
Cc: -javierrobles@chromium.org djean@chromium.org
Owner: javierrobles@chromium.org
Javier?
This can wait for M-73
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Rejected-72
Ok thanks, Javier.

Sign in to add a comment