New issue
Advanced search Search tips

Issue 912557 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile list_thumbnail_loader_unittest.html

Project Member Reported by noel@chromium.org, Dec 6

Issue description

- remove the current html unittest
- closure compile the code and the unittest

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/454a4f0cb9c837740bbb0bb1f07809728f98f4a6

commit 454a4f0cb9c837740bbb0bb1f07809728f98f4a6
Author: Noel Gordon <noel@chromium.org>
Date: Thu Dec 06 15:36:11 2018

Closure compile list_thumbnail_loader_unittest

 - remove list_thumbnail_loader_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - add @types to the unittest vars
 - inline the canvas dataURL image creation step in Setup()
 - fix all Closure compiler errors

No change in test behavior, no new tests.

Bug:  912557 
Change-Id: I157b0c1ef56704901e760e6f5125e4e05ea76377
Reviewed-on: https://chromium-review.googlesource.com/c/1364999
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614362}
[modify] https://crrev.com/454a4f0cb9c837740bbb0bb1f07809728f98f4a6/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/454a4f0cb9c837740bbb0bb1f07809728f98f4a6/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/15bf688046abf6202ae6151e2459409060b9def6/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
[modify] https://crrev.com/454a4f0cb9c837740bbb0bb1f07809728f98f4a6/ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment