Vertical Center Search Box "Use Other Password" Manual Fallback |
|||||||
Issue descriptionWhen focusing the Search field: Vertical Center Search Box "Use Other Password" Manual Fallback
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e83dbb375025234a1ff532a5f078eaafc66eb0c3 commit e83dbb375025234a1ff532a5f078eaafc66eb0c3 Author: David Jean <djean@google.com> Date: Mon Dec 10 13:39:21 2018 [ios] Fixed search bar vertical centering for manual fallback passwords Applied fix from https://crrev.com/c/1219002 Before: https://drive.google.com/open?id=1AGNo9K6UaSiFfiUuwv66kWUaUjuO2EzZ After: https://drive.google.com/open?id=1HakPAtC3Kmsk97xAMhOqzlfmipWEGMg5 Bug: 912527 Change-Id: I0d006ce240afc9d3ac7c50bd25447a3a918f8f01 Reviewed-on: https://chromium-review.googlesource.com/c/1369777 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#615106} [modify] https://crrev.com/e83dbb375025234a1ff532a5f078eaafc66eb0c3/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
,
Dec 10
,
Dec 10
,
Dec 11
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc483fd1aeb0a77574a9f9ecb8f71ef2e0fd7884 commit bc483fd1aeb0a77574a9f9ecb8f71ef2e0fd7884 Author: David Jean <djean@google.com> Date: Tue Dec 11 14:18:21 2018 [ios] Fixed search bar vertical centering for manual fallback passwords Applied fix from https://crrev.com/c/1219002 Before: https://drive.google.com/open?id=1AGNo9K6UaSiFfiUuwv66kWUaUjuO2EzZ After: https://drive.google.com/open?id=1HakPAtC3Kmsk97xAMhOqzlfmipWEGMg5 Bug: 912527 Change-Id: I0d006ce240afc9d3ac7c50bd25447a3a918f8f01 Reviewed-on: https://chromium-review.googlesource.com/c/1369777 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615106}(cherry picked from commit e83dbb375025234a1ff532a5f078eaafc66eb0c3) Reviewed-on: https://chromium-review.googlesource.com/c/1371887 Cr-Commit-Position: refs/branch-heads/3626@{#253} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/bc483fd1aeb0a77574a9f9ecb8f71ef2e0fd7884/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
,
Dec 12
Verified in Build: 73.0.3638.0 Canary Devices: iPhone X(iOS 12.0.1) and iPad Air(iOS 11.4.1) Manual fallback passwords screen 'Search bar' is now vertical centered, looks good Link to screenshot: https://drive.google.com/file/d/1AIhRPsmY4XGrKBWWP3YDbZOYWgn0K2pd/view?usp=sharing
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc483fd1aeb0a77574a9f9ecb8f71ef2e0fd7884 Commit: bc483fd1aeb0a77574a9f9ecb8f71ef2e0fd7884 Author: djean@google.com Commiter: javierrobles@chromium.org Date: 2018-12-11 14:18:21 +0000 UTC [ios] Fixed search bar vertical centering for manual fallback passwords Applied fix from https://crrev.com/c/1219002 Before: https://drive.google.com/open?id=1AGNo9K6UaSiFfiUuwv66kWUaUjuO2EzZ After: https://drive.google.com/open?id=1HakPAtC3Kmsk97xAMhOqzlfmipWEGMg5 Bug: 912527 Change-Id: I0d006ce240afc9d3ac7c50bd25447a3a918f8f01 Reviewed-on: https://chromium-review.googlesource.com/c/1369777 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615106}(cherry picked from commit e83dbb375025234a1ff532a5f078eaafc66eb0c3) Reviewed-on: https://chromium-review.googlesource.com/c/1371887 Cr-Commit-Position: refs/branch-heads/3626@{#253} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by martijnb@chromium.org
, Dec 6