Regression: Page gets back navigated to chrome://settings even though focus is not visible on back button |
|
Issue descriptionChrome Version: 73.0.3632.0 Revision 914f5b8f721ff5a734bb22a96363191c20c8c3f2-refs/branch-heads/3632@{#1}(32/64 bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.14.2,10.13.1,10.13.6) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://settings page. (2) Click on 'Chrome name and picture'(it will navigate to chrome://settings/manageProfile),then hitt Enter key. (3) Observe. Actual: Page gets back navigated to chrome://settings after hitting Enter key even though focus is not visible on back button. Expected: Page should not back navigated to chrome://settings page if focus is not visible. This is a regression issue, broken in 'M68', below is bisect info: Good Build:68.0.3439.0 Bad Build: 68.0.3440.0 You are probably looking for a change made after 561690 (known good), but no later than 561691 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e44b8a89d4d887f6503ade46df6312526fca4ecc..8fd1d095826d4a4e021879166bea4149b11561d2 Suspect: https://chromium.googlesource.com/chromium/src/+/8fd1d095826d4a4e021879166bea4149b11561d2 @hcarmona: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also seen on Stable build #71.0.3578.80, Beta build #71.0.3578.80 and Dev build #72.0.3626.7
,
Dec 7
Update: With respect to comment1, Focus should be visible on back button for 1st instance also as hitting Enter key it navigates to previous page. However, focus is seen on back button from 2nd instance as expected for accessibility. Thank you.
,
Dec 7
When the page is entered using the mouse, we do not show the focus ripple. However, when the page is entered using only keyboard we will show focus. This is a design choice because focus is not as important when navigating with the mouse, but it very important for keyboard-only navigation. This focus paradigm is true across many elements in the webui. If this is causing issues it might make sense to file a larger bug so we can have a discussion with designers involved so we can have a single fix across all our elements. |
|
►
Sign in to add a comment |
|
Comment 1 by hcarmona@chromium.org
, Dec 7