New issue
Advanced search Search tips

Issue 912516 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add Credit Card Type Asset Autofill Manual Fallback

Project Member Reported by martijnb@chromium.org, Dec 6

Issue description

iPhone and iPad

Add Credit Card Type Asset Autofill Manual Fallback

Specs here:
https://folio.googleplex.com/ntp/Autofill/Autofill%20Manual%20Fallback

Assets should already be available, if not let me know. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b27d290eab4ed6d50a84f1ddf959e82039afeff

commit 7b27d290eab4ed6d50a84f1ddf959e82039afeff
Author: David Jean <djean@google.com>
Date: Thu Dec 06 17:21:52 2018

[ios] Add credit card logo to manual fallback cells

Bug:  912516 
Change-Id: Ibb72af9f02dfe63a206e7039bb388009b1ecd670
Reviewed-on: https://chromium-review.googlesource.com/c/1365448
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614395}
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/credit_card.h
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/credit_card.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/credit_card_unittest.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
[modify] https://crrev.com/7b27d290eab4ed6d50a84f1ddf959e82039afeff/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Labels: Merge-Request-72
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 8

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4325ad1f8ad7a8f11ec7225b56900336188c901a

commit 4325ad1f8ad7a8f11ec7225b56900336188c901a
Author: David Jean <djean@google.com>
Date: Mon Dec 10 09:28:35 2018

[ios] Add credit card logo to manual fallback cells

Bug:  912516 
Change-Id: Ibb72af9f02dfe63a206e7039bb388009b1ecd670
Reviewed-on: https://chromium-review.googlesource.com/c/1365448
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614395}(cherry picked from commit 7b27d290eab4ed6d50a84f1ddf959e82039afeff)
Reviewed-on: https://chromium-review.googlesource.com/c/1369785
Cr-Commit-Position: refs/branch-heads/3626@{#183}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/credit_card.h
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/credit_card.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/credit_card_unittest.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
[modify] https://crrev.com/4325ad1f8ad7a8f11ec7225b56900336188c901a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Cc: subhashi...@chromium.org
Status: Verified (was: Fixed)
Verified on M73.0.3637.0 canary
iOS12.1.2 beta
iPhoneX

Credit Card Logo is displayed.
Verified on 72.0.3626.15 Beta,  iPhoneXr iOS 12.1.1
Looks good


Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/4325ad1f8ad7a8f11ec7225b56900336188c901a

Commit: 4325ad1f8ad7a8f11ec7225b56900336188c901a
Author: djean@google.com
Commiter: javierrobles@chromium.org
Date: 2018-12-10 09:28:35 +0000 UTC

[ios] Add credit card logo to manual fallback cells

Bug:  912516 
Change-Id: Ibb72af9f02dfe63a206e7039bb388009b1ecd670
Reviewed-on: https://chromium-review.googlesource.com/c/1365448
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614395}(cherry picked from commit 7b27d290eab4ed6d50a84f1ddf959e82039afeff)
Reviewed-on: https://chromium-review.googlesource.com/c/1369785
Cr-Commit-Position: refs/branch-heads/3626@{#183}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment