Passwords Popover has an unintended dynamic height animation Autofill Manual Fallback |
|||||||
Issue descriptioniPad Passwords Popover has an unintended dynamic height animation when tapping on the Passwords icon.
,
Dec 6
It seems like in general, the Passwords popover doesn't rightfully follow the height of its contents. It adds additional height.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db433ca4d3ed804a5363f96804740e6b18638084 commit db433ca4d3ed804a5363f96804740e6b18638084 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Wed Dec 12 11:47:15 2018 [iOS][MF] Fixes the size of the popover for passwords Reduces the estimated size of the row to the minimum, so it is correctly calculated on |contentSize|. Starts the view controller with a more appropiate size for the popover. Bug: 912515 Change-Id: If7c2dc4a0ab2a6df445fdac2c5fc21453927a71c Reviewed-on: https://chromium-review.googlesource.com/c/1371873 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615855} [modify] https://crrev.com/db433ca4d3ed804a5363f96804740e6b18638084/ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm [modify] https://crrev.com/db433ca4d3ed804a5363f96804740e6b18638084/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
,
Dec 12
,
Dec 12
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee commit 191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Thu Dec 13 12:17:43 2018 [iOS][MF] Fixes the size of the popover for passwords Reduces the estimated size of the row to the minimum, so it is correctly calculated on |contentSize|. Starts the view controller with a more appropiate size for the popover. Bug: 912515 Change-Id: If7c2dc4a0ab2a6df445fdac2c5fc21453927a71c Reviewed-on: https://chromium-review.googlesource.com/c/1371873 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615855}(cherry picked from commit db433ca4d3ed804a5363f96804740e6b18638084) Reviewed-on: https://chromium-review.googlesource.com/c/1375715 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#323} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee/ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm [modify] https://crrev.com/191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
,
Dec 18
As discussed offline, the popoover should have a fixed starting height, equal to the height of the popover when there would be 1 credential. This is to prevent unnecessary animations.
,
Dec 19
Ass discussed offline today, the current size is the right one for now.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee Commit: 191292ba22bd7f41d062a3ec3e9e3fa3dbbd31ee Author: javierrobles@chromium.org Commiter: javierrobles@chromium.org Date: 2018-12-13 12:17:43 +0000 UTC [iOS][MF] Fixes the size of the popover for passwords Reduces the estimated size of the row to the minimum, so it is correctly calculated on |contentSize|. Starts the view controller with a more appropiate size for the popover. Bug: 912515 Change-Id: If7c2dc4a0ab2a6df445fdac2c5fc21453927a71c Reviewed-on: https://chromium-review.googlesource.com/c/1371873 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615855}(cherry picked from commit db433ca4d3ed804a5363f96804740e6b18638084) Reviewed-on: https://chromium-review.googlesource.com/c/1375715 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#323} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by javierrobles@chromium.org
, Dec 6